Skip to content

Commit 9410640

Browse files
WeiN76LQhplafosse
authored andcommitted
[SharedCache] Always load image dependencies
Simple change that means an image's dependencies can be loaded via the DSC triage view whether the primary image has already been loaded or not. Sometimes I've already loaded an image and then later on decide I want to load its dependencies. Currently there is no easy way to do that in the UI.
1 parent a828f05 commit 9410640

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

view/sharedcache/ui/dsctriage.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,11 @@ void DSCTriageView::loadImagesWithAddr(const std::vector<uint64_t>& addresses, b
8282
for (const uint64_t& addr : addresses)
8383
{
8484
auto image = controller->GetImageContaining(addr);
85-
// Only try to load if we have not already.
86-
if (image.has_value() && !controller->IsImageLoaded(*image))
85+
if (image.has_value())
8786
{
88-
images.insert({image->headerAddress, *image});
87+
// Only try to load if we have not already.
88+
if (!controller->IsImageLoaded(*image))
89+
images.insert({image->headerAddress, *image});
8990

9091
// TODO: We currently only add direct dependencies, may want to make the depth configurable?
9192
if (includeDependencies)

0 commit comments

Comments
 (0)