Skip to content

Commit 79d8d14

Browse files
committed
Remove From Conf<Ref<Type>> impl for BNTypeWithConfidence
1 parent 98a5094 commit 79d8d14

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

rust/src/architecture.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2474,8 +2474,8 @@ where
24742474
if let Some(intrinsic) = custom_arch.intrinsic_from_id(intrinsic) {
24752475
let inputs = intrinsic.outputs();
24762476
let mut res = Vec::with_capacity(inputs.len());
2477-
for input in inputs {
2478-
res.push(input.into());
2477+
for input in inputs.iter() {
2478+
res.push(input.as_ref().into());
24792479
}
24802480

24812481
unsafe {

rust/src/binaryview.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,14 +576,14 @@ pub trait BinaryViewExt: BinaryViewBase {
576576

577577
fn define_auto_data_var(&self, dv: DataVariable) {
578578
unsafe {
579-
BNDefineDataVariable(self.as_ref().handle, dv.address, &mut dv.t.into());
579+
BNDefineDataVariable(self.as_ref().handle, dv.address, &mut dv.t.as_ref().into());
580580
}
581581
}
582582

583583
/// You likely would also like to call [`Self::define_user_symbol`] to bind this data variable with a name
584584
fn define_user_data_var(&self, dv: DataVariable) {
585585
unsafe {
586-
BNDefineUserDataVariable(self.as_ref().handle, dv.address, &mut dv.t.into());
586+
BNDefineUserDataVariable(self.as_ref().handle, dv.address, &mut dv.t.as_ref().into());
587587
}
588588
}
589589

rust/src/types.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -260,15 +260,6 @@ impl From<BNOffsetWithConfidence> for Conf<i64> {
260260
}
261261
}
262262

263-
impl From<Conf<Ref<Type>>> for BNTypeWithConfidence {
264-
fn from(conf: Conf<Ref<Type>>) -> Self {
265-
Self {
266-
type_: conf.contents.handle,
267-
confidence: conf.confidence,
268-
}
269-
}
270-
}
271-
272263
impl From<Conf<&Type>> for BNTypeWithConfidence {
273264
fn from(conf: Conf<&Type>) -> Self {
274265
Self {

0 commit comments

Comments
 (0)