Bug fix for legalEntityRetrivalRequest (#15)

* commit changes

* Commit test validation

Author: jayeshb1313

CHANGELOG.md

@@ -1,5 +1,8 @@
 CHANGELOG
 ---------
+## 15.0.1
+* **Bug Fix** Fix for returning principal list in legalEntityRetrievalResponse.
+
 ## 15.0.0
 * **Feature Support for Payfac MP API version 15.0**
 Complex element -pciLevel of type pciLevelScore added in legalEntityCreateRequest
@@ -12,7 +15,6 @@ revenueBoost of type subMerchantRevenueBoostFeature
 subMerchantRevenueBoostFeature of type boolean with enabled would be True/false
 complianceProducts contain elements with their type:code of type complianceProductCode,name of type string,active of type boolean,activation of type date ,deActivation of type date,complianceStatus of type string,complianceStatusDate of type date
 
-
 ## 14.0.1
 * **Bug Fix** Fix for recursive language call.
 

PayFacMpSDK/PayFacMpSDK/Generated.cs

@@ -3353,7 +3353,7 @@ public string[] errors
     [System.ComponentModel.DesignerCategoryAttribute("code")]
     [System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard")]
     [System.Xml.Serialization.XmlRootAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard", IsNullable = false)]
-    public partial class legalEntityCreateRequest
+    public partial class legalEntityCreateRequestBase
     {
 
         private string legalEntityNameField;
@@ -3374,8 +3374,6 @@ public partial class legalEntityCreateRequest
 
         private address addressField;
 
-        private legalEntityPrincipal principalField;
-
         private string yearsInBusinessField;
 
         private pciLevelScore pciLevelField;
@@ -3501,19 +3499,6 @@ public address address
             }
         }
 
-        /// <remarks/>
-        public legalEntityPrincipal principal
-        {
-            get
-            {
-                return this.principalField;
-            }
-            set
-            {
-                this.principalField = value;
-            }
-        }
-
         /// <remarks/>
         public string yearsInBusiness
         {
@@ -3552,17 +3537,17 @@ public string language
 
             }
         }
-        
+
         public pciLevelScore pciLevel
         {
             get
             {
                 return this.pciLevelField;
             }
             set
-            {                
-                    this.pciLevelField = value;
-                    this.pciLevelIntValue = (int)value;
+            {
+                this.pciLevelField = value;
+                this.pciLevelIntValue = (int)value;
             }
         }
         [System.Xml.Serialization.XmlIgnore]
@@ -3579,6 +3564,33 @@ public int? pciLevelIntValue
         }
     }
 
+    /// <remarks/>
+    [System.CodeDom.Compiler.GeneratedCodeAttribute("xsd", "4.6.1055.0")]
+    [System.SerializableAttribute()]
+    [System.Diagnostics.DebuggerStepThroughAttribute()]
+    [System.ComponentModel.DesignerCategoryAttribute("code")]
+    [System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard")]
+    [System.Xml.Serialization.XmlRootAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard", IsNullable = false)]
+    public partial class legalEntityCreateRequest : legalEntityCreateRequestBase
+    {
+        private legalEntityPrincipal principalField;
+
+
+        /// <remarks/>
+        public legalEntityPrincipal principal
+        {
+            get
+            {
+                return this.principalField;
+            }
+            set
+            {
+                this.principalField = value;
+            }
+        }
+
+    }
+
     /// <remarks/>
     [System.CodeDom.Compiler.GeneratedCodeAttribute("xsd", "4.6.1055.0")]
     [System.SerializableAttribute()]
@@ -3864,10 +3876,10 @@ public bool duplicateSpecified
     [System.ComponentModel.DesignerCategoryAttribute("code")]
     [System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard")]
     [System.Xml.Serialization.XmlRootAttribute(Namespace = "http://payfac.vantivcnp.com/api/merchant/onboard", IsNullable = false)]
-    public partial class legalEntityRetrievalResponse : legalEntityCreateRequest
+    public partial class legalEntityRetrievalResponse : legalEntityCreateRequestBase
     {
 
-        private legalEntityPrincipal legalEntityPrincipalField;
+        private legalEntityPrincipal[] legalEntityPrincipalField;
 
         private string legalEntityIdField;
 
@@ -3896,7 +3908,8 @@ public partial class legalEntityRetrievalResponse : legalEntityCreateRequest
         private string overallStatusField;
 
         /// <remarks/>
-        public legalEntityPrincipal legalEntityPrincipal
+        [XmlElement("principal")]
+        public legalEntityPrincipal[] principal
         {
             get
             {

PayFacMpSDK/PayFacMpSDK/Versions.cs

@@ -2,7 +2,7 @@ namespace PayFacMpSDK
 {
     public class Versions
     {
-        public static string SDK_VERSION = "15.0.0";
+        public static string SDK_VERSION = "15.0.1";
         public static string LANGUAGE = "dotnet";
     }
 }

PayFacMpSDK/PayFacMpSDKTest/Functional/TestLegalEntityRetrievalRequest.cs

@@ -26,8 +26,23 @@ public void TestGetLegalEntityRetrievalRequestSimple()
             Assert.AreEqual(legalEntitytId, response.legalEntityId);
             Assert.AreEqual(10, response.responseCode);
             Assert.AreEqual("Approved", response.responseDescription);
+            //Testing the first principal
+            Assert.AreEqual(1, response.principal[0].principalId);
+            //Testing the second principal that is not present in the response
+            Assert.Throws<IndexOutOfRangeException>(() => { var _ = response.principal[1].principalId; });
         }
 
+        [Test]
+        public void TestGetLegalEntityRetrievalRequestPrincipleCheck()
+        {
+            legalEntitytId = "201008";
+            legalEntityRetrievalResponse response = new LegalEntityRetrievalRequest().GetLegalEntityRequest(legalEntitytId);
+            Assert.AreEqual(legalEntitytId, response.legalEntityId);
+            Assert.AreEqual(1, response.principal[0].principalId);
+            Assert.AreEqual(2, response.principal[1].principalId);
+            Assert.AreEqual(10, response.responseCode);
+            Assert.AreEqual("Approved", response.responseDescription);
+        }
 
         [Test]
         public void TestGetLegalEntityRetrievalRequestManualReview()