From d1f38bbc20581cc8274f62ca2cc5fd159d77ff55 Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Fri, 21 Mar 2025 07:07:39 +0000 Subject: [PATCH 1/3] Add completion job so we can have dependabot auto-merge and required builds --- .github/workflows/ci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d7909599..05de00b4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -197,3 +197,15 @@ jobs: fail_ci_if_error: true token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} + + completion: + needs: build + runs-on: ubuntu-latest + if: always() # Run even if one matrix job fails + steps: + - name: Check matrix job status + run: |- + if ! ${{ needs.build.result == 'success' }}; then + echo "One or more matrix jobs failed" + exit 1 + fi From 7c2dfedbc9364467916f5919a89ee1ad7ce9b73f Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Fri, 21 Mar 2025 08:17:40 +0000 Subject: [PATCH 2/3] Try multiple completion builds --- .github/workflows/docker-build.yml | 12 ++++++++++++ .github/workflows/lint.yml | 12 ++++++++++++ .github/workflows/skip-tests.yml | 12 ++++++++++++ .github/workflows/windows-ci.yml | 12 ++++++++++++ 4 files changed, 48 insertions(+) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index b6d932b0..206c7486 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -47,3 +47,15 @@ jobs: target: ${{ matrix.image.name }} tags: |- adamtheturtle/vuforia-${{ matrix.image.name }}-mock:latest + + completion: + needs: build + runs-on: ubuntu-latest + if: always() # Run even if one matrix job fails + steps: + - name: Check matrix job status + run: |- + if ! ${{ needs.build.result == 'success' }}; then + echo "One or more matrix jobs failed" + exit 1 + fi diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index bf38c941..158884b5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -42,3 +42,15 @@ jobs: - uses: pre-commit-ci/lite-action@v1.1.0 if: always() + + completion: + needs: build + runs-on: ubuntu-latest + if: always() # Run even if one matrix job fails + steps: + - name: Check matrix job status + run: |- + if ! ${{ needs.build.result == 'success' }}; then + echo "One or more matrix jobs failed" + exit 1 + fi diff --git a/.github/workflows/skip-tests.yml b/.github/workflows/skip-tests.yml index dcd3e395..6ae70873 100644 --- a/.github/workflows/skip-tests.yml +++ b/.github/workflows/skip-tests.yml @@ -87,3 +87,15 @@ jobs: # which tells us to use the token to avoid errors. token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} + + completion: + needs: build + runs-on: ubuntu-latest + if: always() # Run even if one matrix job fails + steps: + - name: Check matrix job status + run: |- + if ! ${{ needs.build.result == 'success' }}; then + echo "One or more matrix jobs failed" + exit 1 + fi diff --git a/.github/workflows/windows-ci.yml b/.github/workflows/windows-ci.yml index 6dae091e..3cb3e85f 100644 --- a/.github/workflows/windows-ci.yml +++ b/.github/workflows/windows-ci.yml @@ -76,3 +76,15 @@ jobs: # which tells us to use the token to avoid errors. token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} + + completion: + needs: build + runs-on: ubuntu-latest + if: always() # Run even if one matrix job fails + steps: + - name: Check matrix job status + run: |- + if ! ${{ needs.build.result == 'success' }}; then + echo "One or more matrix jobs failed" + exit 1 + fi From d85edf62aa78b85b0925798c1d07ac830e60cec2 Mon Sep 17 00:00:00 2001 From: Adam Dangoor Date: Fri, 21 Mar 2025 08:34:48 +0000 Subject: [PATCH 3/3] Uniquely name completion jobs so we can require them --- .github/workflows/ci.yml | 2 +- .github/workflows/docker-build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/skip-tests.yml | 2 +- .github/workflows/windows-ci.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 05de00b4..9d05fd2c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -198,7 +198,7 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} - completion: + completion-ci: needs: build runs-on: ubuntu-latest if: always() # Run even if one matrix job fails diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index 206c7486..fec42f47 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -48,7 +48,7 @@ jobs: tags: |- adamtheturtle/vuforia-${{ matrix.image.name }}-mock:latest - completion: + completion-docker: needs: build runs-on: ubuntu-latest if: always() # Run even if one matrix job fails diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 158884b5..b4f424fc 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -43,7 +43,7 @@ jobs: - uses: pre-commit-ci/lite-action@v1.1.0 if: always() - completion: + completion-lint: needs: build runs-on: ubuntu-latest if: always() # Run even if one matrix job fails diff --git a/.github/workflows/skip-tests.yml b/.github/workflows/skip-tests.yml index 6ae70873..19b89a9e 100644 --- a/.github/workflows/skip-tests.yml +++ b/.github/workflows/skip-tests.yml @@ -88,7 +88,7 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} - completion: + completion-skip-tests: needs: build runs-on: ubuntu-latest if: always() # Run even if one matrix job fails diff --git a/.github/workflows/windows-ci.yml b/.github/workflows/windows-ci.yml index 3cb3e85f..ae1e3376 100644 --- a/.github/workflows/windows-ci.yml +++ b/.github/workflows/windows-ci.yml @@ -77,7 +77,7 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }} - completion: + completion-windows-ci: needs: build runs-on: ubuntu-latest if: always() # Run even if one matrix job fails