Skip to content

Commit 98058eb

Browse files
Merge pull request #2166 from VWS-Python/more-dirtyequals
Rework a test_query test to use dirty_equals
2 parents 818a4bc + 95c3432 commit 98058eb

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

tests/mock_vws/test_query.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import pytest
2525
import requests
26+
from dirty_equals import IsInstance
2627
from PIL import Image
2728
from tenacity import Retrying
2829
from tenacity.retry import retry_if_exception_type
@@ -531,18 +532,15 @@ def test_match_exact(
531532

532533
assert_query_success(response=response)
533534
(result,) = response.json()["results"]
534-
assert result.keys() == {"target_id", "target_data"}
535-
assert result["target_id"] == target_id
536-
target_data = result["target_data"]
537-
assert target_data.keys() == {
538-
"application_metadata",
539-
"name",
540-
"target_timestamp",
535+
assert result == {
536+
"target_id": target_id,
537+
"target_data": {
538+
"application_metadata": metadata_encoded,
539+
"name": name,
540+
"target_timestamp": IsInstance(expected_type=int),
541+
},
541542
}
542-
assert target_data["application_metadata"] == metadata_encoded
543-
assert target_data["name"] == name
544-
target_timestamp = target_data["target_timestamp"]
545-
assert isinstance(target_timestamp, int)
543+
target_timestamp = int(result["target_data"]["target_timestamp"])
546544
time_difference = abs(approximate_target_created - target_timestamp)
547545
max_time_difference = 5
548546
assert time_difference < max_time_difference

0 commit comments

Comments
 (0)