Skip to content

Ctrl+A doesn't work in GUI runner's filter edit #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PRRB opened this issue Nov 23, 2024 · 4 comments
Open

Ctrl+A doesn't work in GUI runner's filter edit #349

PRRB opened this issue Nov 23, 2024 · 4 comments

Comments

@PRRB
Copy link

PRRB commented Nov 23, 2024

Ctrl+C, Ctrl+V, Ctrl+X etc. all work as expected, but Ctrl+A does not?
I seem to run into this issue surprisingly often.

Can be worked around with an OnKeyDown listener - not sure that's an appropriate fix though, doesn't address why it's not working in the first place. It should be native behavior form the underlying control right? Something is interfering with that?

procedure TGUIVCLTestRunner.edtFilterKeyDown(Sender: TObject; var Key: Word; Shift: TShiftState);
begin
  if (Shift = [ssCtrl]) and (Key = vkA) then
    edtFilter.SelectAll;
end;

I use D10.4UP2, if that's relevant, and this is with latest Commit d9dca12 2024-07-29

@rmcginty
Copy link
Contributor

rmcginty commented Dec 1, 2024

I'll take a look at this. I don't remember any reason it would be by design. Sometimes another shortcut property gets set by accident and takes precedence...

@rmcginty
Copy link
Contributor

rmcginty commented Jan 8, 2025

I finally got around to looking at this and I should have a fix in the next day or so.

@PhilBarwood
Copy link
Contributor

PhilBarwood commented Mar 31, 2025

You can repro the same issue with an empty forms app, with a single TEdit dropped onto it, and then disabling runtime themes:
<AppEnableRuntimeThemes>false</AppEnableRuntimeThemes>

Yep it is bizarre that themes changes the behaviour of just the Ctrl+A shortcut on edits but this isn't a DUnitX-specific problem.

It might be an idea to enable runtime themes in the Examples (VCLGUI) project(s) .dproj files though?

E.g. DUnitXVCLGUI_D10Berlin.dproj doesn't have it, and it also breaks some styling on the form:
Image

With themes:
Image

@rmcginty
Copy link
Contributor

rmcginty commented Apr 4, 2025

Hmm, that is interesting. I can't remember if I didn't enable themes for any specific reason or not, but I will take that into account. I've just been so busy lately, I've not been able to address this yet, but going to soon. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants