insider-spearhead build failed #2430
Description
Hi,
Can you please check the insider-spearhead build failed related with the update on brand.patch...?
Especially in the gettingStartedContent file...
On Github
@@ -21,4 +20,2 @@ interface IGettingStartedContentProvider {
-export const copilotSettingsMessage = localize({ key: 'settings', comment: ['{Locked=""}', '{Locked=""}', '{Locked="]({1})"}'] }, "{0} Copilot Free, Pro and Pro+ may show public code suggestions and we may use your data for product improvement. You can change these settings at any time.", product.defaultChatAgent?.providerName, product.defaultChatAgent?.publicCodeMatchesUrl, product.defaultChatAgent?.manageSettingsUrl);
class GettingStartedContentProviderRegistry {
My modification
@@ -21,11 +20,2 @@ interface IGettingStartedContentProvider {
-const defaultChat = {
- documentationUrl: product.defaultChatAgent?.documentationUrl ?? '',
- manageSettingsUrl: product.defaultChatAgent?.manageSettingsUrl ?? '',
- provider: product.defaultChatAgent?.provider ?? { default: { name: '' } },
- publicCodeMatchesUrl: product.defaultChatAgent?.publicCodeMatchesUrl ?? '',
-};
-export const copilotSettingsMessage = localize({ key: 'settings', comment: ['{Locked=""}', '{Locked=""}', '{Locked="]({1})"}'] }, "{0} Copilot Free, Pro and Pro+ may show public code suggestions and we may use your data for product improvement. You can change these settings at any time.", defaultChat.provider.default.name, defaultChat.publicCodeMatchesUrl, defaultChat.manageSettingsUrl);
class GettingStartedContentProviderRegistry {
On Github
@@ -218,24 +204,2 @@ const Button = (title: string, href: string) => [${title}](${href});
-const CopilotStepTitle = localize('gettingStarted.copilotSetup.title', "Use AI features with Copilot for free");
-const CopilotDescription = localize({ key: 'gettingStarted.copilotSetup.description', comment: ['{Locked=""}', '{Locked=""}'] }, "You can use Copilot to generate code across multiple files, fix errors, ask questions about your code and much more using natural language.", product.defaultChatAgent?.documentationUrl ?? '');
-const CopilotSignedOutButton = Button(localize('setupCopilotButton.signIn', "Set up Copilot"), command:workbench.action.chat.triggerSetup);
-const CopilotSignedInButton = Button(localize('setupCopilotButton.setup', "Set up Copilot"), command:workbench.action.chat.triggerSetup);
-const CopilotCompleteButton = Button(localize('setupCopilotButton.chatWithCopilot', "Chat with Copilot"), 'command:workbench.action.chat.open');
-function createCopilotSetupStep(id: string, button: string, when: string, includeTerms: boolean): BuiltinGettingStartedStep {
- const description = includeTerms ?
-
`${CopilotDescription}\n\n${button}` : -
`${CopilotDescription}\n${button}`; - return {
-
id, -
title: CopilotStepTitle, -
description, -
when: `${when} && !chatSetupHidden`, -
media: { -
type: 'svg', altText: 'VS Code Copilot multi file edits', path: 'multi-file-edits.svg' -
}, - };
-}
export const walkthroughs: GettingStartedWalkthroughContent = [
My modification
@@ -218,24 +204,2 @@ const Button = (title: string, href: string) => [${title}](${href});
-const CopilotStepTitle = localize('gettingStarted.copilotSetup.title', "Use AI features with Copilot for free");
-const CopilotDescription = localize({ key: 'gettingStarted.copilotSetup.description', comment: ['{Locked=""}', '{Locked=""}'] }, "You can use Copilot to generate code across multiple files, fix errors, ask questions about your code and much more using natural language.", defaultChat.documentationUrl ?? '');
-const CopilotSignedOutButton = Button(localize('setupCopilotButton.signIn', "Set up Copilot"), command:workbench.action.chat.triggerSetup);
-const CopilotSignedInButton = Button(localize('setupCopilotButton.setup', "Set up Copilot"), command:workbench.action.chat.triggerSetup);
-const CopilotCompleteButton = Button(localize('setupCopilotButton.chatWithCopilot', "Chat with Copilot"), 'command:workbench.action.chat.open');
-function createCopilotSetupStep(id: string, button: string, when: string, includeTerms: boolean): BuiltinGettingStartedStep {
- const description = includeTerms ?
-
`${CopilotDescription}\n\n${button}` : -
`${CopilotDescription}\n${button}`; - return {
-
id, -
title: CopilotStepTitle, -
description, -
when: `${when} && !chatSetupHidden`, -
media: { -
type: 'svg', altText: 'VS Code Copilot multi file edits', path: 'multi-file-edits.svg' -
}, - };
-}
export const walkthroughs: GettingStartedWalkthroughContent = [
On Github
@@ -672,66 +585,2 @@ export const walkthroughs: GettingStartedWalkthroughContent = [
},
- {
-
id: `${NEW_WELCOME_EXPERIENCE}`, -
title: localize('gettingStarted.new.title', "Get started with VS Code"), -
description: localize('gettingStarted.new.description', "Supercharge coding with AI"), -
isFeatured: false, -
icon: setupIcon, -
when: '!isWeb', -
walkthroughPageTitle: localize('gettingStarted.new.walkthroughPageTitle', 'Set up VS Code'), -
content: { -
type: 'steps', -
steps: [ -
{ -
id: 'copilotSetup.chat', -
title: localize('gettingStarted.agentMode.title', "Agent mode"), -
description: localize('gettingStarted.agentMode.description', "Analyzes the problem, plans next steps, and makes changes for you."), -
media: { -
type: 'svg', altText: 'VS Code Copilot multi file edits', path: 'multi-file-edits.svg' -
}, -
}, -
{ -
id: 'copilotSetup.inline', -
title: localize('gettingStarted.nes.title', "Next edit suggestions"), -
description: localize('gettingStarted.nes.description', "Get code suggestions that predict your next edit."), -
media: { -
type: 'svg', altText: 'Next edit suggestions', path: 'ai-powered-suggestions.svg' -
}, -
}, -
{ -
id: 'copilotSetup.customize', -
title: localize('gettingStarted.customize.title', "Personalized to how you work"), -
description: localize('gettingStarted.customize.description', "Swap models, add agent mode tools, and create personalized instructions.\n{0}", Button(localize('signUp', "Set up AI"), 'command:workbench.action.chat.triggerSetupWithoutDialog')), -
media: { -
type: 'svg', altText: 'Personalize', path: 'customize-ai.svg' -
}, -
}, -
{ -
id: 'newCommandPaletteTask', -
title: localize('newgettingStarted.commandPalette.title', "All commands within reach"), -
description: localize('gettingStarted.commandPalette.description.interpolated', "Run commands without reaching for your mouse to accomplish any task in VS Code.\n{0}", Button(localize('commandPalette', "Open Command Palette"), 'command:workbench.action.showCommands')), -
media: { type: 'svg', altText: 'Command Palette overlay for searching and executing commands.', path: 'commandPalette.svg' }, -
}, -
{ -
id: 'newPickColorTheme', -
title: localize('gettingStarted.pickColor.title', "Choose your theme"), -
description: localize('gettingStarted.pickColor.description.interpolated', "The right theme helps you focus on your code, is easy on your eyes, and is simply more fun to use.\n{0}", Button(localize('titleID', "Browse Color Themes"), 'command:workbench.action.selectTheme')), -
completionEvents: [ -
'onSettingChanged:workbench.colorTheme', -
'onCommand:workbench.action.selectTheme' -
], -
media: { type: 'markdown', path: 'theme_picker_small', } -
}, -
{ -
id: 'newFindLanguageExtensions', -
title: localize('newgettingStarted.findLanguageExts.title', "Support for all languages"), -
description: localize('newgettingStarted.findLanguageExts.description.interpolated', "Install the language extensions you need in your toolkit.\n{0}", Button(localize('browseLangExts', "Browse Language Extensions"), 'command:workbench.extensions.action.showLanguageExtensions')), -
when: 'workspacePlatform != \'webworker\'', -
media: { -
type: 'svg', altText: 'Language extensions', path: 'languages.svg' -
}, -
}, -
] -
} - }
];
My modification
@@ -672,66 +585,2 @@ export const walkthroughs: GettingStartedWalkthroughContent = [
},
- {
-
id: `${NEW_WELCOME_EXPERIENCE}`, -
title: localize('gettingStarted.new.title', "Get started with VS Code"), -
description: localize('gettingStarted.new.description', "Supercharge coding with AI"), -
isFeatured: false, -
icon: setupIcon, -
when: '!isWeb', -
walkthroughPageTitle: localize('gettingStarted.new.walkthroughPageTitle', 'Set up VS Code'), -
content: { -
type: 'steps', -
steps: [ -
{ -
id: 'copilotSetup.chat', -
title: localize('gettingStarted.agentMode.title', "Agent mode"), -
description: localize('gettingStarted.agentMode.description', "Analyzes the problem, plans next steps, and makes changes for you."), -
media: { -
type: 'svg', altText: 'VS Code Copilot multi file edits', path: 'multi-file-edits.svg' -
}, -
}, -
{ -
id: 'copilotSetup.inline', -
title: localize('gettingStarted.nes.title', "Next edit suggestions"), -
description: localize('gettingStarted.nes.description', "Get code suggestions that predict your next edit."), -
media: { -
type: 'svg', altText: 'Next edit suggestions', path: 'ai-powered-suggestions.svg' -
}, -
}, -
{ -
id: 'copilotSetup.customize', -
title: localize('gettingStarted.customize.title', "Personalized to how you work"), -
description: localize('gettingStarted.customize.description', "Swap models, add agent mode tools, and create personalized instructions.\n{0}", Button(localize('signUp', "Enable AI features"), 'command:workbench.action.chat.triggerSetupWithoutDialog')), -
media: { -
type: 'svg', altText: 'Personalize', path: 'customize-ai.svg' -
}, -
}, -
{ -
id: 'newCommandPaletteTask', -
title: localize('newgettingStarted.commandPalette.title', "All commands within reach"), -
description: localize('gettingStarted.commandPalette.description.interpolated', "Run commands without reaching for your mouse to accomplish any task in VS Code.\n{0}", Button(localize('commandPalette', "Open Command Palette"), 'command:workbench.action.showCommands')), -
media: { type: 'svg', altText: 'Command Palette overlay for searching and executing commands.', path: 'commandPalette.svg' }, -
}, -
{ -
id: 'newPickColorTheme', -
title: localize('gettingStarted.pickColor.title', "Choose your theme"), -
description: localize('gettingStarted.pickColor.description.interpolated', "The right theme helps you focus on your code, is easy on your eyes, and is simply more fun to use.\n{0}", Button(localize('titleID', "Browse Color Themes"), 'command:workbench.action.selectTheme')), -
completionEvents: [ -
'onSettingChanged:workbench.colorTheme', -
'onCommand:workbench.action.selectTheme' -
], -
media: { type: 'markdown', path: 'theme_picker_small', } -
}, -
{ -
id: 'newFindLanguageExtensions', -
title: localize('newgettingStarted.findLanguageExts.title', "Support for all languages"), -
description: localize('newgettingStarted.findLanguageExts.description.interpolated', "Install the language extensions you need in your toolkit.\n{0}", Button(localize('browseLangExts', "Browse Language Extensions"), 'command:workbench.extensions.action.showLanguageExtensions')), -
when: 'workspacePlatform != \'webworker\'', -
media: { -
type: 'svg', altText: 'Language extensions', path: 'languages.svg' -
}, -
}, -
] -
} - }
];
I try to build the latest insider version with this modification and the build is success...
Thanks
- Gijoy -