Add $ as a surround character (#8895)

Author: cjohnson19

src/actions/motion.ts

@@ -2090,7 +2090,7 @@ export class MoveAroundSquareBracket extends MoveInsideCharacter {
 export abstract class MoveQuoteMatch extends BaseMovement {
   override modes = [Mode.Normal, Mode.Visual, Mode.VisualBlock];
   protected readonly anyQuote: boolean = false;
-  protected abstract readonly charToMatch: '"' | "'" | '`';
+  protected abstract readonly charToMatch: '"' | "'" | '`' | '$';
   protected includeQuotes = false;
   override isJump = true;
   readonly which: WhichQuotes = 'current';
@@ -2232,6 +2232,20 @@ class MoveInsideSingleQuotes extends MoveQuoteMatch {
   override includeQuotes = false;
 }
 
+@RegisterAction
+export class MoveInsideDollarSign extends MoveQuoteMatch {
+  keys = ['i', '$'];
+  readonly charToMatch = '$';
+  override includeQuotes = false;
+}
+
+@RegisterAction
+export class MoveAroundDollarSign extends MoveQuoteMatch {
+  keys = ['a', '$'];
+  readonly charToMatch = '$';
+  override includeQuotes = true;
+}
+
 @RegisterAction
 export class MoveAroundSingleQuotes extends MoveQuoteMatch {
   keys = ['a', "'"];

src/actions/plugins/surround.ts

@@ -11,6 +11,7 @@ import {
   MoveAroundBacktick,
   MoveAroundCaret,
   MoveAroundCurlyBrace,
+  MoveAroundDollarSign,
   MoveAroundDoubleQuotes,
   MoveAroundParentheses,
   MoveAroundSingleQuotes,
@@ -499,6 +500,12 @@ class SurroundHelper {
       removeSpace: false,
       movement: () => new MoveAroundBacktick(false),
     },
+    $: {
+      left: '$',
+      right: '$',
+      removeSpace: true,
+      movement: () => new MoveAroundDollarSign(false),
+    },
     '<': { left: '', right: '', removeSpace: false, movement: () => new MoveAroundTag() },
     '*': {
       left: '*',

src/actions/plugins/targets/smartQuotesMatcher.ts

@@ -2,7 +2,7 @@ import { Position } from 'vscode';
 import { TextDocument } from 'vscode';
 import { configuration } from '../../../configuration/configuration';
 
-type Quote = '"' | "'" | '`';
+type Quote = '"' | "'" | '`' | '$';
 enum QuoteMatch {
   Opening,
   Closing,

src/common/matching/matcher.ts

@@ -33,6 +33,7 @@ export class PairMatcher {
     '"': { match: '"', isNextMatchForward: false, directionless: true },
     "'": { match: "'", isNextMatchForward: false, directionless: true },
     '`': { match: '`', isNextMatchForward: false, directionless: true },
+    $: { match: '$', isNextMatchForward: false, directionless: true },
   };
 
   private static findPairedChar(

src/common/matching/quoteMatcher.ts

@@ -11,7 +11,7 @@ export class QuoteMatcher {
 
   private readonly quoteMap: QuoteMatch[] = [];
 
-  constructor(quote: '"' | "'" | '`', corpus: string) {
+  constructor(quote: '"' | "'" | '`' | '$', corpus: string) {
     let openingQuote = true;
     // Loop over corpus, marking quotes and respecting escape characters.
     for (let i = 0; i < corpus.length; i++) {

test/plugins/smartQuotes.test.ts

@@ -33,6 +33,18 @@ suite('smartQuotes plugin', () => {
       keysPressed: "di'",
       end: ['aaa "bbb" c \'|\' '],
     });
+    newTest({
+      title: 'dollar sign - 1',
+      start: ['|aaa "bbb" c $d$ '],
+      keysPressed: 'di$',
+      end: ['aaa "bbb" c $|$ '],
+    });
+    newTest({
+      title: 'dollar sign - 2',
+      start: ['aaa "bbb" |c $d$ '],
+      keysPressed: 'di$',
+      end: ['aaa "bbb" c $|$ '],
+    });
     newTest({
       title: 'backtick - 1',
       start: ['|aaa "bbb" c `d` '],
@@ -63,6 +75,19 @@ suite('smartQuotes plugin', () => {
       keysPressed: 'diq',
       end: ['  \'aaa\' "bbb" c `|` '],
     });
+    newTest({
+      title: 'any-quote - 4',
+      start: ['  \'aaa\' "bbb" c| $d$ '],
+      keysPressed: 'diq',
+      end: ['  \'aaa\' "|" c $d$ '],
+    });
+    // Dollar signs should not be recognized as being inside quotes
+    newTest({
+      title: 'any-quote - 5',
+      start: ['|$aaa$'],
+      keysPressed: 'diq',
+      end: ['|$aaa$'],
+    });
     // test basic usage
     newTest({
       title: 'no quotes at all',