Little audit of unawaited promises

Author: J-Fields

extensionBase.ts

@@ -424,7 +424,7 @@ export async function activate(context: vscode.ExtensionContext, handleLocal: bo
       if (cmd) {
         await new ExCommandLine(cmd, mh.vimState.currentMode).run(mh.vimState);
       }
-      void mh.updateView();
+      mh.updateView();
     }
   });
 
@@ -455,7 +455,7 @@ export async function activate(context: vscode.ExtensionContext, handleLocal: bo
               command.command.slice(1, command.command.length),
               mh.vimState.currentMode,
             ).run(mh.vimState);
-            void mh.updateView();
+            mh.updateView();
           } else {
             await vscode.commands.executeCommand(command.command, command.args);
           }

src/actions/commands/commandLine.ts

@@ -414,7 +414,7 @@ class CommandAdvanceCurrentMatch extends CommandLineAction {
           ? SearchDirection.Backward
           : undefined;
     if (commandLine instanceof SearchCommandLine && direction !== undefined) {
-      void commandLine.advanceCurrentMatch(vimState, direction);
+      commandLine.advanceCurrentMatch(vimState, direction);
     }
   }
 }

src/cmd_line/commandLine.ts

@@ -525,7 +525,7 @@ export class SearchCommandLine extends CommandLine {
   /**
    * Called when <C-g> or <C-t> is pressed during SearchInProgress mode
    */
-  public async advanceCurrentMatch(vimState: VimState, direction: SearchDirection): Promise<void> {
+  public advanceCurrentMatch(vimState: VimState, direction: SearchDirection): void {
     // <C-g> always moves forward in the document, and <C-t> always moves back, regardless of search direction.
     // To compensate, multiply the desired direction by the searchState's direction, so that
     // effectiveDirection == direction * (searchState.direction)^2 == direction.

src/cmd_line/commands/leftRightCenter.ts

@@ -22,7 +22,7 @@ export class LeftCommand extends ExCommand {
   }
 
   async execute(vimState: VimState): Promise<void> {
-    void this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
+    await this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
   }
 
   override async executeWithRange(vimState: VimState, range: LineRange): Promise<void> {
@@ -61,7 +61,7 @@ export class RightCommand extends ExCommand {
   }
 
   async execute(vimState: VimState): Promise<void> {
-    void this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
+    await this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
   }
 
   override async executeWithRange(vimState: VimState, range: LineRange): Promise<void> {
@@ -105,7 +105,7 @@ export class CenterCommand extends ExCommand {
   }
 
   async execute(vimState: VimState): Promise<void> {
-    void this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
+    await this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
   }
 
   override async executeWithRange(vimState: VimState, range: LineRange): Promise<void> {

src/cmd_line/commands/shift.ts

@@ -38,7 +38,7 @@ export class ShiftCommand extends ExCommand {
   }
 
   public async execute(vimState: VimState): Promise<void> {
-    void this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
+    await this.executeWithRange(vimState, new LineRange(new Address({ type: 'current_line' })));
   }
 
   public override async executeWithRange(vimState: VimState, range: LineRange): Promise<void> {

src/mode/modeHandler.ts

@@ -414,7 +414,7 @@ export class ModeHandler implements vscode.Disposable, IModeHandler {
           end: this.vimState.cursorStopPosition,
         };
       }
-      void this.updateView({ drawSelection: toDraw, revealRange: false });
+      this.updateView({ drawSelection: toDraw, revealRange: false });
     }
   }