Skip to content

Commit 939df0e

Browse files
committed
Change configuration scope for several settings, disallowing setting them on the workspace level
This was a security concern, as a malicious workspace could hijack keystrokes or force you to open an arbitrary program (instead of neovim, as intended).
1 parent 666ea2f commit 939df0e

File tree

1 file changed

+22
-12
lines changed

1 file changed

+22
-12
lines changed

package.json

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -454,19 +454,23 @@
454454
},
455455
"vim.normalModeKeyBindings": {
456456
"type": "array",
457-
"markdownDescription": "Remapped keys in Normal mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
457+
"markdownDescription": "Remapped keys in Normal mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
458+
"scope": "application"
458459
},
459460
"vim.normalModeKeyBindingsNonRecursive": {
460461
"type": "array",
461-
"markdownDescription": "Non-recursive remapped keys in Normal mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
462+
"markdownDescription": "Non-recursive remapped keys in Normal mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
463+
"scope": "application"
462464
},
463465
"vim.operatorPendingModeKeyBindings": {
464466
"type": "array",
465-
"markdownDescription": "Remapped keys in OperatorPending mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
467+
"markdownDescription": "Remapped keys in OperatorPending mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
468+
"scope": "application"
466469
},
467470
"vim.operatorPendingModeKeyBindingsNonRecursive": {
468471
"type": "array",
469-
"markdownDescription": "Non-recursive remapped keys in OperatorPending mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
472+
"markdownDescription": "Non-recursive remapped keys in OperatorPending mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
473+
"scope": "application"
470474
},
471475
"vim.useCtrlKeys": {
472476
"type": "boolean",
@@ -518,27 +522,33 @@
518522
},
519523
"vim.insertModeKeyBindings": {
520524
"type": "array",
521-
"markdownDescription": "Remapped keys in Insert mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
525+
"markdownDescription": "Remapped keys in Insert mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
526+
"scope": "application"
522527
},
523528
"vim.insertModeKeyBindingsNonRecursive": {
524529
"type": "array",
525-
"markdownDescription": "Non-recursive keybinding overrides to use for Insert mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
530+
"markdownDescription": "Non-recursive keybinding overrides to use for Insert mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
531+
"scope": "application"
526532
},
527533
"vim.visualModeKeyBindings": {
528534
"type": "array",
529-
"markdownDescription": "Remapped keys in Visual mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
535+
"markdownDescription": "Remapped keys in Visual mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
536+
"scope": "application"
530537
},
531538
"vim.visualModeKeyBindingsNonRecursive": {
532539
"type": "array",
533-
"markdownDescription": "Non-recursive keybinding overrides to use for Visual mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
540+
"markdownDescription": "Non-recursive keybinding overrides to use for Visual mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
541+
"scope": "application"
534542
},
535543
"vim.commandLineModeKeyBindings": {
536544
"type": "array",
537-
"markdownDescription": "Remapped keys in command line mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
545+
"markdownDescription": "Remapped keys in command line mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
546+
"scope": "application"
538547
},
539548
"vim.commandLineModeKeyBindingsNonRecursive": {
540549
"type": "array",
541-
"markdownDescription": "Non-recursive keybinding overrides to use for command line mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details."
550+
"markdownDescription": "Non-recursive keybinding overrides to use for command line mode. Allows mapping to Vim commands or VS Code actions. See [README](https://github.com/VSCodeVim/Vim/#key-remapping) for details.",
551+
"scope": "application"
542552
},
543553
"vim.textwidth": {
544554
"type": "number",
@@ -904,7 +914,7 @@
904914
"type": "string",
905915
"markdownDescription": "Path to Neovim executable. For example, `/usr/bin/nvim`, or `C:\\Program Files\\Neovim\\bin\\nvim.exe`.",
906916
"default": "",
907-
"scope": "machine-overridable"
917+
"scope": "machine"
908918
},
909919
"vim.neovimUseConfigFile": {
910920
"type": "boolean",
@@ -915,7 +925,7 @@
915925
"type": "string",
916926
"markdownDescription": "Path to Neovim configuration file. `vim.neovimUseConfigFile` must be enabled. If path is left blank, Neovim will use its default config path, i.e. `~/.config/nvim/init.vim` or 'C:\\Users\\USERNAME\\AppData\\Local\\nvim\\init.vim'.",
917927
"default": "",
918-
"scope": "machine-overridable"
928+
"scope": "machine"
919929
},
920930
"vim.vimrc.enable": {
921931
"type": "boolean",

0 commit comments

Comments
 (0)