Slightly better error messages

Author: J-Fields

src/vimscript/exCommandParser.ts

@@ -687,11 +687,16 @@ export const exCommandParser: Parser<{ lineRange: LineRange | undefined; command
         );
       }
       const result = seq(parseArgs, optWhitespace.then(all)).parse(args);
-      if (result.status === false || result.value[1]) {
-        // TODO: All possible parsing errors are lumped into "trailing characters", which is wrong
+      if (result.status === false) {
+        if (result.index.offset === args.length) {
+          throw VimError.fromCode(ErrorCode.ArgumentRequired);
+        }
+        throw VimError.fromCode(ErrorCode.InvalidArgument474);
+      }
+      if (result.value[1]) {
         // TODO: Implement `:help :bar`
         // TODO: Implement `:help :comment`
-        throw VimError.fromCode(ErrorCode.TrailingCharacters);
+        throw VimError.fromCode(ErrorCode.TrailingCharacters, result.value[1]);
       }
       return { lineRange, command: result.value[0] };
     });

test/vimscript/expression.test.ts

@@ -426,7 +426,7 @@ suite('Vimscript expressions', () => {
       exprTest("'abc' ==? 'Abc'", { value: bool(true) });
     });
 
-    suite.only('Pattern matching', () => {
+    suite('Pattern matching', () => {
       exprTest("'apple' =~ '^a.*e$'", { value: bool(true) });
       // TODO
     });
@@ -532,7 +532,7 @@ suite('Vimscript expressions', () => {
   });
 
   suite('Builtin functions', () => {
-    suite.only('assert_*', () => {
+    suite('assert_*', () => {
       const PASS = { value: int(0) };
       const FAIL = { value: int(1) };