Merge pull request #10 from VSCodeVim/master

update master

Author: sql-koala

.github/CONTRIBUTING.md

@@ -14,6 +14,12 @@ When creating a new bug report do:
 - Search against existing issues to check if somebody else has already reported your problem or requested your idea
 - Fill out the issue template.
 
+### Improve Existing Issues
+
+- Search for [duplicate issues](https://github.com/VSCodeVim/Vim/issues?q=is%3Aissue+is%3Aopen+cursor). See which thread(s) are more mature, and recommend the duplicate be closed, or just provide links to related issues.
+- Find [old issues](https://github.com/VSCodeVim/Vim/issues?page=25&q=is%3Aissue+is%3Aopen) and test them in the latest version of VSCodeVim. If the issue has been resolved, comment & recommend OP to close (or provide more information if not resolved).
+- Give thumbs up / thumbs down to existing issues, to indicate your support (or not)
+
 ## Submitting Pull Requests
 
 Pull requests are _awesome_.
@@ -47,11 +53,15 @@ When submitting a PR, please fill out the template that is presented by GitHub w
 
     # Alternatively, build and run tests through gulp and npm scripts
     npx gulp build                  # build
-    yarn test                        # test (must close all instances of VSCode)
+    npx gulp prepare-test           # build tests
+    yarn test                       # test (must close all instances of VSCode)
 
     # Only available if Docker is installed and running
     npx gulp test                   # run tests inside Docker container
     npx gulp test --grep testSuite  # run only tests/suites filtered by js regex inside container
+
+    # Alternatively, build .vsix extension and load it into VSCode for manual testing
+    yarn run vsce package --web     # build vim-xxx.vsix
     ```
 
 ## Code Architecture

.github/workflows/build.yml

@@ -27,12 +27,11 @@ jobs:
         run: yarn install
 
       - name: Prettier
-        uses: creyD/prettier_action@v3.1
+        uses: creyD/prettier_action@v3.3
         with:
           prettier_options: '--write **/*.{ts,js,json,md,yml}'
           same_commit: true
-          # TODO: enable this once https://github.com/creyD/prettier_action/issues/31 is fixed
-          # only_changed: true
+          only_changed: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

.vscodeignore

@@ -4,7 +4,6 @@
 .vscode-test/**
 
 **/*.ts
-**/*.map
 *.yml
 
 src/**

CHANGELOG.md

@@ -1,13 +1,87 @@
 # Change Log
 
-## [v1.18.5](https://github.com/vscodevim/vim/tree/v1.18.5) (2020-12-10)
+## [v1.19.0](https://github.com/vscodevim/vim/tree/v1.19.0) (2021-03-18)
 
-[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.4...v1.18.5)
+[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.9...v1.19.0)
+
+**Enhancements:**
+
+- goto command not implemented [\#6025](https://github.com/VSCodeVim/Vim/issues/6025)
+- Use source maps to get intelligible stack traces [\#5887](https://github.com/VSCodeVim/Vim/issues/5887)
+
+**Fixed Bugs:**
+
+- Tests fail silently on module loading problems. [\#6244](https://github.com/VSCodeVim/Vim/issues/6244)
+- `gi` should put cursor at start of file if there was no prior insertion [\#6189](https://github.com/VSCodeVim/Vim/issues/6189)
+- Issue while search text in Russian [\#6140](https://github.com/VSCodeVim/Vim/issues/6140)
+- `nnoremap`'ing `\<S-J\>` and `\<S-K\>` from .vimrc doesn't work [\#6110](https://github.com/VSCodeVim/Vim/issues/6110)
+- When Korean keyboard layout \(Hangul\) is active, Entering a space does not work properly. [\#5900](https://github.com/VSCodeVim/Vim/issues/5900)
+
+**Closed issues:**
+
+- Failed to handle key=c. Illegal value for `line` [\#6301](https://github.com/VSCodeVim/Vim/issues/6301)
+- Enable `noImplicitAny` in tsconfig [\#6034](https://github.com/VSCodeVim/Vim/issues/6034)
+
+**Merged pull requests:**
+
+- Fix even more dependency cycles [\#6243](https://github.com/VSCodeVim/Vim/pull/6243) ([inspirer](https://github.com/inspirer))
+- Fix several dependency cycles [\#6208](https://github.com/VSCodeVim/Vim/pull/6208) ([inspirer](https://github.com/inspirer))
+- Implement previous context marks \(add to jump list on m' / m`\) [\#6174](https://github.com/VSCodeVim/Vim/pull/6174) ([jose-elias-alvarez](https://github.com/jose-elias-alvarez))
+- Add Erlang style comments [\#5970](https://github.com/VSCodeVim/Vim/pull/5970) ([maxnordlund](https://github.com/maxnordlund))
+- Potential fix for non latin chars issue [\#5951](https://github.com/VSCodeVim/Vim/pull/5951) ([berknam](https://github.com/berknam))
+- Fix multi cursor visual paste \(in part\) [\#5713](https://github.com/VSCodeVim/Vim/pull/5713) ([sql-koala](https://github.com/sql-koala))
+
+## [v1.18.9](https://github.com/vscodevim/vim/tree/v1.18.9) (2021-02-05)
+
+[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.8...v1.18.9)
+
+**Closed issues:**
+
+- Failed to handle key=i. Cannot read property 'start' of undefined [\#6042](https://github.com/VSCodeVim/Vim/issues/6042)
+
+## [v1.18.8](https://github.com/vscodevim/vim/tree/v1.18.8) (2021-02-02)
+
+[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.7...v1.18.8)
+
+**Merged pull requests:**
+
+- Polyfill OS/Process/setImmediate [\#6081](https://github.com/VSCodeVim/Vim/pull/6081) ([rebornix](https://github.com/rebornix))
+- no look behind for safari [\#6080](https://github.com/VSCodeVim/Vim/pull/6080) ([rebornix](https://github.com/rebornix))
+
+## [v1.18.7](https://github.com/vscodevim/vim/tree/v1.18.7) (2021-02-01)
+
+[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.5...v1.18.7)
 
 **Enhancements:**
 
-- :set tabstop=x works but :set ts=x does not. [\#5368](https://github.com/VSCodeVim/Vim/issues/5368)
-- Implement :set wrap :set nowrap [\#5258](https://github.com/VSCodeVim/Vim/issues/5258)
+- Implement `ZZ` and `ZQ` [\#5998](https://github.com/VSCodeVim/Vim/issues/5998)
+- Show Marks in Gutter [\#5924](https://github.com/VSCodeVim/Vim/pull/5924) ([zstix](https://github.com/zstix))
+
+**Fixed Bugs:**
+
+- Cannot read property 'warn' of undefined [\#5983](https://github.com/VSCodeVim/Vim/issues/5983)
+- H/M/L key not working in visual block mode [\#5890](https://github.com/VSCodeVim/Vim/issues/5890)
+- 1.18.0 After the update, the space bar is not input immediately by use korean IME [\#5865](https://github.com/VSCodeVim/Vim/issues/5865)
+
+**Closed issues:**
+
+- Unable to install vscode.vim extension is not compatible with current version vscode 1.51.1 [\#5883](https://github.com/VSCodeVim/Vim/issues/5883)
+- Failed to handle key=d. Cannot read property 'canBeRepeatedWithDot' of undefined [\#5879](https://github.com/VSCodeVim/Vim/issues/5879)
+- \[Why?\] Ctrl + Shift + Left Arrow \(Insert mode\) =\> Enters visual mode [\#5877](https://github.com/VSCodeVim/Vim/issues/5877)
+
+**Merged pull requests:**
+
+- off load vimrc module in web [\#6067](https://github.com/VSCodeVim/Vim/pull/6067) ([rebornix](https://github.com/rebornix))
+- Fix multicursor insert register new [\#6065](https://github.com/VSCodeVim/Vim/pull/6065) ([sql-koala](https://github.com/sql-koala))
+- Fix 'cw' behavior on whitespace [\#6033](https://github.com/VSCodeVim/Vim/pull/6033) ([edemaine](https://github.com/edemaine))
+- Remove stray console.log statements [\#6032](https://github.com/VSCodeVim/Vim/pull/6032) ([edemaine](https://github.com/edemaine))
+- Document build/test process better [\#5946](https://github.com/VSCodeVim/Vim/pull/5946) ([edemaine](https://github.com/edemaine))
+- Fix gq to preserve blank lines like Vim does \(fix \#2393\) [\#5892](https://github.com/VSCodeVim/Vim/pull/5892) ([edemaine](https://github.com/edemaine))
+- Fix broken table in README's vim-easymotion section [\#5848](https://github.com/VSCodeVim/Vim/pull/5848) ([kidonng](https://github.com/kidonng))
+
+## [v1.18.5](https://github.com/vscodevim/vim/tree/v1.18.5) (2020-12-10)
+
+[Full Changelog](https://github.com/vscodevim/vim/compare/v1.18.4...v1.18.5)
 
 **Fixed Bugs:**
 
@@ -64,14 +138,6 @@
 - Macros in File A Don't Work in File B [\#5636](https://github.com/VSCodeVim/Vim/issues/5636)
 - Reverse search for `{` stops after first `n` [\#5591](https://github.com/VSCodeVim/Vim/issues/5591)
 - \<Backspace\> while typing ex command deletes text in file [\#5584](https://github.com/VSCodeVim/Vim/issues/5584)
-- Failed to handle key=p. No multi-cursor index when calling PutCommand [\#5448](https://github.com/VSCodeVim/Vim/issues/5448)
-- Forced by user [\#5419](https://github.com/VSCodeVim/Vim/issues/5419)
-- Failed to handle key=l. Cannot read property 'searchString' of undefined [\#5351](https://github.com/VSCodeVim/Vim/issues/5351)
-- Cannot read property 'getNextSearchMatchPosition' of undefined [\#5310](https://github.com/VSCodeVim/Vim/issues/5310)
-- Bug: cursor jumps back to start of visual select after gv is used in mapping followed by paste [\#5257](https://github.com/VSCodeVim/Vim/issues/5257)
-- Snippet is not working Properly [\#5240](https://github.com/VSCodeVim/Vim/issues/5240)
-- Failed to handle key=p. v.split is not a function [\#5239](https://github.com/VSCodeVim/Vim/issues/5239)
-- Failed to handle key=\<Esc\>. Illegal argument: line must be non-negative [\#5226](https://github.com/VSCodeVim/Vim/issues/5226)
 
 **Closed issues:**
 
@@ -86,28 +152,6 @@
 - Cannot bind \<C-v\> to command "\*p \( paste from register \) [\#5592](https://github.com/VSCodeVim/Vim/issues/5592)
 - \<C-o\> in insert mode is not supported [\#5550](https://github.com/VSCodeVim/Vim/issues/5550)
 - Failed to handle key=\<right\>. getLineLength\(\) called with out-of-bounds line 26 [\#5549](https://github.com/VSCodeVim/Vim/issues/5549)
-- Vsode snippets choice bug [\#5538](https://github.com/VSCodeVim/Vim/issues/5538)
-- Keymappings aren't ported. [\#5527](https://github.com/VSCodeVim/Vim/issues/5527)
-- Broken jsx autocomplete [\#5474](https://github.com/VSCodeVim/Vim/issues/5474)
-- Glitch after paste multiple lines [\#5442](https://github.com/VSCodeVim/Vim/issues/5442)
-- 'C' in Visual Mode doesn't count as selected text for snippets with $TM_SELECTED_TEXT [\#5418](https://github.com/VSCodeVim/Vim/issues/5418)
-- Failed to handle key=\<C-o\>. Could NOT open editor for "file:///e:/hc_client_1/Assets/Scripts/Rhythm/MusicScriptEditor.cs". [\#5412](https://github.com/VSCodeVim/Vim/issues/5412)
-- Line down lagging when in visual line selection mode [\#5401](https://github.com/VSCodeVim/Vim/issues/5401)
-- Autocomplete behaving badly [\#5390](https://github.com/VSCodeVim/Vim/issues/5390)
-- Cursor stay on initial position after CTRL+arrows [\#5380](https://github.com/VSCodeVim/Vim/issues/5380)
-- alt+double-click to select multiple words with multiple cursors only selects to left of cursor [\#5366](https://github.com/VSCodeVim/Vim/issues/5366)
-- gd Goto Defination doesn't work [\#5358](https://github.com/VSCodeVim/Vim/issues/5358)
-- Forced by user [\#5347](https://github.com/VSCodeVim/Vim/issues/5347)
-- Cannot read property 'startsWith' of undefined [\#5346](https://github.com/VSCodeVim/Vim/issues/5346)
-- Vim extension make "Filtering document tree" unusable [\#5301](https://github.com/VSCodeVim/Vim/issues/5301)
-- Failed to handle key=p. v.split is not a function [\#5291](https://github.com/VSCodeVim/Vim/issues/5291)
-- Mapping "vv" to "V" stopped working in 1.15.0 and hasn't worked since [\#5278](https://github.com/VSCodeVim/Vim/issues/5278)
-- Pressing return key in vim search \(using /\) will not go to next match but trigger VSCode action [\#5274](https://github.com/VSCodeVim/Vim/issues/5274)
-- Vim-Find dialog last cursor position is off [\#5268](https://github.com/VSCodeVim/Vim/issues/5268)
-- 1.17.0 clicking causes cursor to jump when using vim hotkeys [\#5248](https://github.com/VSCodeVim/Vim/issues/5248)
-- Mapping error [\#5237](https://github.com/VSCodeVim/Vim/issues/5237)
-- Cursor location doesn't update on VSCode search / click on line [\#5221](https://github.com/VSCodeVim/Vim/issues/5221)
-- Switches to VIM mode unexpectly \(ctrl+f search & multi-cursor\) [\#5218](https://github.com/VSCodeVim/Vim/issues/5218)
 
 **Merged pull requests:**
 
@@ -120,36 +164,11 @@
 - Add Rust's INNER_LINE_DOC to reflow list [\#5597](https://github.com/VSCodeVim/Vim/pull/5597) ([lf-](https://github.com/lf-))
 - Implement normalization for 'Shift+Tab' key combo [\#5587](https://github.com/VSCodeVim/Vim/pull/5587) ([berknam](https://github.com/berknam))
 - Stop snippet insertion from going to visual mode [\#5540](https://github.com/VSCodeVim/Vim/pull/5540) ([berknam](https://github.com/berknam))
-- Fixes \#5442 - \[X\]p does not work in visual line mode [\#5504](https://github.com/VSCodeVim/Vim/pull/5504) ([rickythefox](https://github.com/rickythefox))
-- Stop user forced stop remap from throwing error [\#5425](https://github.com/VSCodeVim/Vim/pull/5425) ([berknam](https://github.com/berknam))
-- Fix Alt+DoubleClick wrong selection after the first one [\#5367](https://github.com/VSCodeVim/Vim/pull/5367) ([berknam](https://github.com/berknam))
-- Fix gulpfile updatePath on windows [\#5293](https://github.com/VSCodeVim/Vim/pull/5293) ([berknam](https://github.com/berknam))
-- Fix remap bug with '\<' and special keys remaps [\#5287](https://github.com/VSCodeVim/Vim/pull/5287) ([berknam](https://github.com/berknam))
-- Fix bug with remap in insert mode [\#5280](https://github.com/VSCodeVim/Vim/pull/5280) ([berknam](https://github.com/berknam))
-- Fix remaps when entering chinese input mode \(composition state\) [\#5271](https://github.com/VSCodeVim/Vim/pull/5271) ([berknam](https://github.com/berknam))
-- ExecuteOperator doesn't need to change selections [\#5259](https://github.com/VSCodeVim/Vim/pull/5259) ([berknam](https://github.com/berknam))
-- Fix multicursor selections visual mode [\#5250](https://github.com/VSCodeVim/Vim/pull/5250) ([berknam](https://github.com/berknam))
 
 ## [v1.17.1](https://github.com/vscodevim/vim/tree/v1.17.1) (2020-09-25)
 
 [Full Changelog](https://github.com/vscodevim/vim/compare/v1.17.0...v1.17.1)
 
-**Fixed Bugs:**
-
-- "No .vimrc found. Please set `vim.vimrc.path.`" reported with v1.17.0 [\#5220](https://github.com/VSCodeVim/Vim/issues/5220)
-
-**Closed issues:**
-
-- .vim [\#5247](https://github.com/VSCodeVim/Vim/issues/5247)
-- Failed to handle key=p. v.split is not a function [\#5244](https://github.com/VSCodeVim/Vim/issues/5244)
-- Best way to implement "vim-cutlass" behavior? [\#5242](https://github.com/VSCodeVim/Vim/issues/5242)
-- in 1.17.0, unable to find imselect.exe [\#5229](https://github.com/VSCodeVim/Vim/issues/5229)
-- Mouse clicked position isn't registered after navigating only with `hjkl` [\#5212](https://github.com/VSCodeVim/Vim/issues/5212)
-
-**Merged pull requests:**
-
-- make getConfiguration use the document languageId \(fixes \#4503\) [\#5245](https://github.com/VSCodeVim/Vim/pull/5245) ([dalev](https://github.com/dalev))
-
 ## [v1.17.0](https://github.com/vscodevim/vim/tree/v1.17.0) (2020-09-22)
 
 [Full Changelog](https://github.com/vscodevim/vim/compare/beta...v1.17.0)