Enforce safer use of vscode.WorkspaceConfiguration

Author: J-Fields

src/actions/commands/actions.ts

@@ -534,7 +534,9 @@ abstract class CommandScrollAndMoveCursor extends BaseCommand {
 
   public async exec(position: Position, vimState: VimState): Promise<void> {
     const { visibleRanges } = vimState.editor;
-    const smoothScrolling = configuration.getConfiguration('editor').smoothScrolling;
+    const smoothScrolling = configuration
+      .getConfiguration('editor')
+      .get<boolean>('smoothScrolling', false);
     const moveLines = (vimState.actionCount || 1) * this.getNumLines(vimState);
 
     let scrollLines = moveLines;

src/configuration/configuration.ts

@@ -20,6 +20,11 @@ import {
 import * as packagejson from '../../package.json';
 import { SUPPORT_VIMRC } from 'platform/constants';
 
+// https://stackovrflow.com/questions/51465182/how-to-remove-index-signature-using-mapped-types/51956054#51956054
+type RemoveIndex<T> = {
+  [P in keyof T as string extends P ? never : number extends P ? never : P]: T[P];
+};
+
 export const extensionVersion = packagejson.version;
 
 /**
@@ -182,7 +187,7 @@ class Configuration implements IConfiguration {
     return validatorResults;
   }
 
-  getConfiguration(section: string = ''): vscode.WorkspaceConfiguration {
+  getConfiguration(section: string = ''): RemoveIndex<vscode.WorkspaceConfiguration> {
     const document = vscode.window.activeTextEditor?.document;
     const resource = document ? { uri: document.uri, languageId: document.languageId } : undefined;
     return vscode.workspace.getConfiguration(section, resource);