Tighten up eslintrc slightly

Author: J-Fields

.eslintrc.js

@@ -54,8 +54,12 @@ module.exports = {
     '@typescript-eslint/no-implied-eval': 'error',
     '@typescript-eslint/no-loss-of-precision': 'error',
     '@typescript-eslint/no-misused-new': 'error',
-    // ignore the rule to conform to current code
-    '@typescript-eslint/no-misused-promises': 'off',
+    '@typescript-eslint/no-misused-promises': [
+      'error',
+      {
+        checksVoidReturn: false, // TODO
+      },
+    ],
     '@typescript-eslint/no-namespace': 'error',
     '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
     '@typescript-eslint/parameter-properties': 'error',
@@ -73,8 +77,6 @@ module.exports = {
     '@typescript-eslint/no-unsafe-assignment': 'error',
     '@typescript-eslint/no-unsafe-call': 'error',
     '@typescript-eslint/no-unsafe-declaration-merging': 'error',
-    // ignore the rule to conform to current code
-    '@typescript-eslint/no-unsafe-enum-comparison': 'off',
     '@typescript-eslint/no-unsafe-member-access': 'error',
     '@typescript-eslint/no-unsafe-return': 'error',
     '@typescript-eslint/no-unused-expressions': 'error',

src/actions/commands/actions.ts

@@ -685,7 +685,9 @@ export class CommandShowSearchHistory extends BaseCommand {
 
       if (!nextMatch) {
         throw VimError.fromCode(
-          this.direction > 0 ? ErrorCode.SearchHitBottom : ErrorCode.SearchHitTop,
+          this.direction === SearchDirection.Forward
+            ? ErrorCode.SearchHitBottom
+            : ErrorCode.SearchHitTop,
           searchState.searchString,
         );
       }

src/common/number/numericString.ts

@@ -162,7 +162,7 @@ export class NumericString {
 
   public toString(): string {
     // For decreased octal and hexadecimal
-    if (this.radix !== 10) {
+    if (this.radix !== NumericStringRadix.Dec) {
       const max = 0xffffffff;
       while (this.value < 0) {
         this.value = max + this.value + 1;
@@ -176,7 +176,7 @@ export class NumericString {
       num = num.toUpperCase();
     }
     // numLength of decimal *should not* be preserved.
-    if (this.radix !== 10) {
+    if (this.radix !== NumericStringRadix.Dec) {
       const diff = this.numLength - num.length;
       if (diff > 0) {
         // Preserve num length if it's narrower.

src/error.ts

@@ -167,10 +167,10 @@ export const ErrorMessage: IErrorMessage = {
 };
 
 export class VimError extends Error {
-  public readonly code: number;
+  public readonly code: ErrorCode;
   public override readonly message: string;
 
-  private constructor(code: number, message: string) {
+  private constructor(code: ErrorCode, message: string) {
     super();
     this.code = code;
     this.message = message;

src/mode/modeHandler.ts

@@ -459,6 +459,7 @@ export class ModeHandler implements vscode.Disposable, IModeHandler {
     Logger.debug(`Handling key: ${printableKey}`);
 
     if (
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
       (key === SpecialKeys.TimeoutFinished ||
         this.vimState.recordedState.bufferedKeys.length > 0) &&
       this.vimState.recordedState.bufferedKeysTimeoutObj
@@ -537,6 +538,7 @@ export class ModeHandler implements vscode.Disposable, IModeHandler {
       this.vimState.recordedState.allowPotentialRemapOnFirstKey = true;
 
       if (!handledAsRemap) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
         if (key === SpecialKeys.TimeoutFinished) {
           // Remove the <TimeoutFinished> key and get the key before that. If the <TimeoutFinished>
           // key was the last key, then 'key' will be undefined and won't be sent to handle action.

test/testUtils.ts

@@ -219,7 +219,7 @@ export async function replaceContent(
 ): Promise<void> {
   const edit = new vscode.WorkspaceEdit();
   edit.replace(document.uri, TextEditor.getDocumentRange(document), content);
-  const isApplied = vscode.workspace.applyEdit(edit);
+  const isApplied = await vscode.workspace.applyEdit(edit);
 
   if (!isApplied) throw new Error(`Failed to replace content`);
 }