Skip to content

Commit b1edac7

Browse files
DemmoniusDemmonius
committed
Fixed if no alias is provided
1 parent 9aa3d7c commit b1edac7

File tree

2 files changed

+61
-57
lines changed

2 files changed

+61
-57
lines changed

‎lib/vercel.js

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -71,36 +71,38 @@ const create_aliases = (deploymentUrl, customDeploymentFile, failIfAliasNotLinke
7171
core.debug(`Found custom config file: ${vercelConfigFile}`);
7272
core.debug(`Found real path: ${vercelConfigFile}`);
7373
const vercelConfig = JSON.parse(fs_1.default.readFileSync(vercelConfigFile, 'utf8'));
74-
const { id, ownerId } = (yield node_fetch_1.default(`https://api.vercel.com/v11/now/deployments/get?url=${deploymentUrl.replace("https://", "")}`, {
75-
headers: {
76-
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`
77-
},
78-
method: 'GET'
79-
}).then(data => data.json()));
80-
let aliasCreationPromises = [];
81-
for (const alias of vercelConfig.alias) {
82-
console.log(`Creating alias ${alias}`);
83-
aliasCreationPromises.push(node_fetch_1.default(`https://api.vercel.com/v2/now/deployments/${id}/aliases?teamId=${ownerId}`, {
74+
if (vercelConfig.alias) {
75+
const { id, ownerId } = (yield node_fetch_1.default(`https://api.vercel.com/v11/now/deployments/get?url=${deploymentUrl.replace("https://", "")}`, {
8476
headers: {
85-
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`,
86-
"Content-Type": "application/json"
77+
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`
8778
},
88-
body: JSON.stringify({
89-
alias: alias
90-
}),
91-
method: 'POST'
79+
method: 'GET'
9280
}).then(data => data.json()));
93-
}
94-
core.debug(`Resolving alias promises`);
95-
const aliasesResponse = yield Promise.all(aliasCreationPromises);
96-
console.log(`Alias creation response: ${aliasesResponse}`);
97-
if (failIfAliasNotLinked && aliasesResponse) {
98-
const failedAliases = aliasesResponse.filter((response) => response.error).map((response) => response.error);
99-
core.setFailed(`Got following errors: ${JSON.stringify(failedAliases)}`);
100-
return;
101-
}
102-
for (const alias of aliasesResponse.filter(response => !response.error)) {
103-
console.log(`Created alias ${alias}`);
81+
let aliasCreationPromises = [];
82+
for (const alias of vercelConfig.alias) {
83+
console.log(`Creating alias ${alias}`);
84+
aliasCreationPromises.push(node_fetch_1.default(`https://api.vercel.com/v2/now/deployments/${id}/aliases?teamId=${ownerId}`, {
85+
headers: {
86+
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`,
87+
"Content-Type": "application/json"
88+
},
89+
body: JSON.stringify({
90+
alias: alias
91+
}),
92+
method: 'POST'
93+
}).then(data => data.json()));
94+
}
95+
core.debug(`Resolving alias promises`);
96+
const aliasesResponse = yield Promise.all(aliasCreationPromises);
97+
console.log(`Alias creation response: ${aliasesResponse}`);
98+
if (failIfAliasNotLinked && aliasesResponse) {
99+
const failedAliases = aliasesResponse.filter((response) => response.error).map((response) => response.error);
100+
core.setFailed(`Got following errors: ${JSON.stringify(failedAliases)}`);
101+
return;
102+
}
103+
for (const alias of aliasesResponse.filter(response => !response.error)) {
104+
console.log(`Created alias ${alias}`);
105+
}
104106
}
105107
}
106108
else {

‎src/vercel.ts

Lines changed: 32 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -47,39 +47,41 @@ const create_aliases = async (deploymentUrl: string, customDeploymentFile: strin
4747
core.debug(`Found custom config file: ${vercelConfigFile}`);
4848
core.debug(`Found real path: ${vercelConfigFile}`);
4949
const vercelConfig: VercelConfig = JSON.parse(fs.readFileSync(vercelConfigFile, 'utf8'));
50-
const {
51-
id,
52-
ownerId
53-
} = (await fetch(`https://api.vercel.com/v11/now/deployments/get?url=${deploymentUrl.replace("https://", "")}`, {
54-
headers: {
55-
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`
56-
},
57-
method: 'GET'
58-
}).then(data => data.json()));
59-
let aliasCreationPromises: Promise<VercelAliasResponse>[] = [];
60-
for (const alias of vercelConfig.alias) {
61-
console.log(`Creating alias ${alias}`);
62-
aliasCreationPromises.push(fetch(`https://api.vercel.com/v2/now/deployments/${id}/aliases?teamId=${ownerId}`, {
50+
if (vercelConfig.alias) {
51+
const {
52+
id,
53+
ownerId
54+
} = (await fetch(`https://api.vercel.com/v11/now/deployments/get?url=${deploymentUrl.replace("https://", "")}`, {
6355
headers: {
64-
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`,
65-
"Content-Type": "application/json"
56+
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`
6657
},
67-
body: JSON.stringify({
68-
alias: alias
69-
}),
70-
method: 'POST'
58+
method: 'GET'
7159
}).then(data => data.json()));
72-
}
73-
core.debug(`Resolving alias promises`);
74-
const aliasesResponse: VercelAliasResponse[] = await Promise.all<VercelAliasResponse>(aliasCreationPromises);
75-
console.log(`Alias creation response: ${aliasesResponse}`);
76-
if (failIfAliasNotLinked && aliasesResponse) {
77-
const failedAliases: (VercelAliasResponseError | undefined)[] = aliasesResponse.filter((response: VercelAliasResponse) => response.error).map((response) => response.error);
78-
core.setFailed(`Got following errors: ${JSON.stringify(failedAliases)}`)
79-
return;
80-
}
81-
for (const alias of aliasesResponse.filter(response => !response.error)) {
82-
console.log(`Created alias ${alias}`);
60+
let aliasCreationPromises: Promise<VercelAliasResponse>[] = [];
61+
for (const alias of vercelConfig.alias) {
62+
console.log(`Creating alias ${alias}`);
63+
aliasCreationPromises.push(fetch(`https://api.vercel.com/v2/now/deployments/${id}/aliases?teamId=${ownerId}`, {
64+
headers: {
65+
Authorization: `Bearer ${process.env.VERCEL_TOKEN}`,
66+
"Content-Type": "application/json"
67+
},
68+
body: JSON.stringify({
69+
alias: alias
70+
}),
71+
method: 'POST'
72+
}).then(data => data.json()));
73+
}
74+
core.debug(`Resolving alias promises`);
75+
const aliasesResponse: VercelAliasResponse[] = await Promise.all<VercelAliasResponse>(aliasCreationPromises);
76+
console.log(`Alias creation response: ${aliasesResponse}`);
77+
if (failIfAliasNotLinked && aliasesResponse) {
78+
const failedAliases: (VercelAliasResponseError | undefined)[] = aliasesResponse.filter((response: VercelAliasResponse) => response.error).map((response) => response.error);
79+
core.setFailed(`Got following errors: ${JSON.stringify(failedAliases)}`)
80+
return;
81+
}
82+
for (const alias of aliasesResponse.filter(response => !response.error)) {
83+
console.log(`Created alias ${alias}`);
84+
}
8385
}
8486
} else {
8587
core.setFailed(`Cannot access to vercel config file "${vercelConfigFile}". Deployment succeeded but no aliases has been created.`)

0 commit comments

Comments
 (0)