Skip to content

Commit 88b3a07

Browse files
ci: [NGOv2.X] Fixing WebGL timeout and reenabling macOS job (#3507)
This PR focuses on investigating often timeouts of WebGL job happening on Ubuntu platform (note that there are no timeouts on Windows) and also on re-enabling macOS job that was disabled due to error "_Light baking could not be started because no valid OpenCL device could be found_" and is tracked in MTT-11726 When it comes to the error on macOS, the build was failing due to a light baking error in different scenes with message "_no valid OpenCL device could be found._" This common issue on Apple Silicon VMs, where OpenCL support is often missing for the GPU lightmapper, can be resolved by disabling "Baked Global Illumination" for the scene. Since those scenes in testproject do not really need baked lighting and I didn't spot any difference with this option disabled I went forward with disabling it for testproject scenes and this resolves macOS issue. **Note** that most changes are related to testproject updates that happened automatically when I changed the mentioned lighting setting For the Ubuntu timeout problem I restored image version to v4 instead of pointing to specific version since the issue that caused us to do so was resolved. I also increased flavor to xlarge (from large) because it seems that with more resources the process is not hanging anymore (will run test 5 times to confirm) ## Backport #3511
1 parent 098e68e commit 88b3a07

17 files changed

+1614
-287
lines changed

.yamato/_run-all.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,9 @@ run_all_webgl_builds:
110110
dependencies:
111111
{% for project in projects.default -%}
112112
{% for platform in test_platforms.desktop -%}
113-
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
114113
{% for editor in validation_editors.all -%}
115114
- .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}
116115
{% endfor -%}
117-
{% endif -%}
118116
{% endfor -%}
119117
{% endfor -%}
120118

@@ -125,11 +123,9 @@ run_all_webgl_builds_trunk:
125123
dependencies:
126124
{% for project in projects.default -%}
127125
{% for platform in test_platforms.desktop -%}
128-
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
129126
{% for editor in validation_editors.default -%}
130127
- .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}
131128
{% endfor -%}
132-
{% endif -%}
133129
{% endfor -%}
134130
{% endfor -%}
135131

@@ -139,9 +135,7 @@ run_all_webgl_builds_6000:
139135
dependencies:
140136
{% for project in projects.default -%}
141137
{% for platform in test_platforms.desktop -%}
142-
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
143138
- .yamato/webgl-build.yml#webgl_build_{{ project.name }}_{{ platform.name }}_6000.0
144-
{% endif -%}
145139
{% endfor -%}
146140
{% endfor -%}
147141

.yamato/project.metafile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ test_platforms:
3737
default:
3838
- name: ubuntu
3939
type: Unity::VM
40-
image: package-ci/ubuntu-22.04:v4.71.0
40+
image: package-ci/ubuntu-22.04:v4
4141
flavor: b1.large
4242
standalone: StandaloneLinux64
4343
desktop:
4444
- name: ubuntu
4545
type: Unity::VM
46-
image: package-ci/ubuntu-22.04:v4.71.0
46+
image: package-ci/ubuntu-22.04:v4
4747
flavor: b1.large
4848
standalone: StandaloneLinux64
4949
model: rtx2080

.yamato/webgl-build.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,13 @@
2626

2727
{% for project in projects.default -%}
2828
{% for platform in test_platforms.desktop -%}
29-
{% if platform.name != "mac" -%} # There is an error about "Light baking could not be started because no valid OpenCL device could be found". Tracked in MTT-11726
3029
{% for editor in validation_editors.all -%}
3130
webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}:
3231
name: WebGl Build - {{ project.name }} [{{ platform.name }}, {{ editor }}, il2cpp]
3332
agent:
3433
type: {{ platform.type }}
3534
image: {{ platform.image }}
36-
flavor: {{ platform.flavor }}
35+
flavor: b1.xlarge # We use b1.xlarge for WebGL builds since it requires more resources (otherwise it hangs and timeouts) especially on Ubuntu platform
3736
{% if platform.model %}
3837
model: {{ platform.model }} # This is set only in platforms where we want non-default model to use (more information in project.metafile)
3938
{% endif %}
@@ -53,6 +52,5 @@ webgl_build_{{ project.name }}_{{ platform.name }}_{{ editor }}:
5352
- "artifacts/**/*"
5453
- "build/players/**/*"
5554
{% endfor -%}
56-
{% endif -%}
5755
{% endfor -%}
5856
{% endfor -%}

0 commit comments

Comments
 (0)