Skip to content

Commit 98f9eea

Browse files
Update tests
1 parent bec05ee commit 98f9eea

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

test/test_server.py

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from unittest import mock
22
from ros_tcp_endpoint import TcpServer
33
from ros_tcp_endpoint.server import SysCommands
4-
from ros_tcp_endpoint.server import resolve_message_name
54
import importlib
65
import rospy
76
import sys
@@ -43,9 +42,7 @@ def test_unity_service_resolve_message_name_failure():
4342

4443
@mock.patch.object(rospy, "Service")
4544
@mock.patch.object(
46-
ros_tcp_endpoint.server,
47-
"resolve_message_name",
48-
return_value="unity_interfaces.msg/RosUnitySrvMessage",
45+
SysCommands, "resolve_message_name", return_value="unity_interfaces.msg/RosUnitySrvMessage"
4946
)
5047
def test_unity_service_resolve_news_service(mock_resolve_message, mock_ros_service):
5148
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
@@ -58,9 +55,7 @@ def test_unity_service_resolve_news_service(mock_resolve_message, mock_ros_servi
5855

5956
@mock.patch.object(rospy, "Service")
6057
@mock.patch.object(
61-
ros_tcp_endpoint.server,
62-
"resolve_message_name",
63-
return_value="unity_interfaces.msg/RosUnitySrvMessage",
58+
SysCommands, "resolve_message_name", return_value="unity_interfaces.msg/RosUnitySrvMessage"
6459
)
6560
def test_unity_service_resolve_existing_service(mock_resolve_message, mock_ros_service):
6661
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
@@ -74,8 +69,9 @@ def test_unity_service_resolve_existing_service(mock_resolve_message, mock_ros_s
7469
@mock.patch.object(sys, "modules", return_value="unity_interfaces.msg")
7570
@mock.patch.object(importlib, "import_module")
7671
def test_resolve_message_name(mock_import_module, mock_sys_modules):
72+
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
7773
msg_name = "unity_interfaces.msg/UnityColor.msg"
78-
result = resolve_message_name(msg_name)
74+
result = SysCommands(server).resolve_message_name(msg_name)
7975
mock_import_module.assert_called_once
8076
mock_sys_modules.assert_called_once
8177
assert result is not None
@@ -113,9 +109,7 @@ def test_publish_empty_message_should_return_none():
113109

114110

115111
@mock.patch.object(rospy, "Subscriber")
116-
@mock.patch.object(
117-
ros_tcp_endpoint.server, "resolve_message_name", return_value="unity_interfaces.msg/Pos"
118-
)
112+
@mock.patch.object(SysCommands, "resolve_message_name", return_value="unity_interfaces.msg/Pos")
119113
def test_subscribe_to_new_topic(mock_resolve_msg, mock_ros_subscriber):
120114
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
121115
result = SysCommands(server).subscribe("object_pos_topic", "pos")
@@ -124,9 +118,7 @@ def test_subscribe_to_new_topic(mock_resolve_msg, mock_ros_subscriber):
124118

125119

126120
@mock.patch.object(rospy, "Subscriber")
127-
@mock.patch.object(
128-
ros_tcp_endpoint.server, "resolve_message_name", return_value="unity_interfaces.msg/Pos"
129-
)
121+
@mock.patch.object(SysCommands, "resolve_message_name", return_value="unity_interfaces.msg/Pos")
130122
def test_subscribe_to_existing_topic(mock_resolve_msg, mock_ros_subscriber):
131123
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
132124
server.subscribers = {"object_pos_topic": mock.Mock()}
@@ -150,7 +142,7 @@ def test_subscribe_to_empty_message_should_return_none():
150142

151143

152144
@mock.patch.object(rospy, "ServiceProxy")
153-
@mock.patch.object(ros_tcp_endpoint.server, "resolve_message_name")
145+
@mock.patch.object(SysCommands, "resolve_message_name")
154146
def test_ros_service_new_topic(mock_resolve_msg, mock_ros_service):
155147
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
156148
result = SysCommands(server).ros_service("object_pos_topic", "pos")
@@ -159,7 +151,7 @@ def test_ros_service_new_topic(mock_resolve_msg, mock_ros_service):
159151

160152

161153
@mock.patch.object(rospy, "ServiceProxy")
162-
@mock.patch.object(ros_tcp_endpoint.server, "resolve_message_name")
154+
@mock.patch.object(SysCommands, "resolve_message_name")
163155
def test_ros_service_existing_topic(mock_resolve_msg, mock_ros_service):
164156
server = TcpServer(node_name="test-tcp-server", tcp_ip="127.0.0.1", tcp_port=10000)
165157
server.ros_services = {"object_pos_topic": mock.Mock()}

0 commit comments

Comments
 (0)