From 9f4251319b43e61d2d73ae078786cae3d7bffb6d Mon Sep 17 00:00:00 2001 From: Siyu Jiang <91580504+jsy1218@users.noreply.github.com> Date: Wed, 22 May 2024 13:57:59 -0700 Subject: [PATCH 1/4] change router-sdk version as well --- lib/config/ChainConfigManager.ts | 4 +- package.json | 8 +-- test/integ/quote-classic.test.ts | 11 +++-- yarn.lock | 84 ++++++++++++++++++++------------ 4 files changed, 66 insertions(+), 41 deletions(-) diff --git a/lib/config/ChainConfigManager.ts b/lib/config/ChainConfigManager.ts index 304f9de8..55e34e55 100644 --- a/lib/config/ChainConfigManager.ts +++ b/lib/config/ChainConfigManager.ts @@ -169,7 +169,9 @@ export abstract class ChainConfigManager { alarmEnabled: false, }, [ChainId.ZORA]: { - routingTypes: {}, + routingTypes: { + [RoutingType.CLASSIC]: {}, + }, alarmEnabled: false, }, [ChainId.ZORA_SEPOLIA]: { diff --git a/package.json b/package.json index ef360571..9b231d0b 100644 --- a/package.json +++ b/package.json @@ -69,11 +69,11 @@ "@typechain/ethers-v5": "^7.0.1", "@uniswap/default-token-list": "^11.7.0", "@uniswap/permit2-sdk": "^1.2.0", - "@uniswap/router-sdk": "^1.9.0", - "@uniswap/sdk-core": "^4.2.0", - "@uniswap/smart-order-router": "^3.26.0", + "@uniswap/router-sdk": "^1.9.2", + "@uniswap/sdk-core": "^5.0.0", + "@uniswap/smart-order-router": "^3.32.0", "@uniswap/uniswapx-sdk": "2.1.0-beta.4", - "@uniswap/universal-router-sdk": "^1.9.0", + "@uniswap/universal-router-sdk": "^2.1.0", "aws-cdk-lib": "2.85.0", "aws-embedded-metrics": "^4.1.0", "axios": "^1.2.1", diff --git a/test/integ/quote-classic.test.ts b/test/integ/quote-classic.test.ts index bc87710c..6946f978 100644 --- a/test/integ/quote-classic.test.ts +++ b/test/integ/quote-classic.test.ts @@ -8,6 +8,7 @@ import { ID_TO_NETWORK_NAME, NATIVE_CURRENCY, USDB_BLAST, + USDC_ZORA, } from '@uniswap/smart-order-router'; import { fail } from 'assert'; import { AxiosResponse } from 'axios'; @@ -451,7 +452,7 @@ describe('quote', function () { [ChainId.ARBITRUM_SEPOLIA]: null, [ChainId.BASE_GOERLI]: USDC_ON(ChainId.BASE_GOERLI), [ChainId.BASE]: USDC_ON(ChainId.BASE), - [ChainId.ZORA]: null, + [ChainId.ZORA]: USDC_ZORA, [ChainId.ZORA_SEPOLIA]: null, [ChainId.ROOTSTOCK]: null, [ChainId.BLAST]: USDB_BLAST, @@ -477,7 +478,7 @@ describe('quote', function () { [ChainId.ARBITRUM_SEPOLIA]: null, [ChainId.BASE_GOERLI]: WNATIVE_ON(ChainId.BASE_GOERLI), [ChainId.BASE]: WNATIVE_ON(ChainId.BASE), - [ChainId.ZORA]: null, + [ChainId.ZORA]: WNATIVE_ON(ChainId.ZORA), [ChainId.ZORA_SEPOLIA]: null, [ChainId.ROOTSTOCK]: null, [ChainId.BLAST]: WNATIVE_ON(ChainId.BLAST), @@ -497,8 +498,7 @@ describe('quote', function () { c != ChainId.OPTIMISM_SEPOLIA && c !== ChainId.BASE && c !== ChainId.BASE_GOERLI && - // We will follow up supporting ZORA and ROOTSTOCK - c !== ChainId.ZORA && + // We will follow up supporting ROOTSTOCK c !== ChainId.ZORA_SEPOLIA && c !== ChainId.ROOTSTOCK )) { @@ -584,8 +584,9 @@ describe('quote', function () { }); const native = NATIVE_CURRENCY[chain]; it(`${native} -> erc20`, async () => { - if (chain === ChainId.BLAST) { + if (chain === ChainId.BLAST || chain === ChainId.ZORA) { // Blast doesn't have DAI or USDC yet + // Zora doesn't have DAI return; } diff --git a/yarn.lock b/yarn.lock index 2c3c059d..a4b39136 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2089,6 +2089,17 @@ "@uniswap/v2-sdk" "^4.3.0" "@uniswap/v3-sdk" "^3.11.0" +"@uniswap/router-sdk@^1.9.2": + version "1.9.2" + resolved "https://registry.yarnpkg.com/@uniswap/router-sdk/-/router-sdk-1.9.2.tgz#cc2411f0849467c2bd71ce34cdca9db2a584367d" + integrity sha512-J63Of3HRpV0s3ZtEnhGlyvbBuZFfjK7NtnMwflzFMKzfdm+75APHYqnvHAnVARKuL/hMYHF4hni0o84bHem2Ng== + dependencies: + "@ethersproject/abi" "^5.5.0" + "@uniswap/sdk-core" "^5.0.0" + "@uniswap/swap-router-contracts" "^1.3.0" + "@uniswap/v2-sdk" "^4.3.2" + "@uniswap/v3-sdk" "^3.11.2" + "@uniswap/sdk-core@^4.2.0": version "4.2.0" resolved "https://registry.yarnpkg.com/@uniswap/sdk-core/-/sdk-core-4.2.0.tgz#9930f133baec9c1118d891ebf8fcba7f7efc153d" @@ -2113,10 +2124,10 @@ tiny-invariant "^1.1.0" toformat "^2.0.0" -"@uniswap/smart-order-router@^3.26.0": - version "3.26.0" - resolved "https://registry.yarnpkg.com/@uniswap/smart-order-router/-/smart-order-router-3.26.0.tgz#b3b172adb6b6f5f2865f6dd8ec7dddebf7a701a5" - integrity sha512-0xoMyirXAjCwIYDA423O8HwahwxLX+0v2OaayDuRWeYKX+rFsKKGXRTykG9CJx0vHSpuI2fqBIQQ38r/+Ww3cA== +"@uniswap/smart-order-router@^3.32.0": + version "3.32.0" + resolved "https://registry.yarnpkg.com/@uniswap/smart-order-router/-/smart-order-router-3.32.0.tgz#83d70b10d68744680d570458209f14397b2585c8" + integrity sha512-M6JK/D5zj67LwPHXoREDirL0wcIIvAB6tVa/UvNbKBqyO+Mc/0wFo1APzSE3Z+WYvA0TMZypGFhV9KGYN/ukVg== dependencies: "@eth-optimism/sdk" "^3.2.2" "@types/brotli" "^1.3.4" @@ -2127,7 +2138,7 @@ "@uniswap/swap-router-contracts" "^1.3.1" "@uniswap/token-lists" "^1.0.0-beta.31" "@uniswap/universal-router" "^1.6.0" - "@uniswap/universal-router-sdk" "^1.8.1" + "@uniswap/universal-router-sdk" "^2.1.0" "@uniswap/v2-sdk" "^4.3.0" "@uniswap/v3-sdk" "^3.11.0" async-retry "^1.3.1" @@ -2144,7 +2155,7 @@ node-cache "^5.1.2" stats-lite "^2.2.0" -"@uniswap/swap-router-contracts@^1.1.0", "@uniswap/swap-router-contracts@^1.3.1": +"@uniswap/swap-router-contracts@^1.1.0", "@uniswap/swap-router-contracts@^1.3.0", "@uniswap/swap-router-contracts@^1.3.1": version "1.3.1" resolved "https://registry.yarnpkg.com/@uniswap/swap-router-contracts/-/swap-router-contracts-1.3.1.tgz#0ebbb93eb578625618ed9489872de381f9c66fb4" integrity sha512-mh/YNbwKb7Mut96VuEtL+Z5bRe0xVIbjjiryn+iMMrK2sFKhR4duk/86mEz0UO5gSx4pQIw9G5276P5heY/7Rg== @@ -2184,33 +2195,19 @@ "@uniswap/sdk-core" "^5.0.0" ethers "^5.7.0" -"@uniswap/universal-router-sdk@^1.8.1": - version "1.8.1" - resolved "https://registry.yarnpkg.com/@uniswap/universal-router-sdk/-/universal-router-sdk-1.8.1.tgz#1d94c3142aed697d3a06c0542ae8cc9404640296" - integrity sha512-oA4JFLD1JmfJn5AnPcvgOmLIqZnsUpDYSShYCt8CaA3AzBzKmPTz9xpGdQwVHIH8rJnYu6mPTqRg5GwLobeMGA== +"@uniswap/universal-router-sdk@^2.1.0": + version "2.1.0" + resolved "https://registry.yarnpkg.com/@uniswap/universal-router-sdk/-/universal-router-sdk-2.1.0.tgz#7b4e48af92a6162973d3503bcd6ccf4b52dcba4a" + integrity sha512-nLIIr0bZ6AfvwuYC97rM10tyEfqDIdujtG+Ahwqhv1EMWayh6abbqPUwvUQvk6Px4LOyuKtlciryW/MJMusn4w== dependencies: - "@uniswap/permit2-sdk" "^1.2.0" - "@uniswap/router-sdk" "^1.9.0" - "@uniswap/sdk-core" "^4.2.0" + "@uniswap/permit2-sdk" "^1.2.1" + "@uniswap/router-sdk" "^1.9.2" + "@uniswap/sdk-core" "^5.0.0" "@uniswap/universal-router" "1.6.0" - "@uniswap/v2-sdk" "^4.2.0" - "@uniswap/v3-sdk" "^3.11.0" + "@uniswap/v2-sdk" "^4.3.2" + "@uniswap/v3-sdk" "^3.11.2" bignumber.js "^9.0.2" - ethers "^5.3.1" - -"@uniswap/universal-router-sdk@^1.9.0": - version "1.9.0" - resolved "https://registry.yarnpkg.com/@uniswap/universal-router-sdk/-/universal-router-sdk-1.9.0.tgz#7e0c38dc6dc015bcb3b74f34df820af0aef90f41" - integrity sha512-B6iEczP2WdMsq/aVIdQfvHWWLJyhaUD7enfxO6koxaH3huYOqUWRAzmZLl026fRK7R7P+tVFcA6AqImWLG6tYQ== - dependencies: - "@uniswap/permit2-sdk" "^1.2.0" - "@uniswap/router-sdk" "^1.9.0" - "@uniswap/sdk-core" "^4.2.0" - "@uniswap/universal-router" "1.6.0" - "@uniswap/v2-sdk" "^4.3.0" - "@uniswap/v3-sdk" "^3.11.0" - bignumber.js "^9.0.2" - ethers "^5.3.1" + ethers "^5.7.0" "@uniswap/universal-router@1.6.0", "@uniswap/universal-router@^1.6.0": version "1.6.0" @@ -2226,7 +2223,7 @@ resolved "https://registry.npmjs.org/@uniswap/v2-core/-/v2-core-1.0.1.tgz" integrity sha512-MtybtkUPSyysqLY2U210NBDeCHX+ltHt3oADGdjqoThZaFRDKwM6k1Nb3F0A3hk5hwuQvytFWhrWHOEq6nVJ8Q== -"@uniswap/v2-sdk@^4.2.0", "@uniswap/v2-sdk@^4.3.0": +"@uniswap/v2-sdk@^4.3.0": version "4.3.0" resolved "https://registry.yarnpkg.com/@uniswap/v2-sdk/-/v2-sdk-4.3.0.tgz#621dcf4ea236448a0a49cd901932b3a466c8ae02" integrity sha512-FUKkgo/1TQc/HuWWgsoy1FIcsLkKwm3Nnor88yfn2NH8ER5RK/wDF9UzDDilYh3yyf2mAnaY89CKFhcIl+lbBQ== @@ -2237,6 +2234,17 @@ tiny-invariant "^1.1.0" tiny-warning "^1.0.3" +"@uniswap/v2-sdk@^4.3.2": + version "4.3.2" + resolved "https://registry.yarnpkg.com/@uniswap/v2-sdk/-/v2-sdk-4.3.2.tgz#d8eacdb2ddfeca849ee1cb05377521c4ba0d1542" + integrity sha512-yNxfQZuzmQ2xqiKutzyzzoXuiuwFrHWba6GG9gT8JeJ4NT5sTJOeLY1FEdEMVsJQwXfMc+goG/srNBRZXVRtSA== + dependencies: + "@ethersproject/address" "^5.0.2" + "@ethersproject/solidity" "^5.0.9" + "@uniswap/sdk-core" "^5.0.0" + tiny-invariant "^1.1.0" + tiny-warning "^1.0.3" + "@uniswap/v3-core@1.0.0": version "1.0.0" resolved "https://registry.npmjs.org/@uniswap/v3-core/-/v3-core-1.0.0.tgz" @@ -2295,6 +2303,20 @@ tiny-invariant "^1.1.0" tiny-warning "^1.0.3" +"@uniswap/v3-sdk@^3.11.2": + version "3.11.2" + resolved "https://registry.yarnpkg.com/@uniswap/v3-sdk/-/v3-sdk-3.11.2.tgz#cda523307549548b6b53a1d5d1badeff1627a88b" + integrity sha512-TktyuMHVqlhtUxXK3cUaijlvlqiyWfpEYgzd2JD1EcvsVB55zLmtRKb/1fbtLbjRqOapcFsVihD5pVW9nyFlTg== + dependencies: + "@ethersproject/abi" "^5.5.0" + "@ethersproject/solidity" "^5.0.9" + "@uniswap/sdk-core" "^5.0.0" + "@uniswap/swap-router-contracts" "^1.3.0" + "@uniswap/v3-periphery" "^1.1.1" + "@uniswap/v3-staker" "1.0.0" + tiny-invariant "^1.1.0" + tiny-warning "^1.0.3" + "@uniswap/v3-staker@1.0.0": version "1.0.0" resolved "https://registry.npmjs.org/@uniswap/v3-staker/-/v3-staker-1.0.0.tgz" From df7d119204435124b17a672d90e65282c2b41c4b Mon Sep 17 00:00:00 2001 From: Siyu Jiang <91580504+jsy1218@users.noreply.github.com> Date: Wed, 22 May 2024 22:57:20 -0700 Subject: [PATCH 2/4] bump sor to v3.33.0 --- package.json | 2 +- yarn.lock | 96 +++++++--------------------------------------------- 2 files changed, 13 insertions(+), 85 deletions(-) diff --git a/package.json b/package.json index 9b231d0b..0fc3c32a 100644 --- a/package.json +++ b/package.json @@ -71,7 +71,7 @@ "@uniswap/permit2-sdk": "^1.2.0", "@uniswap/router-sdk": "^1.9.2", "@uniswap/sdk-core": "^5.0.0", - "@uniswap/smart-order-router": "^3.32.0", + "@uniswap/smart-order-router": "^3.33.0", "@uniswap/uniswapx-sdk": "2.1.0-beta.4", "@uniswap/universal-router-sdk": "^2.1.0", "aws-cdk-lib": "2.85.0", diff --git a/yarn.lock b/yarn.lock index a4b39136..d08c732d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -466,7 +466,7 @@ ethereum-cryptography "^2.0.0" micro-ftch "^0.3.1" -"@ethersproject/abi@5.7.0", "@ethersproject/abi@^5.0.12", "@ethersproject/abi@^5.1.2", "@ethersproject/abi@^5.5.0", "@ethersproject/abi@^5.7.0": +"@ethersproject/abi@5.7.0", "@ethersproject/abi@^5.1.2", "@ethersproject/abi@^5.5.0", "@ethersproject/abi@^5.7.0": version "5.7.0" resolved "https://registry.npmjs.org/@ethersproject/abi/-/abi-5.7.0.tgz" integrity sha512-351ktp42TiRcYB3H1OP8yajPeAQstMW/yCFokj/AthP9bLHzQFPlOrxOcwYEDkUAICmOHljvN4K39OMTMUa9RA== @@ -505,7 +505,7 @@ "@ethersproject/logger" "^5.7.0" "@ethersproject/properties" "^5.7.0" -"@ethersproject/address@5.7.0", "@ethersproject/address@^5.0.0", "@ethersproject/address@^5.0.2", "@ethersproject/address@^5.7.0": +"@ethersproject/address@5.7.0", "@ethersproject/address@^5.0.2", "@ethersproject/address@^5.7.0": version "5.7.0" resolved "https://registry.npmjs.org/@ethersproject/address/-/address-5.7.0.tgz" integrity sha512-9wYhYt7aghVGo758POM5nqcOMaE168Q6aRLJZwUmiqSrAungkG74gSSeKEIR7ukixesdRZGPgVqme6vmxs1fkA== @@ -720,7 +720,7 @@ elliptic "6.5.4" hash.js "1.1.7" -"@ethersproject/solidity@5.7.0", "@ethersproject/solidity@^5.0.0", "@ethersproject/solidity@^5.0.9": +"@ethersproject/solidity@5.7.0", "@ethersproject/solidity@^5.0.9": version "5.7.0" resolved "https://registry.npmjs.org/@ethersproject/solidity/-/solidity-5.7.0.tgz" integrity sha512-HmabMd2Dt/raavyaGukF4XxizWKhKQ24DoLtdNbBmNKUOPqwjsKQSdV9GQtj9CBEea9DlzETlVER1gYeXXBGaA== @@ -2078,17 +2078,6 @@ ethers "^5.7.0" tiny-invariant "^1.1.0" -"@uniswap/router-sdk@^1.9.0": - version "1.9.0" - resolved "https://registry.yarnpkg.com/@uniswap/router-sdk/-/router-sdk-1.9.0.tgz#f35432ddc400ddb83985adc840c5898e2bc008cd" - integrity sha512-UeQrrjhOIzPDxHzkF341Sd9PjIzJwiHFQhaEYFIWNE4yC/wzSiISxc5Ebp94p/KVmettoFRa+682yn9IZBhFTA== - dependencies: - "@ethersproject/abi" "^5.5.0" - "@uniswap/sdk-core" "^4.2.0" - "@uniswap/swap-router-contracts" "^1.1.0" - "@uniswap/v2-sdk" "^4.3.0" - "@uniswap/v3-sdk" "^3.11.0" - "@uniswap/router-sdk@^1.9.2": version "1.9.2" resolved "https://registry.yarnpkg.com/@uniswap/router-sdk/-/router-sdk-1.9.2.tgz#cc2411f0849467c2bd71ce34cdca9db2a584367d" @@ -2100,18 +2089,6 @@ "@uniswap/v2-sdk" "^4.3.2" "@uniswap/v3-sdk" "^3.11.2" -"@uniswap/sdk-core@^4.2.0": - version "4.2.0" - resolved "https://registry.yarnpkg.com/@uniswap/sdk-core/-/sdk-core-4.2.0.tgz#9930f133baec9c1118d891ebf8fcba7f7efc153d" - integrity sha512-yXAMLHZRYYuh6KpN2nOlLTYBjGiopmI9WUB4Z0tyNkW4ZZub54cUt22eibpGbZAhRAMxclox9IPIs6wwrM3soQ== - dependencies: - "@ethersproject/address" "^5.0.2" - big.js "^5.2.2" - decimal.js-light "^2.5.0" - jsbi "^3.1.4" - tiny-invariant "^1.1.0" - toformat "^2.0.0" - "@uniswap/sdk-core@^5.0.0": version "5.0.0" resolved "https://registry.npmjs.org/@uniswap/sdk-core/-/sdk-core-5.0.0.tgz#7accd8c7372b14811777cbd1d92133d4de57c683" @@ -2124,23 +2101,23 @@ tiny-invariant "^1.1.0" toformat "^2.0.0" -"@uniswap/smart-order-router@^3.32.0": - version "3.32.0" - resolved "https://registry.yarnpkg.com/@uniswap/smart-order-router/-/smart-order-router-3.32.0.tgz#83d70b10d68744680d570458209f14397b2585c8" - integrity sha512-M6JK/D5zj67LwPHXoREDirL0wcIIvAB6tVa/UvNbKBqyO+Mc/0wFo1APzSE3Z+WYvA0TMZypGFhV9KGYN/ukVg== +"@uniswap/smart-order-router@^3.33.0": + version "3.33.0" + resolved "https://registry.yarnpkg.com/@uniswap/smart-order-router/-/smart-order-router-3.33.0.tgz#ac67e8a88cea46f206c3b70f9bad894b16d771b9" + integrity sha512-G/4AWEbR8LEKJ/L4+V+irgKn4OG97Wx5dc30XgDxFB2E3rfoPhRIvBYXIcVZ2ct7pGQOq4anwR4u7md62JY+ew== dependencies: "@eth-optimism/sdk" "^3.2.2" "@types/brotli" "^1.3.4" "@uniswap/default-token-list" "^11.13.0" "@uniswap/permit2-sdk" "^1.2.0" - "@uniswap/router-sdk" "^1.9.0" - "@uniswap/sdk-core" "^4.2.0" + "@uniswap/router-sdk" "^1.9.2" + "@uniswap/sdk-core" "^5.0.0" "@uniswap/swap-router-contracts" "^1.3.1" "@uniswap/token-lists" "^1.0.0-beta.31" "@uniswap/universal-router" "^1.6.0" "@uniswap/universal-router-sdk" "^2.1.0" - "@uniswap/v2-sdk" "^4.3.0" - "@uniswap/v3-sdk" "^3.11.0" + "@uniswap/v2-sdk" "^4.3.2" + "@uniswap/v3-sdk" "^3.11.2" async-retry "^1.3.1" await-timeout "^1.1.1" axios "^0.21.1" @@ -2155,7 +2132,7 @@ node-cache "^5.1.2" stats-lite "^2.2.0" -"@uniswap/swap-router-contracts@^1.1.0", "@uniswap/swap-router-contracts@^1.3.0", "@uniswap/swap-router-contracts@^1.3.1": +"@uniswap/swap-router-contracts@^1.3.0", "@uniswap/swap-router-contracts@^1.3.1": version "1.3.1" resolved "https://registry.yarnpkg.com/@uniswap/swap-router-contracts/-/swap-router-contracts-1.3.1.tgz#0ebbb93eb578625618ed9489872de381f9c66fb4" integrity sha512-mh/YNbwKb7Mut96VuEtL+Z5bRe0xVIbjjiryn+iMMrK2sFKhR4duk/86mEz0UO5gSx4pQIw9G5276P5heY/7Rg== @@ -2167,18 +2144,6 @@ dotenv "^14.2.0" hardhat-watcher "^2.1.1" -"@uniswap/swap-router-contracts@^1.2.1": - version "1.3.0" - resolved "https://registry.npmjs.org/@uniswap/swap-router-contracts/-/swap-router-contracts-1.3.0.tgz" - integrity sha512-iKvCuRkHXEe0EMjOf8HFUISTIhlxI57kKFllf3C3PUIE0HmwxrayyoflwAz5u/TRsFGYqJ9IjX2UgzLCsrNa5A== - dependencies: - "@openzeppelin/contracts" "3.4.2-solc-0.7" - "@uniswap/v2-core" "1.0.1" - "@uniswap/v3-core" "1.0.0" - "@uniswap/v3-periphery" "1.4.1" - dotenv "^14.2.0" - hardhat-watcher "^2.1.1" - "@uniswap/token-lists@^1.0.0-beta.31": version "1.0.0-beta.33" resolved "https://registry.npmjs.org/@uniswap/token-lists/-/token-lists-1.0.0-beta.33.tgz" @@ -2223,17 +2188,6 @@ resolved "https://registry.npmjs.org/@uniswap/v2-core/-/v2-core-1.0.1.tgz" integrity sha512-MtybtkUPSyysqLY2U210NBDeCHX+ltHt3oADGdjqoThZaFRDKwM6k1Nb3F0A3hk5hwuQvytFWhrWHOEq6nVJ8Q== -"@uniswap/v2-sdk@^4.3.0": - version "4.3.0" - resolved "https://registry.yarnpkg.com/@uniswap/v2-sdk/-/v2-sdk-4.3.0.tgz#621dcf4ea236448a0a49cd901932b3a466c8ae02" - integrity sha512-FUKkgo/1TQc/HuWWgsoy1FIcsLkKwm3Nnor88yfn2NH8ER5RK/wDF9UzDDilYh3yyf2mAnaY89CKFhcIl+lbBQ== - dependencies: - "@ethersproject/address" "^5.0.0" - "@ethersproject/solidity" "^5.0.0" - "@uniswap/sdk-core" "^4.2.0" - tiny-invariant "^1.1.0" - tiny-warning "^1.0.3" - "@uniswap/v2-sdk@^4.3.2": version "4.3.2" resolved "https://registry.yarnpkg.com/@uniswap/v2-sdk/-/v2-sdk-4.3.2.tgz#d8eacdb2ddfeca849ee1cb05377521c4ba0d1542" @@ -2255,18 +2209,6 @@ resolved "https://registry.yarnpkg.com/@uniswap/v3-core/-/v3-core-1.0.1.tgz#b6d2bdc6ba3c3fbd610bdc502395d86cd35264a0" integrity sha512-7pVk4hEm00j9tc71Y9+ssYpO6ytkeI0y7WE9P6UcmNzhxPePwyAxImuhVsTqWK9YFvzgtvzJHi64pBl4jUzKMQ== -"@uniswap/v3-periphery@1.4.1": - version "1.4.1" - resolved "https://registry.npmjs.org/@uniswap/v3-periphery/-/v3-periphery-1.4.1.tgz" - integrity sha512-Ab0ZCKOQrQMKIcpBTezTsEhWfQjItd0TtkCG8mPhoQu+wC67nPaf4hYUhM6wGHeFUmDiYY5MpEQuokB0ENvoTg== - dependencies: - "@openzeppelin/contracts" "3.4.2-solc-0.7" - "@uniswap/lib" "^4.0.1-alpha" - "@uniswap/v2-core" "1.0.1" - "@uniswap/v3-core" "1.0.0" - base64-sol "1.0.1" - hardhat-watcher "^2.1.1" - "@uniswap/v3-periphery@^1.0.1", "@uniswap/v3-periphery@^1.1.1": version "1.4.3" resolved "https://registry.npmjs.org/@uniswap/v3-periphery/-/v3-periphery-1.4.3.tgz" @@ -2289,20 +2231,6 @@ "@uniswap/v3-core" "^1.0.0" base64-sol "1.0.1" -"@uniswap/v3-sdk@^3.11.0": - version "3.11.0" - resolved "https://registry.yarnpkg.com/@uniswap/v3-sdk/-/v3-sdk-3.11.0.tgz#328309fbafddd8c618b7b6850bb99cacf6733a79" - integrity sha512-gz6Q6SlN34AXvxhyz181F90D4OuIkxLnzBAucEzB9Fv3Z+3orHZY/SpGaD02nP1VsNQVu/DQvOsdkPUDGn1Y9Q== - dependencies: - "@ethersproject/abi" "^5.0.12" - "@ethersproject/solidity" "^5.0.9" - "@uniswap/sdk-core" "^4.2.0" - "@uniswap/swap-router-contracts" "^1.2.1" - "@uniswap/v3-periphery" "^1.1.1" - "@uniswap/v3-staker" "1.0.0" - tiny-invariant "^1.1.0" - tiny-warning "^1.0.3" - "@uniswap/v3-sdk@^3.11.2": version "3.11.2" resolved "https://registry.yarnpkg.com/@uniswap/v3-sdk/-/v3-sdk-3.11.2.tgz#cda523307549548b6b53a1d5d1badeff1627a88b" From a21afb09a33713245ebd6d9b97b13976f0d84e23 Mon Sep 17 00:00:00 2001 From: Siyu Jiang <91580504+jsy1218@users.noreply.github.com> Date: Wed, 22 May 2024 23:07:04 -0700 Subject: [PATCH 3/4] only bump ur-sdk and router-sdk to avoid unit test failure --- package.json | 4 ++-- yarn.lock | 14 +++++++++++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 0fc3c32a..9afcd1ea 100644 --- a/package.json +++ b/package.json @@ -70,8 +70,8 @@ "@uniswap/default-token-list": "^11.7.0", "@uniswap/permit2-sdk": "^1.2.0", "@uniswap/router-sdk": "^1.9.2", - "@uniswap/sdk-core": "^5.0.0", - "@uniswap/smart-order-router": "^3.33.0", + "@uniswap/sdk-core": "^4.2.0", + "@uniswap/smart-order-router": "^3.26.0", "@uniswap/uniswapx-sdk": "2.1.0-beta.4", "@uniswap/universal-router-sdk": "^2.1.0", "aws-cdk-lib": "2.85.0", diff --git a/yarn.lock b/yarn.lock index d08c732d..33c05c6d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2089,6 +2089,18 @@ "@uniswap/v2-sdk" "^4.3.2" "@uniswap/v3-sdk" "^3.11.2" +"@uniswap/sdk-core@^4.2.0": + version "4.2.1" + resolved "https://registry.yarnpkg.com/@uniswap/sdk-core/-/sdk-core-4.2.1.tgz#7b8c6fee48446bb67a4e6f2e9cb94c862034a6c3" + integrity sha512-hr7vwYrXScg+V8/rRc2UL/Ixc/p0P7yqe4D/OxzUdMRYr8RZd+8z5Iu9+WembjZT/DCdbTjde6lsph4Og0n1BQ== + dependencies: + "@ethersproject/address" "^5.0.2" + big.js "^5.2.2" + decimal.js-light "^2.5.0" + jsbi "^3.1.4" + tiny-invariant "^1.1.0" + toformat "^2.0.0" + "@uniswap/sdk-core@^5.0.0": version "5.0.0" resolved "https://registry.npmjs.org/@uniswap/sdk-core/-/sdk-core-5.0.0.tgz#7accd8c7372b14811777cbd1d92133d4de57c683" @@ -2101,7 +2113,7 @@ tiny-invariant "^1.1.0" toformat "^2.0.0" -"@uniswap/smart-order-router@^3.33.0": +"@uniswap/smart-order-router@^3.26.0": version "3.33.0" resolved "https://registry.yarnpkg.com/@uniswap/smart-order-router/-/smart-order-router-3.33.0.tgz#ac67e8a88cea46f206c3b70f9bad894b16d771b9" integrity sha512-G/4AWEbR8LEKJ/L4+V+irgKn4OG97Wx5dc30XgDxFB2E3rfoPhRIvBYXIcVZ2ct7pGQOq4anwR4u7md62JY+ew== From e243572b981ccfc82bb1b0dce6065ed84e52c660 Mon Sep 17 00:00:00 2001 From: Siyu Jiang <91580504+jsy1218@users.noreply.github.com> Date: Thu, 23 May 2024 06:58:47 -0700 Subject: [PATCH 4/4] address feedback --- test/integ/quote-classic.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/integ/quote-classic.test.ts b/test/integ/quote-classic.test.ts index 6946f978..d89aa98e 100644 --- a/test/integ/quote-classic.test.ts +++ b/test/integ/quote-classic.test.ts @@ -587,6 +587,9 @@ describe('quote', function () { if (chain === ChainId.BLAST || chain === ChainId.ZORA) { // Blast doesn't have DAI or USDC yet // Zora doesn't have DAI + + // This test will become ETH -> WETH quote, and it will throw INVARIANT ADDRESS from sdk-core. + // Reasons explained in https://github.com/Uniswap/unified-routing-api/pull/425#discussion_r1611055408. return; }