Add a couple tests.

Author: jeffFranklin

README.md

@@ -24,6 +24,7 @@ Response.
 
 ```python
 from flask import request, session, redirect
+import uw_saml2
 
 @app.route('/saml/login', methods=['GET', 'POST'])
 def login():

setup.py

@@ -20,5 +20,6 @@
       license='Apache License, Version 2.0',
       packages=find_packages(),
       include_package_data=True,
-      install_requires=['python3-saml']
+      install_requires=['python3-saml'],
+      tests_require=['pytest', 'pytest-cov', 'mock', 'pycodestyle']
       )

tests/samlresponse.txt

@@ -0,0 +1 @@
+RelayState=%2Fsecure&SAMLResponse=PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHNhbWwycDpSZXNwb25zZSBEZXN0aW5hdGlvbj0iaHR0cHM6Ly9zYW1sZGVtby5pYW1kZXYucy51dy5lZHUvc2FtbC9sb2dpbiIgSUQ9Il83ZjFiNTlmMmZjYTVmMDkwZDk2ODBjNmUxYjMwYjBmMSIgSW5SZXNwb25zZVRvPSJPTkVMT0dJTl8wMTYwOGY3NjdhNDg1YTEyZDYxMWZiOGRlZTJiZjA4ZWJlNDJlYmI2IiBJc3N1ZUluc3RhbnQ9IjIwMTktMDItMDRUMTg6MTE6MjIuMDU0WiIgVmVyc2lvbj0iMi4wIiB4bWxuczpzYW1sMnA9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDpwcm90b2NvbCIgeG1sbnM6eHNkPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxL1hNTFNjaGVtYSI%2BPHNhbWwyOklzc3VlciB4bWxuczpzYW1sMj0idXJuOm9hc2lzOm5hbWVzOnRjOlNBTUw6Mi4wOmFzc2VydGlvbiI%2BdXJuOm1hY2U6aW5jb21tb246d2FzaGluZ3Rvbi5lZHU8L3NhbWwyOklzc3Vlcj48ZHM6U2lnbmF0dXJlIHhtbG5zOmRzPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwLzA5L3htbGRzaWcjIj4KPGRzOlNpZ25lZEluZm8%2BCjxkczpDYW5vbmljYWxpemF0aW9uTWV0aG9kIEFsZ29yaXRobT0iaHR0cDovL3d3dy53My5vcmcvMjAwMS8xMC94bWwtZXhjLWMxNG4jIi8%2BCjxkczpTaWduYXR1cmVNZXRob2QgQWxnb3JpdGhtPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxLzA0L3htbGRzaWctbW9yZSNyc2Etc2hhMjU2Ii8%2BCjxkczpSZWZlcmVuY2UgVVJJPSIjXzdmMWI1OWYyZmNhNWYwOTBkOTY4MGM2ZTFiMzBiMGYxIj4KPGRzOlRyYW5zZm9ybXM%2BCjxkczpUcmFuc2Zvcm0gQWxnb3JpdGhtPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwLzA5L3htbGRzaWcjZW52ZWxvcGVkLXNpZ25hdHVyZSIvPgo8ZHM6VHJhbnNmb3JtIEFsZ29yaXRobT0iaHR0cDovL3d3dy53My5vcmcvMjAwMS8xMC94bWwtZXhjLWMxNG4jIj48ZWM6SW5jbHVzaXZlTmFtZXNwYWNlcyBQcmVmaXhMaXN0PSJ4c2QiIHhtbG5zOmVjPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxLzEwL3htbC1leGMtYzE0biMiLz48L2RzOlRyYW5zZm9ybT4KPC9kczpUcmFuc2Zvcm1zPgo8ZHM6RGlnZXN0TWV0aG9kIEFsZ29yaXRobT0iaHR0cDovL3d3dy53My5vcmcvMjAwMS8wNC94bWxlbmMjc2hhMjU2Ii8%2BCjxkczpEaWdlc3RWYWx1ZT5RUHdSM3VCbnJ5QThwODVuQVBSSldpTTFpM1JyUGJoMHJVdGtxWk1YQ1Q0PTwvZHM6RGlnZXN0VmFsdWU%2BCjwvZHM6UmVmZXJlbmNlPgo8L2RzOlNpZ25lZEluZm8%2BCjxkczpTaWduYXR1cmVWYWx1ZT4KTEJ1bFh1NjJvdnliblVoU3l1ZXBId1diUHpackVBMEQvMEJwcXBPMG5zamVteXhNU0VFay9VRXBuZXIreTJYVktLWFN3QitwUWV3Rwpiem9GNnROL3A1L1U5WThDWWRVdnVPVG9xN0dac2RuTWsxdm9rM0FJaW96Z3VteHF5KzFXdmg4aHQvZlc5eDlHczhDRE5xd0lsa1A2CjJ5WGRGYmNScnE3ME5ia1BmK04rK0wxaEtlVjZwbnl4dHJNeWVkUHZQZHFId29xNGJpY0QrUlY5WVNXcXRPK0srRnlnUndwbTJxeFkKTkIwRmhZOS9VT2FoNTA4a21LVWZhdmgvelcwSXJYdkZ6RG02cVVGNmVDd2FtTERERThtZG5ZbTlLQ1VpcCs1cDR1VVE2bWZCb24yTgpyR29QK3E0SkkzbTBBKzJQSzVCRFgrUVZLblJ6UHZEcnhyb0k1QT09CjwvZHM6U2lnbmF0dXJlVmFsdWU%2BCjxkczpLZXlJbmZvPjxkczpYNTA5RGF0YT48ZHM6WDUwOUNlcnRpZmljYXRlPk1JSUQvVENDQXVXZ0F3SUJBZ0lKQU1vWUpiRHQ5bEtLTUEwR0NTcUdTSWIzRFFFQkJRVUFNRnd4Q3pBSkJnTlZCQVlUQWxWVE1Rc3cKQ1FZRFZRUUlFd0pYUVRFaE1COEdBMVVFQ2hNWVZXNXBkbVZ5YzJsMGVTQnZaaUJYWVhOb2FXNW5kRzl1TVIwd0d3WURWUVFERXhScApaSEF1ZFM1M1lYTm9hVzVuZEc5dUxtVmtkVEFlRncweE1UQTBNall4T1RFd016bGFGdzB5TVRBME1qTXhPVEV3TXpsYU1Gd3hDekFKCkJnTlZCQVlUQWxWVE1Rc3dDUVlEVlFRSUV3SlhRVEVoTUI4R0ExVUVDaE1ZVlc1cGRtVnljMmwwZVNCdlppQlhZWE5vYVc1bmRHOXUKTVIwd0d3WURWUVFERXhScFpIQXVkUzUzWVhOb2FXNW5kRzl1TG1Wa2RUQ0NBU0l3RFFZSktvWklodmNOQVFFQkJRQURnZ0VQQURDQwpBUW9DZ2dFQkFNSDlHOG02OEwwSGY5Ym1mNC83YytFUnhnRFFyYnE1ME5mU2kyWVRRV2MxdmVVSVBZYlp5MWFnU051YzRkd24zUnRDCjB1T1FiZE5UWVVBaVZUY1lnYVljZUpWQjdzeVdmOVF5R0lyZ2xaUE11OThjNWhXYjd2cXd2czZkM3MyU203dEJpYjJ2NnhRRERpWjQKS0p4cGRBdnNvUFFsbUdkZ3BGZm1Bc2lZcm5ZRlhMVEhnYmdDYy9ZaFY4bHViVGFrVWRJM2JNWVdmaDlka2orRFZHVW10MmdMdFFVegpidUg4RVU0NHZuWGdyUVlTWE5Ra21SY3lvRTNyajRSaGhidS9wNUQzUCtudU91a0xZRk9MUmFOZWlpR3lUdTNQN2d0Yy9keS9ValVyCmYrcEg3NVVVVTdMYjM2OWRHRWZad3ZWdElUWHNkeXAwcEJmdW40Q1A4MDhIOU4wQ0F3RUFBYU9Cd1RDQnZqQWRCZ05WSFE0RUZnUVUKUDVzbXgzWllLT0RNa0RnbGtUYmR1dkxjR1lBd2dZNEdBMVVkSXdTQmhqQ0JnNEFVUDVzbXgzWllLT0RNa0RnbGtUYmR1dkxjR1lDaApZS1JlTUZ3eEN6QUpCZ05WQkFZVEFsVlRNUXN3Q1FZRFZRUUlFd0pYUVRFaE1COEdBMVVFQ2hNWVZXNXBkbVZ5YzJsMGVTQnZaaUJYCllYTm9hVzVuZEc5dU1SMHdHd1lEVlFRREV4UnBaSEF1ZFM1M1lYTm9hVzVuZEc5dUxtVmtkWUlKQU1vWUpiRHQ5bEtLTUF3R0ExVWQKRXdRRk1BTUJBZjh3RFFZSktvWklodmNOQVFFRkJRQURnZ0VCQUVvN2MyQ05IRUkrRnZ6NURod3VtVStXSFhxd1NPSzQ3TXhYd05KVgpwRlE5R1BSMlpHREFxNmh6TEpMQVZXY1k0a0IzRUNEa1J0eXNBV1NGSG0xcm9PVTd4c1U5ZjBDMTdRb2tvWGZMTkMwZDdLb2l2UE02CmN0bDhhUmZ0VTVtb3lGSmtrSlgzcVNFeFhybDA1M3V4VE9RVlBtczR5cGtZdjFBL0ZCWldnU0M4ZU5vWW5CbnYxTWh5NG04YmZlRU4KN3FUOXJGb3hoNGNWak1IMVlrcTdKV3lGWExFQjRpZnpINEtIeXBsdDVSeXY2MWVoNkoxWVBGYTJSdXJWVHlHcEhKWmVPTFVJQnZKdQoxNUd6Y2V4dUREWGUwa2c3c0hENlBiSzB4ekVGL1FlWFAvaFh6TXhSOWtRWEIvSVIvYjJrNGllbitFTTNlWS91ZUJjVFo5NWRnVk09PC9kczpYNTA5Q2VydGlmaWNhdGU%2BPC9kczpYNTA5RGF0YT48L2RzOktleUluZm8%2BPC9kczpTaWduYXR1cmU%2BPHNhbWwycDpTdGF0dXM%2BPHNhbWwycDpTdGF0dXNDb2RlIFZhbHVlPSJ1cm46b2FzaXM6bmFtZXM6dGM6U0FNTDoyLjA6c3RhdHVzOlN1Y2Nlc3MiLz48L3NhbWwycDpTdGF0dXM%2BPHNhbWwyOkFzc2VydGlvbiBJRD0iXzk5YjA2ZGYwNmFlYTgwZDRiZGQwMzkyYTI4Yjk2NmQ3IiBJc3N1ZUluc3RhbnQ9IjIwMTktMDItMDRUMTg6MTE6MjIuMDU0WiIgVmVyc2lvbj0iMi4wIiB4bWxuczpzYW1sMj0idXJuOm9hc2lzOm5hbWVzOnRjOlNBTUw6Mi4wOmFzc2VydGlvbiI%2BPHNhbWwyOklzc3Vlcj51cm46bWFjZTppbmNvbW1vbjp3YXNoaW5ndG9uLmVkdTwvc2FtbDI6SXNzdWVyPjxzYW1sMjpTdWJqZWN0PjxzYW1sMjpOYW1lSUQgRm9ybWF0PSJ1cm46b2FzaXM6bmFtZXM6dGM6U0FNTDoyLjA6bmFtZWlkLWZvcm1hdDp0cmFuc2llbnQiIE5hbWVRdWFsaWZpZXI9InVybjptYWNlOmluY29tbW9uOndhc2hpbmd0b24uZWR1IiBTUE5hbWVRdWFsaWZpZXI9Imh0dHBzOi8vc2FtbGRlbW8uaWFtZGV2LnMudXcuZWR1L3NhbWwiPkFBZHpaV055WlhReEh0bXo5VTFIN3JFb2NtN0xnaFNiM1h5UFNOR2xBb094SngzNW44SzFuQjJ1Qk9yM2RlalMxOFl0dGM5cU5rOFZvcGpKTXZLYjdVZnlSZWNsTy94VWZkQXBuS2p0bjlpd096S1Q3OWpEU2hPd3JXUkJiNFUzOEx0eGNhR3RGZnNxUU1YK2RrSjJQd2pUPC9zYW1sMjpOYW1lSUQ%2BPHNhbWwyOlN1YmplY3RDb25maXJtYXRpb24gTWV0aG9kPSJ1cm46b2FzaXM6bmFtZXM6dGM6U0FNTDoyLjA6Y206YmVhcmVyIj48c2FtbDI6U3ViamVjdENvbmZpcm1hdGlvbkRhdGEgQWRkcmVzcz0iOTcuMTEzLjEzOC4xMjUiIEluUmVzcG9uc2VUbz0iT05FTE9HSU5fMDE2MDhmNzY3YTQ4NWExMmQ2MTFmYjhkZWUyYmYwOGViZTQyZWJiNiIgTm90T25PckFmdGVyPSIyMDE5LTAyLTA0VDE4OjE2OjIyLjA2M1oiIFJlY2lwaWVudD0iaHR0cHM6Ly9zYW1sZGVtby5pYW1kZXYucy51dy5lZHUvc2FtbC9sb2dpbiIvPjwvc2FtbDI6U3ViamVjdENvbmZpcm1hdGlvbj48L3NhbWwyOlN1YmplY3Q%2BPHNhbWwyOkNvbmRpdGlvbnMgTm90QmVmb3JlPSIyMDE5LTAyLTA0VDE4OjExOjIyLjA1NFoiIE5vdE9uT3JBZnRlcj0iMjAxOS0wMi0wNFQxODoxNjoyMi4wNTRaIj48c2FtbDI6QXVkaWVuY2VSZXN0cmljdGlvbj48c2FtbDI6QXVkaWVuY2U%2BaHR0cHM6Ly9zYW1sZGVtby5pYW1kZXYucy51dy5lZHUvc2FtbDwvc2FtbDI6QXVkaWVuY2U%2BPC9zYW1sMjpBdWRpZW5jZVJlc3RyaWN0aW9uPjwvc2FtbDI6Q29uZGl0aW9ucz48c2FtbDI6QXV0aG5TdGF0ZW1lbnQgQXV0aG5JbnN0YW50PSIyMDE5LTAyLTA0VDE4OjExOjIxLjY5M1oiIFNlc3Npb25JbmRleD0iX2JhM2QxYmY1ZjU2ZmFhZWNhYjIwNzUwNDk0NWY1MjAwIj48c2FtbDI6U3ViamVjdExvY2FsaXR5IEFkZHJlc3M9Ijk3LjExMy4xMzguMTI1Ii8%2BPHNhbWwyOkF1dGhuQ29udGV4dD48c2FtbDI6QXV0aG5Db250ZXh0Q2xhc3NSZWY%2BdXJuOm9hc2lzOm5hbWVzOnRjOlNBTUw6Mi4wOmFjOmNsYXNzZXM6UGFzc3dvcmRQcm90ZWN0ZWRUcmFuc3BvcnQ8L3NhbWwyOkF1dGhuQ29udGV4dENsYXNzUmVmPjwvc2FtbDI6QXV0aG5Db250ZXh0Pjwvc2FtbDI6QXV0aG5TdGF0ZW1lbnQ%2BPHNhbWwyOkF0dHJpYnV0ZVN0YXRlbWVudD48c2FtbDI6QXR0cmlidXRlIEZyaWVuZGx5TmFtZT0iaXNNZW1iZXJPZiIgTmFtZT0idXJuOm9pZDoxLjMuNi4xLjQuMS41OTIzLjEuNS4xLjEiIE5hbWVGb3JtYXQ9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDphdHRybmFtZS1mb3JtYXQ6dXJpIj48c2FtbDI6QXR0cmlidXRlVmFsdWUgeG1sbnM6eHNpPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxL1hNTFNjaGVtYS1pbnN0YW5jZSIgeHNpOnR5cGU9InhzZDpzdHJpbmciPnVybjptYWNlOndhc2hpbmd0b24uZWR1Omdyb3Vwczp1X2pwZl90ZXN0LXNhbWw8L3NhbWwyOkF0dHJpYnV0ZVZhbHVlPjwvc2FtbDI6QXR0cmlidXRlPjxzYW1sMjpBdHRyaWJ1dGUgRnJpZW5kbHlOYW1lPSJ1aWQiIE5hbWU9InVybjpvaWQ6MC45LjIzNDIuMTkyMDAzMDAuMTAwLjEuMSIgTmFtZUZvcm1hdD0idXJuOm9hc2lzOm5hbWVzOnRjOlNBTUw6Mi4wOmF0dHJuYW1lLWZvcm1hdDp1cmkiPjxzYW1sMjpBdHRyaWJ1dGVWYWx1ZSB4bWxuczp4c2k9Imh0dHA6Ly93d3cudzMub3JnLzIwMDEvWE1MU2NoZW1hLWluc3RhbmNlIiB4c2k6dHlwZT0ieHNkOnN0cmluZyI%2BaWR0ZXN0NTU8L3NhbWwyOkF0dHJpYnV0ZVZhbHVlPjwvc2FtbDI6QXR0cmlidXRlPjxzYW1sMjpBdHRyaWJ1dGUgRnJpZW5kbHlOYW1lPSJlZHVQZXJzb25BZmZpbGlhdGlvbiIgTmFtZT0idXJuOm9pZDoxLjMuNi4xLjQuMS41OTIzLjEuMS4xLjEiIE5hbWVGb3JtYXQ9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDphdHRybmFtZS1mb3JtYXQ6dXJpIj48c2FtbDI6QXR0cmlidXRlVmFsdWUgeG1sbnM6eHNpPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxL1hNTFNjaGVtYS1pbnN0YW5jZSIgeHNpOnR5cGU9InhzZDpzdHJpbmciPnN0dWRlbnQ8L3NhbWwyOkF0dHJpYnV0ZVZhbHVlPjxzYW1sMjpBdHRyaWJ1dGVWYWx1ZSB4bWxuczp4c2k9Imh0dHA6Ly93d3cudzMub3JnLzIwMDEvWE1MU2NoZW1hLWluc3RhbmNlIiB4c2k6dHlwZT0ieHNkOnN0cmluZyI%2BbWVtYmVyPC9zYW1sMjpBdHRyaWJ1dGVWYWx1ZT48L3NhbWwyOkF0dHJpYnV0ZT48c2FtbDI6QXR0cmlidXRlIEZyaWVuZGx5TmFtZT0iZWR1UGVyc29uUHJpbmNpcGFsTmFtZSIgTmFtZT0idXJuOm9pZDoxLjMuNi4xLjQuMS41OTIzLjEuMS4xLjYiIE5hbWVGb3JtYXQ9InVybjpvYXNpczpuYW1lczp0YzpTQU1MOjIuMDphdHRybmFtZS1mb3JtYXQ6dXJpIj48c2FtbDI6QXR0cmlidXRlVmFsdWUgeG1sbnM6eHNpPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxL1hNTFNjaGVtYS1pbnN0YW5jZSIgeHNpOnR5cGU9InhzZDpzdHJpbmciPmlkdGVzdDU1QHdhc2hpbmd0b24uZWR1PC9zYW1sMjpBdHRyaWJ1dGVWYWx1ZT48L3NhbWwyOkF0dHJpYnV0ZT48c2FtbDI6QXR0cmlidXRlIEZyaWVuZGx5TmFtZT0iZWR1UGVyc29uU2NvcGVkQWZmaWxpYXRpb24iIE5hbWU9InVybjpvaWQ6MS4zLjYuMS40LjEuNTkyMy4xLjEuMS45IiBOYW1lRm9ybWF0PSJ1cm46b2FzaXM6bmFtZXM6dGM6U0FNTDoyLjA6YXR0cm5hbWUtZm9ybWF0OnVyaSI%2BPHNhbWwyOkF0dHJpYnV0ZVZhbHVlIHhtbG5zOnhzaT0iaHR0cDovL3d3dy53My5vcmcvMjAwMS9YTUxTY2hlbWEtaW5zdGFuY2UiIHhzaTp0eXBlPSJ4c2Q6c3RyaW5nIj5zdHVkZW50QHdhc2hpbmd0b24uZWR1PC9zYW1sMjpBdHRyaWJ1dGVWYWx1ZT48c2FtbDI6QXR0cmlidXRlVmFsdWUgeG1sbnM6eHNpPSJodHRwOi8vd3d3LnczLm9yZy8yMDAxL1hNTFNjaGVtYS1pbnN0YW5jZSIgeHNpOnR5cGU9InhzZDpzdHJpbmciPm1lbWJlckB3YXNoaW5ndG9uLmVkdTwvc2FtbDI6QXR0cmlidXRlVmFsdWU%2BPC9zYW1sMjpBdHRyaWJ1dGU%2BPC9zYW1sMjpBdHRyaWJ1dGVTdGF0ZW1lbnQ%2BPC9zYW1sMjpBc3NlcnRpb24%2BPC9zYW1sMnA6UmVzcG9uc2U%2B

tests/test_auth.py

@@ -0,0 +1,63 @@
+import uw_saml2
+from onelogin.saml2.utils import OneLogin_Saml2_Utils
+import pytest
+import mock
+import os
+import urllib.parse
+BASEDIR = os.path.abspath(os.path.dirname(__file__))
+
+
+def test_login_redirect(mock_time_and_id):
+    """Fix the time and check that the request still looks the same."""
+    entity_id = 'https://example.org/saml'
+    acs_url = 'https://example.org/saml/login'
+    url = uw_saml2.login_redirect(entity_id=entity_id, acs_url=acs_url,
+                                  return_to='/foo')
+    expected_url = (
+        'https://idp.u.washington.edu/idp/profile/SAML2/Redirect/SSO?'
+        'SAMLRequest=fVPBbqMwEL33KxD34ECjrdZKkGiiaiN1NwjoHvbm2pPEkrFZe9xk%2F35'
+        'tmjap1IYL0pv3hvdmhrljvRpo5XGvG%2FjrweFNkhx7pR0dS4vUW00Nc9JRzXpwFDltq5'
+        '%2BPtMimdLAGDTcq%2FSC6rmHOgUVpdBStV4v0YbO5r5q8uI3Ab7Au1BZpoI4E5zystUO'
+        'mMYDT%2FPtkWkymsy6%2Fo7NvtJj9iaxV8C01w1G5RxwcJUSKIfPZgbm91Ds0OgPhI0iC'
+        '661UQKKlgjQgpAWOpG03sVd9ynQvtQjC62GeX0mO%2Fui6elJv2i62qN4iLo12vgfbgn2'
+        'RHJ6ax7M9OLJ%2BUJAZuyNxakSZndRpGfRJMo8IHcPb8ivFnFyyzrqB%2FgpG16vaKMn'
+        '%2FjXh8HoztGX6dJ8%2FyEZFish2p1Gs3AJdbCSJ9b1MpZQ5LCwxhkaL1kCbkw8dPdwRi'
+        'vKowAoQjJkvTD8xKFzcUgnA8JT2nvaQvVTiTBrbl1UvilEdegOvwOhgr4vLCLkF0lgXzx'
+        'uJpSJ82f3VNrtgub97Kl79I%2BR8%3D&RelayState=%2Ffoo')
+    assert url == expected_url
+
+
+def test_process_response(mock_time_and_id):
+    """
+    Take a once-valid SAML Response, mock the time to when it was valid,
+    validate the response, and compare the attributes.
+    """
+    with open(os.path.join(BASEDIR, 'samlresponse.txt')) as fd:
+        post = dict(urllib.parse.parse_qsl(fd.read()))
+    # set a time when this response was still valid
+    mock_time_and_id.return_value = 1549304000
+    entity_id = 'https://samldemo.iamdev.s.uw.edu/saml'
+    acs_url = 'https://samldemo.iamdev.s.uw.edu/saml/login'
+    attributes = uw_saml2.process_response(post, entity_id=entity_id,
+                                           acs_url=acs_url)
+    expected_attributes = {
+        'affiliations': ['student', 'member'],
+        'eppn': 'idtest55@washington.edu',
+        'groups': ['u_jpf_test-saml'],
+        'scoped_affiliations': ['student@washington.edu',
+                                'member@washington.edu'],
+        'two_factor': False,
+        'uwnetid': 'idtest55'
+    }
+    assert attributes == expected_attributes
+
+
+@pytest.fixture
+def mock_time_and_id(monkeypatch):
+    """Mock the two things guaranteed to be nondeterministic - date and id."""
+    utils = 'onelogin.saml2.utils.OneLogin_Saml2_Utils'
+    mock_time = mock.MagicMock()
+    mock_time.return_value = 1549302384
+    monkeypatch.setattr(f'{utils}.now', mock_time)
+    monkeypatch.setattr(f'{utils}.generate_unique_id', lambda: 'FOOBAR123')
+    return mock_time

uw_saml2/auth.py

@@ -16,6 +16,8 @@ def login_redirect(entity_id=None, acs_url=None, return_to='/',
     acs_url - The SP endpoint the Identity Provider will post back to, known
         technically as the Assertion Consumer Service. This endpoint along
         with the Entity Id are registered with the IdP.
+    return_to - The URL to send back to after authentication. This is known
+        in a SAML request as 'RelayState'.
     force_authn - whether to force authentication even if the user has already
         authenticated against the IdP.
     idp - which IdP to use, defaulting to UW's IdP. Other IdPs of type

uw_saml2/idp/attribute.py

@@ -1,6 +1,11 @@
 """Attribute mappings."""
 
+
 def map(attribute_data, idp):
+    """
+    Map attribute data from an IdP's SAML Response to values that are
+    easier to consume.
+    """
     attribute_map = {idp.id_attribute: idp.mapped_id_attribute}
     attribute_map.update(idp.attribute_map)
     for key, values in attribute_data.items():
@@ -11,6 +16,7 @@ def map(attribute_data, idp):
         if value is not None:
             yield attribute.name, value
 
+
 class Attribute:
     """Base class for mapping a list of attribute values."""
     def __init__(self, name):

uw_saml2/idp/federated.py

@@ -1,6 +1,7 @@
 """Federated Identity Providers."""
 from . import IdpConfig, attribute
 
+
 class CascadiaStudentIdp(IdpConfig):
     entity_id = 'https://idp.cascadia.edu/idp/shibboleth'
     sso_url = 'https://idp.student.cascadia.edu/idp/profile/SAML2/Redirect/SSO'

uw_saml2/sp.py

@@ -16,7 +16,7 @@ def __init__(self, entity_id=None, acs_url=None):
             self.entity_id = entity_id
         if acs_url:
             self.acs_url = acs_url
-    
+
     def request(self, post=None):
         post = post or {}
         parsed_url = urlparse(self.acs_url)