Argument of read_shp3d

[Ken-Kuroki]

Hi, I was trying out EasyIDP and it`s great, but encountered an issue.

This piece of my code

plots = p4d.read_shp3d(shp_path=shape_file, get_z_by='all', shp_proj=pyproj.CRS.from_epsg(32653))

Gave me

[io][shp][proj] find ESRI projection file data/shp/l1.prj, and successfully obtain projection cartesian
Traceback (most recent call last):4/74        
  File "src/extract_plots.py", line 127, in <module>
    app.run(main)
  File "/home/fieldphenomics/miniconda3/envs/ku/lib/python3.7/site-packages/absl/app.py", line 312, in run
    _run_main(main, args)
  File "/home/fieldphenomics/miniconda3/envs/ku/lib/python3.7/site-packages/absl/app.py", line 258, in _run_main
    sys.exit(main(argv))
  File "src/extract_plots.py", line 123, in main
    FLAGS.image_path, FLAGS.shape_file, FLAGS.save_dir)
  File "src/extract_plots.py", line 105, in run
    shp_proj=pyproj.CRS.from_epsg(32653))  # 32653 for kansai region!
  File "/mnt/f/ku/src/easyric/objects.py", line 225, in read_shp3d
    shp_path, self.dsm_file, get_z_by, shp_proj, geotiff_proj, geo_head=self.dsm_header)
  File "/mnt/f/ku/src/easyric/io/shp.py", line 210, in read_shp3d
    buffered = Polygon(seed).buffer(get_z_buffer)
  File "/home/fieldphenomics/miniconda3/envs/ku/lib/python3.7/site-packages/shapely/geometry/base.py", line 637, in buffer
    return geom_factory(self.impl['buffer_with_params'](self, params, distance))
  File "/home/fieldphenomics/miniconda3/envs/ku/lib/python3.7/site-packages/shapely/topology.py", line 78, in __call__
    return self.fn(this._geom, *args)
ctypes.ArgumentError: argument 4: <class 'TypeError'>: wrong type

It looks it comes from this line.

EasyIDP/easyric/objects.py

Line 209 in 52c839d

shp_dict = shp.read_shp3d(shp_path, self.dsm_file, get_z_by, shp_proj, geotiff_proj, geo_head=self.dsm_header)

It gives shp_proj to read_shp3d in io/shp.py as the 4th argument, but the called method is defined as below, expecting a numeric value for z_buffer at that position, not shp_proj, which should be given next.

EasyIDP/easyric/io/shp.py

Line 124 in 52c839d

def read_shp3d(shp_path, dsm_path, get_z_by='mean', get_z_buffer=0, shp_proj=None, geotiff_proj=None, geo_head=None, name_field=None, title_include=False, encoding='utf-8'):

So, I was able to avoid the error by simply giving 0 as the 4th argument although I'm not sure what is the right value to be given. Could you take a look at it? Apparently it's working alright with my workaround but it's nice if you can properly fix it. Thanks!

[HowcanoeWang]

It has been fixed in this commit: 0d0a0df

And personally recommend using shp.read_shp3d() rather than p4d.read_shp3d() for the latest updates.

[Ken-Kuroki]

Thank you for your swift response and fix! I'll also refactor my code to use p4d.read_shp3d().