Skip to content

Compatibility with UI5 tooling fiori-tools-proxy #26

@mathew-rizing

Description

@mathew-rizing

Why are you proposing this feature?

We have implemented the UI5 Renovate (LTS) into our pipeline without any hiccups, thanks for the great work. I can confirm that the Renovate PR attempts to update the following successfully:

  1. ui5*.yaml > Framework version
  2. manifest.json > sap.platform.cf.ui5VersionNumber
  3. CommonDataModel.json > ui5VersionNumber

however the following doesn't seem to be captured:

  1. manifest.json > sapui5.dependencies.minUI5Version
    Image

Background of my project setup:

  1. CAP backend and UI5 frontend are located in two different repositories/folders
  2. Frontend is served locally using UI5 tooling (ui5 serve -> ui5.yaml) with fiori-tools-proxy for UI5 libraries and we use relative paths at bootstrap (index.html, flpSandbox.html). this results in all /resources and /test-resources to go through the proxy

Image

Image

We want to synchronize the UI5 version when run locally (via ui5 serve) and the deployed version to Build Work Zone (sap.platform.cf.ui5VersionNumber). At the current state, when running the app locally it will fallback to version 1.120.14 which is our minUI5Version in manifest.json

Image

How should a possible solution look like?

  1. also capture manifest.json > sapui5.dependencies.minUI5Version and update in the Renovate PR. though i'm not sure if this is a good solution as technically it isn't the "minimum"
  2. alternatively, we can specify "version" configuration for fiori-tools-proxy in ui5.yaml and it should be updated in the Renovate PR

Image

Are there alternative approaches?

an alternative is to retain the absolute url in local bootstraps (index.html, flpSandbox.html), i believe these are updated from Renovate PR. i would like to avoid this to prevent having to specify the ui5 versions in many places

Any further information you would like to share?

feel free to propose another local set-up if you think it should be changed. the goal is to sync local + deployed UI5 versions

Another unrelated note: sap.platform.cf.ui5VersionNumber may have patch-level independent value: "1.120.x" which the Renovate PR changes to "1.120.30x", seems like this is not supported. however with this Renovate preset, it already acts as an alternative as it should always create PR for the latest patch so we have removed the "x"

Image

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions