Floating Point Comparison Issues

[Mr-Anyone]

Software/src/software/ai/navigator/obstacle/trajectory_obstacle.hpp

Line 43 in bc5e720

if (t_sec == 0)

Software/src/software/ai/navigator/obstacle/trajectory_obstacle.hpp

Line 59 in bc5e720

if (t_sec == 0)

Software/src/software/ai/navigator/obstacle/trajectory_obstacle.hpp

Line 76 in bc5e720

if (t_sec == 0)

Software/src/software/ai/navigator/obstacle/trajectory_obstacle.hpp

Line 93 in bc5e720

if (t_sec == 0)

This branch is always false because of floating point comparison? It should probably be changed into following or something along the line:

abs(t_sec) < 1e-6

[Mr-Anyone]

Also, this class is really similar to the following class, maybe is worth while to combine it?

https://mr-anyone.github.io/Thunderbot_Software/classConstVelocityObstacle.html

[itsarune]

Why isn't there a compiler flag to check this?

[itsarune]

There is: -Wfloat-equal, we should also enable this on our code