Skip to content

Commit 96a3150

Browse files
vandenmantorfjelde
andauthored
initial_values: rename theta to flattened_param_vals (#673)
* theta -> flattened_param_vals * add unittest * Update test/sampler.jl --------- Co-authored-by: Tor Erlend Fjelde <tor.github@gmail.com>
1 parent 0e40bd0 commit 96a3150

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/sampler.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ function set_values!!(
150150
flattened_param_vals = varinfo[spl]
151151
length(flattened_param_vals) == length(initial_params) || throw(
152152
DimensionMismatch(
153-
"Provided initial value size ($(length(initial_params))) doesn't match the model size ($(length(theta)))",
153+
"Provided initial value size ($(length(initial_params))) doesn't match the model size ($(length(flattened_param_vals)))",
154154
),
155155
)
156156

test/sampler.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,9 @@
162162
chain1 = sample(model, sampler, 1; progress=false)
163163
Random.seed!(1234)
164164
chain2 = sample(model, sampler, 1; initial_params=nothing, progress=false)
165+
@test_throws DimensionMismatch sample(
166+
model, sampler, 1; progress=false, initial_params=zeros(10)
167+
)
165168
@test chain1[1].metadata.m.vals == chain2[1].metadata.m.vals
166169
@test chain1[1].metadata.s.vals == chain2[1].metadata.s.vals
167170

0 commit comments

Comments
 (0)