@turf/convex is broken for commonjs - concaveman is ESM

[syncush]

Concaveman v2.0.0 only supports ESM and drops support for commonjs.

Package.json of convex

  "dependencies": {
    "@turf/helpers": "^6.5.0",
    "@turf/meta": "^6.5.0",
    "concaveman": "*"
  },

suggestion, lock version of concaveman to v1.2.1 until turf drops support for commonjs

[slavik-pastushenko]

as a temporary solution, you can add the overrides section in your package.json:

"overrides": {
    "@turf/convex": {
      "concaveman": "1.2.1"
    }
  },

but yeah, it would be nice to fix it

[JamesLMilner]

@smallsaucepan would pinning this to 1.2.1 resolve this problem do you think?

[julian-castorena-eb]

Any update on this fix?

[filipemacedo]

Same problem here.

as a temporary solution, you can add the overrides section in your package.json:

"overrides": {
    "@turf/convex": {
      "concaveman": "1.2.1"
    }
  },

but yeah, it would be nice to fix it

Does not work using yarn

[mfedderly]

What version of @turf/convex are you using? It appears to be correctly pinned to 1.2.1 in @turf/convex@7.2.0.
PR here: https://github.com/Turfjs/turf/pull/2237/files#diff-e792a4d82bc9aacc82f7afdfbc0f18c4c599d68202be3a5a20bf0a77adb097a6R62

Edit: from the first comment I'm guessing 6.5.0.

[slavik-pastushenko]

Same problem here.

as a temporary solution, you can add the overrides section in your package.json:

"overrides": {
    "@turf/convex": {
      "concaveman": "1.2.1"
    }
  },

but yeah, it would be nice to fix it

Does not work using yarn

use resolutions for yarn: https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/#toc-how-to-use-it

[filipemacedo]

use resolutions for yarn: https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/#toc-how-to-use-it

Yeah, I tried using resolutions:

"resolutions": {
    "@turf/**/concaveman": "1.2.1"
  },

But Yarn still installs concaveman@2.0.0:

[4/4] Calculating file sizes...
=> Found "concaveman@2.0.0"
info Reasons this module exists
   - "_project_#api#@turf#turf#@turf#convex" depends on it
   - Hoisted from "_project_#api#@turf#turf#@turf#convex#concaveman"

So it looks like the resolution isn’t being applied correctly in this case.

[filipemacedo]

What version of @turf/convex are you using? It appears to be correctly pinned to 1.2.1 in @turf/convex@7.2.0. PR here: https://github.com/Turfjs/turf/pull/2237/files#diff-e792a4d82bc9aacc82f7afdfbc0f18c4c599d68202be3a5a20bf0a77adb097a6R62

Edit: from the first comment I'm guessing 6.5.0.

=> Found "@turf/convex@6.5.0"
info Reasons this module exists

• "project#api#@Turf#turf" depends on it
• Hoisted from "project#api#@Turf#turf#@Turf#convex"
• Hoisted from "project#api#@Turf#turf#@Turf#center-of-mass#@Turf#convex"

The package.json of node_modules/@turf/convex/package.json

"devDependencies": {
    "@types/concaveman": "*",
    "@types/tape": "*",
    "benchmark": "*",
    "glob": "*",
    "load-json-file": "*",
    "npm-run-all": "*",
    "tape": "*",
    "ts-node": "*",
    "tslint": "*",
    "typescript": "*",
    "write-json-file": "*"
  },
  "dependencies": {
    "@turf/helpers": "^6.5.0",
    "@turf/meta": "^6.5.0",
    "concaveman": "*"
  },

[filipemacedo]

I’ve updated to the latest version and fixed the problem. Thx