refactor(code): misc code cleanup

- Removed redundant codes
- Expression-bodied property
- Fixed naming convention issue

Author: seralaci

content/Controllers/WeatherController.cs

@@ -25,7 +25,8 @@ public IActionResult Forecasts([FromQuery(Name = "from")] int from = 0, [FromQue
             {
                 return BadRequest("You cannot have the 'to' parameter higher than 'from' parameter.");
             }
-            else if (from < 0)
+
+            if (from < 0)
             {
                 return BadRequest("You cannot go in the negative with the 'from' parameter");
             }

content/Models/WeatherForecast.cs

@@ -2,16 +2,12 @@ namespace Vue2Spa.Models
 {
     public class WeatherForecast
     {
-        public string DateFormatted { get; set; }
-        public int TemperatureC { get; set; }
+        public string DateFormatted { get; set; }        
+
         public string Summary { get; set; }
 
-        public int TemperatureF
-        {
-            get
-            {
-                return 32 + (int)(TemperatureC / 0.5556);
-            }
-        }
+        public int TemperatureC { get; set; }
+
+        public int TemperatureF => 32 + (int)(TemperatureC / 0.5556);
     }
 }

content/Providers/WeatherProviderFake.cs

@@ -7,8 +7,7 @@ namespace Vue2Spa.Providers
 {
     public class WeatherProviderFake : IWeatherProvider
     {
-        private string[] Summaries = new[]
-        {
+        private readonly string[] summaries = {
             "Freezing", "Bracing", "Chilly", "Cool", "Mild", "Warm", "Balmy", "Hot", "Sweltering", "Scorching"
         };
 
@@ -26,7 +25,7 @@ private void Initialize(int quantity)
             {
                 DateFormatted = DateTime.Now.AddDays(index).ToString("d"),
                 TemperatureC = rng.Next(-20, 55),
-                Summary = Summaries[rng.Next(Summaries.Length)]
+                Summary = summaries[rng.Next(summaries.Length)]
             }).ToList();
         }