use duration string instead of ms

Author: clinta

const.go

@@ -1,11 +1,15 @@
 package vxrouter
 
-// usefule constants for the whole project
+import (
+	"time"
+)
+
+// useful constants for the whole project
 const (
-	Version                   = "0.0.4"
-	EnvPrefix                 = "VXR_"
-	NetworkDriver             = "vxrNet"
-	IpamDriver                = "vxrIpam"
-	DefaultReqAddrSleepTimeMS = 100
-	DefaultRouteProto         = 192
+	Version                 = "0.0.5"
+	EnvPrefix               = "VXR_"
+	NetworkDriver           = "vxrNet"
+	IpamDriver              = "vxrIpam"
+	DefaultReqAddrSleepTime = 100 * time.Millisecond
+	DefaultRouteProto       = 192
 )

funcs.go

@@ -3,16 +3,22 @@ package vxrouter
 import (
 	"os"
 	"strconv"
+	"time"
 
 	log "github.com/Sirupsen/logrus"
 )
 
-// GetEnvIntWithDefault gets value, prioritizing first opt, if it is not empty, then the environment variable specified by val, and lastly the default.
-func GetEnvIntWithDefault(val, opt string, def int) int { //nolint: unparam
+func getEnvOpt(val, opt string) string { //nolint: unparam
 	e := os.Getenv(val)
 	if e == "" {
 		e = opt
 	}
+	return e
+}
+
+// GetEnvIntWithDefault gets value, prioritizing first opt, if it is not empty, then the environment variable specified by val, and lastly the default.
+func GetEnvIntWithDefault(val, opt string, def int) int { //nolint: unparam
+	e := getEnvOpt(val, opt)
 	if e == "" {
 		return def
 	}
@@ -23,3 +29,17 @@ func GetEnvIntWithDefault(val, opt string, def int) int { //nolint: unparam
 	}
 	return ei
 }
+
+// GetEnvDurWithDefault gets value, prioritizing first opt, if it is not empty, then the environment variable specified by val, and lastly the default.
+func GetEnvDurWithDefault(val, opt string, def time.Duration) time.Duration { //nolint: unparam
+	e := getEnvOpt(val, opt)
+	if e == "" {
+		return def
+	}
+	ei, err := time.ParseDuration(e)
+	if err != nil {
+		log.WithField("string", e).WithError(err).Warnf("failed to convert string to duration, using default")
+		return def
+	}
+	return ei
+}

host/interface.go

@@ -19,7 +19,7 @@ var (
 	rwm              = make(map[string]*sync.RWMutex)
 	rwmLock          sync.Mutex
 	routeProto       = vxrouter.GetEnvIntWithDefault(vxrouter.EnvPrefix+"ROUTE_PROTO", "", vxrouter.DefaultRouteProto)
-	reqAddrSleepTime = time.Duration(vxrouter.GetEnvIntWithDefault(vxrouter.EnvPrefix+"REQ_ADDR_SLEEP", "", vxrouter.DefaultReqAddrSleepTimeMS)) * time.Millisecond
+	reqAddrSleepTime = vxrouter.GetEnvDurWithDefault(vxrouter.EnvPrefix+"REQ_ADDR_SLEEP", "", vxrouter.DefaultReqAddrSleepTime)
 )
 
 // Interface holds a vxlan and a host macvlan interface used for the gateway interface on a container network