Skip to content

Commit 686af0c

Browse files
committed
when canvas and mermaid are inserted using "include note", we insert them as images
1 parent d07f02b commit 686af0c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/public/app/widgets/dialogs/include_note.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export default class IncludeNoteDialog extends BasicWidget {
9797

9898
const boxSize = $("input[name='include-note-box-size']:checked").val();
9999

100-
if (note.type === 'image') {
100+
if (['image', 'canvas', 'mermaid'].includes(note.type)) {
101101
// there's no benefit to use insert note functionlity for images,
102102
// so we'll just add an IMG tag
103103
this.textTypeWidget.addImage(noteId);

src/public/app/widgets/type_widgets/editable_text.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,9 +368,7 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
368368
const encodedTitle = encodeURIComponent(note.title);
369369
const src = `api/images/${note.noteId}/${encodedTitle}`;
370370

371-
const imageElement = writer.createElement( 'image', { 'src': src } );
372-
373-
this.watchdog.editor.model.insertContent(imageElement, this.watchdog.editor.model.document.selection);
371+
this.watchdog.editor.execute( 'insertImage', { source: src } );
374372
} );
375373
}
376374

0 commit comments

Comments
 (0)