Skip to content

Commit f3a6fa4

Browse files
committed
fix(eslint-config): real life usage fixes
1 parent 87e3814 commit f3a6fa4

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

packages/eslint-config/src/subconfigs/basic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ export default [
189189
SwitchCase: 1
190190
}
191191
],
192-
'@stylistic/indent-binary-ops': ['error', 2],
192+
'@stylistic/indent-binary-ops': 'off',
193193
'@stylistic/jsx-quotes': ['error', 'prefer-single'],
194194
'@stylistic/key-spacing': [
195195
'error',

packages/eslint-config/src/subconfigs/jsdoc.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ export default [
3535
{
3636
files: tsFiles,
3737
rules: {
38-
'jsdoc/no-types': 'warn'
38+
'jsdoc/no-types': 'warn',
39+
'jsdoc/require-param': 'off',
40+
'jsdoc/check-param-names': 'off'
3941
}
4042
}
4143
]

packages/eslint-config/src/subconfigs/react.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ export default [
104104
'@stylistic/jsx-equals-spacing': 'error',
105105
'@stylistic/jsx-first-prop-new-line': ['error', 'multiline'],
106106
'react/jsx-fragments': 'error',
107-
'@stylistic/jsx-indent': ['error', 2],
108107
'@stylistic/jsx-indent-props': ['error', 2],
109108
'react/jsx-key': 'error',
110109
'@stylistic/jsx-max-props-per-line': [

packages/eslint-config/src/subconfigs/typescript.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
import typescriptPlugin from '@typescript-eslint/eslint-plugin'
66
import stylisticPlugin from '@stylistic/eslint-plugin'
77
import { getExtensionRules } from './utils.js'
8-
import { dtsFiles } from './files.js'
8+
import {
9+
tsFiles,
10+
dtsFiles
11+
} from './files.js'
912

1013
export default [
1114
{
@@ -156,7 +159,6 @@ export default [
156159
allowDefinitionFiles: true
157160
}
158161
],
159-
'@typescript-eslint/no-require-imports': 'error',
160162
'@typescript-eslint/no-this-alias': [
161163
'error',
162164
{
@@ -187,6 +189,12 @@ export default [
187189
'@typescript-eslint/no-dupe-class-members': 'error'
188190
}
189191
},
192+
{
193+
files: tsFiles,
194+
rules: {
195+
'@typescript-eslint/no-require-imports': 'error'
196+
}
197+
},
190198
{
191199
files: dtsFiles,
192200
rules: {

0 commit comments

Comments
 (0)