Skip to content

Commit d69c837

Browse files
author
travis
committed
Added validations to display_columns variable
Now validating that display_columns is set and preventing it from failing if it is nil. This addresses first issue identified in #12
1 parent e35713d commit d69c837

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

app/views/settings/_spent_time_settings.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
<tr>
3030
<th> <%= t("plugin_spent_time_in_issue.display_cols") %> </th>
3131
<td>
32-
<select name="settings[display_columns][]" multiple style="width: 75px; height: 75px;">
32+
<select name="settings[display_columns][]" multiple style="width: 75px; height: 75px;" class="required">
3333
<% %w( spentOn user hours comments activity).each do |column| %>
34-
<option value="<%= column %>" <%= ( settings['display_columns'].include? column) ? "Selected" : "" %>><%= t("plugin_spent_time_in_issue."<< column )%></option>
34+
<option value="<%= column %>" <%= ( ( settings['display_columns'] || '').include? column) ? "Selected" : "" %>><%= t("plugin_spent_time_in_issue."<< column )%></option>
3535
<% end %>
3636
</select>
3737
</td>

0 commit comments

Comments
 (0)