corrections after rubocop

corrected method naming conventions  and cleaned up syntax.

Author: travis

app/views/issues/_floating_report.html.erb

@@ -2,13 +2,13 @@
   <h3>Spent Time Report</h3>
 
   <% @issue.time_entries.last( Setting.plugin_redmine_spent_time_in_issue_description['spent_time_max_display'].to_i ).each_with_index do |entry, index| %>
-    <div class="spenttimeentry <%= ( index % 2 == 0 ? "even" : "odd" ) %>">
+    <div class="spenttimeentry <%= (index % 2 == 0 ? "even" : "odd") %>">
       <p>
-        <%= content_tag(:span, entry.spent_on.strftime("%m/%d/%Y") ) if is_spent_on_shown( entry ) %>
-        <%= content_tag(:span, link_to_user( entry.user )) if is_user_shown( entry ) %>
-        <%= content_tag(:span, entry.activity ) if is_activity_shown( entry ) %>
-        <%= content_tag(:span, report_time_spent( entry ) ) if is_report_time_shown( entry ) %>
-        <%=raw "<br />" <<  content_tag(:span, entry.comments ) if is_comment_shown( entry ) %>
+        <%= content_tag(:span, entry.spent_on.strftime("%m/%d/%Y")) if spent_on_shown? %>
+        <%= content_tag(:span, link_to_user(entry.user)) if user_shown? %>
+        <%= content_tag(:span, entry.activity) if activity_shown? %>
+        <%= content_tag(:span, report_time_spent(entry)) if report_time_shown? %>
+        <%=raw "<br />" <<  content_tag(:span, entry.comments) if comment_shown? %>
       </p>
     </div>
   <% end %>

app/views/issues/_time_spent_report.html.erb

@@ -15,11 +15,11 @@
   <tbody>
     <% @issue.time_entries.last( Setting.plugin_redmine_spent_time_in_issue_description['spent_time_max_display'].to_i ).each do |entry| %>
       <tr>
-        <%= content_tag(:td, entry.spent_on.strftime("%m/%d/%Y") ) if is_spent_on_shown( entry ) %>
-        <%= content_tag(:td, link_to_user( entry.user )) if is_user_shown( entry ) %>
-        <%= content_tag(:td, report_time_spent( entry ) ) if is_report_time_shown( entry ) %>
-        <%= content_tag(:td, entry.comments ) if is_comment_shown( entry ) %>
-        <%= content_tag(:td, entry.activity ) if is_activity_shown( entry ) %>
+        <%= content_tag(:td, entry.spent_on.strftime("%m/%d/%Y") ) if spent_on_shown? %>
+        <%= content_tag(:td, link_to_user( entry.user )) if user_shown? %>
+        <%= content_tag(:td, report_time_spent(entry) ) if report_time_shown? %>
+        <%= content_tag(:td, entry.comments ) if comment_shown? %>
+        <%= content_tag(:td, entry.activity ) if activity_shown? %>
       </tr>
     <% end %>
   </tbody>

lib/issue_helper_patch.rb

@@ -1,61 +1,66 @@
+# Helper Patch to be include in Issue Helper
 module IssuesHelperPatch
-
   def self.included(base) # :nodoc:
     base.send(:include, InstanceMethods)
   end
 
+  # Helper provides shorter conditional calls and humanized_time format
   module InstanceMethods
-
     def humanized_time(entry_hours)
       hours = entry_hours.to_i
       minutes = entry_hours * 60
-      minutes = (minutes - hours * 60 ).to_i
+      minutes = (minutes - hours * 60).to_i
 
-      time_spent = case
-      when hours == 1
-        t('plugin_spent_time_in_issue.datetime.hours.one')
-      when hours > 1
-        t('plugin_spent_time_in_issue.datetime.hours.other', hours: hours)
-      else
-        ""
-      end
+      time_spent = humanized_hour(hours)
+      time_spent << ' ' << humanized_minute(minutes) unless minutes < 1
+    end
+  end
 
-      if minutes == 1
-        time_spent << " " << t('plugin_spent_time_in_issue.datetime.minutes.one')
-      elsif minutes > 1
-        time_spent << " " << t('plugin_spent_time_in_issue.datetime.minutes.other', minutes: minutes)
-      else
-        time_spent
-      end
+  def humanized_hour(hours)
+    if hours == 1
+      t('plugin_spent_time_in_issue.datetime.hours.one')
+    elsif hours > 1
+      t('plugin_spent_time_in_issue.datetime.hours.other', hours: hours)
+    else
+      ''
     end
+  end
 
+  def humanized_minute(minutes)
+    if minutes == 1
+      ' ' << t('plugin_spent_time_in_issue.datetime.minutes.one')
+    elsif minutes > 1
+      ' ' << t('plugin_spent_time_in_issue.datetime.minutes.other', minutes: minutes)
+    else
+      ''
+    end
   end
 
   def report_time_spent(entry)
-    if Setting.plugin_redmine_spent_time_in_issue_description['time_format'].eql? "human"
-      time_spent = humanized_time( entry.hours )
+    if Setting.plugin_redmine_spent_time_in_issue_description['time_format'].eql? 'human'
+      humanized_time(entry.hours)
     else
-      time_spent = entry.hours
+      entry.hours
     end
   end
 
-  def is_report_time_shown( entry )
+  def report_time_shown?
     Setting.plugin_redmine_spent_time_in_issue_description['display_columns'].include? 'hours'
   end
 
-  def is_spent_on_shown( entry )
+  def spent_on_shown?
     Setting.plugin_redmine_spent_time_in_issue_description['display_columns'].include? 'spentOn'
   end
 
-  def is_user_shown( entry )
+  def user_shown?
     Setting.plugin_redmine_spent_time_in_issue_description['display_columns'].include? 'user'
   end
 
-  def is_comment_shown( entry )
+  def comment_shown?
     Setting.plugin_redmine_spent_time_in_issue_description['display_columns'].include? 'comments'
   end
 
-  def is_activity_shown( entry )
+  def activity_shown?
     Setting.plugin_redmine_spent_time_in_issue_description['display_columns'].include? 'activity'
   end