Skip to content

[Nu-7983] Improve FragmentParameterTypingParser #7985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 28, 2025
Merged

[Nu-7983] Improve FragmentParameterTypingParser #7985

merged 8 commits into from
Apr 28, 2025

Conversation

DeamonDev
Copy link
Contributor

@DeamonDev DeamonDev commented Apr 24, 2025 •
edited
Loading

Describe your changes

closes #7983

image

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Sorry, something went wrong.

@DeamonDev DeamonDev self-assigned this Apr 24, 2025
@DeamonDev DeamonDev force-pushed the nu-7983-expand-fragment-parameter-typing-parser branch 2 times, most recently from e28fb3b to 61bd46b Compare April 25, 2025 08:44
@DeamonDev DeamonDev force-pushed the nu-7983-expand-fragment-parameter-typing-parser branch from 61bd46b to 799363c Compare April 26, 2025 16:08
gskrobisz
gskrobisz approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@gskrobisz gskrobisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DeamonDev DeamonDev merged commit a97109c into staging Apr 28, 2025
18 checks passed
@DeamonDev DeamonDev deleted the nu-7983-expand-fragment-parameter-typing-parser branch April 28, 2025 09:02
DeamonDev added a commit that referenced this pull request Apr 28, 2025
@DeamonDev
[Nu-7983] Improve FragmentParameterTypingParser (#7985)
82a154e 
* [Nu-7983] Improve FragmentParameterTypingParser

* [Nu-7983] Add test for unbalanced brackets

* [Nu-7983] Remove redundant implicit dependency

* [Nu-7983] Add even more test

* [Nu-7983] Optimize imports

* [Nu-7983] Simple rename

* [Nu-7983] Reorder parsers in code

* [Nu-7983] Add one more test
DeamonDev added a commit that referenced this pull request Apr 28, 2025
@DeamonDev
[Nu-7983] Improve FragmentParameterTypingParser (#7985) (#7999)
e59ca75 
* [Nu-7983] Improve FragmentParameterTypingParser

* [Nu-7983] Add test for unbalanced brackets

* [Nu-7983] Remove redundant implicit dependency

* [Nu-7983] Add even more test

* [Nu-7983] Optimize imports

* [Nu-7983] Simple rename

* [Nu-7983] Reorder parsers in code

* [Nu-7983] Add one more test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gskrobisz gskrobisz

Assignees

@DeamonDev DeamonDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand fragment input definition parser to work with nested types
2 participants
@DeamonDev @gskrobisz