async_load -> load_async

Author: TomNicholas

xarray/core/dataarray.py

@@ -1160,9 +1160,9 @@ def load(self, **kwargs) -> Self:
         self._coords = new._coords
         return self
 
-    async def async_load(self, **kwargs) -> Self:
+    async def load_async(self, **kwargs) -> Self:
         temp_ds = self._to_temp_dataset()
-        ds = await temp_ds.async_load(**kwargs)
+        ds = await temp_ds.load_async(**kwargs)
         new = self._from_temp_dataset(ds)
         self._variable = new._variable
         self._coords = new._coords

xarray/core/dataset.py

@@ -552,7 +552,7 @@ def load(self, **kwargs) -> Self:
 
         return self
 
-    async def async_load(self, **kwargs) -> Self:
+    async def load_async(self, **kwargs) -> Self:
         # this blocks on chunked arrays but not on lazily indexed arrays
 
         # access .data to coerce everything to numpy or dask arrays
@@ -573,7 +573,7 @@ async def async_load(self, **kwargs) -> Self:
         # load everything else sequentially
         for k, v in self.variables.items():
             if k not in lazy_data:
-                await v.async_load()
+                await v.load_async()
 
         return self
 

xarray/core/variable.py

@@ -958,7 +958,7 @@ def load(self, **kwargs):
         self._data = to_duck_array(self._data, **kwargs)
         return self
 
-    async def async_load(self, **kwargs):
+    async def load_async(self, **kwargs):
         print("async inside Variable")
         self._data = await async_to_duck_array(self._data, **kwargs)
         return self

xarray/tests/test_async.py

@@ -146,9 +146,8 @@ def assert_time_as_expected(self, total_time: float) -> None:
         )  # Should take approximately LATENCY seconds, but allow some buffer
 
     async def test_async_load(self, xr_obj):
-        # TODO change the syntax to `.async.load()`?
         async with AsyncTimer().measure() as timer:
-            tasks = [xr_obj.async_load() for _ in range(self.N_LOADS)]
+            tasks = [xr_obj.load_async() for _ in range(self.N_LOADS)]
             results = await asyncio.gather(*tasks)
 
         for result in results: