chore(toxav): use realtime deadline for vp8 encoder #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
Green-Sky
commented
Mar 30, 2025
toxav/toxav.c
Outdated
| @@ -1086,8 +1075,11 @@ bool toxav_video_send_frame(ToxAV *av, uint32_t friend_number, uint16_t width, u | |||
| memcpy(img.planes[VPX_PLANE_U], u, (width / 2) * (height / 2)); | |||
| memcpy(img.planes[VPX_PLANE_V], v, (width / 2) * (height / 2)); | |||
|
|
|||
| // TODO(zoff99): don't hardcode this, let the application choose it | |||
| const vpx_enc_deadline_t deadline = VPX_DL_REALTIME; | |||
There was a problem hiding this comment.
@zoff99 should we just remove this line + the todo?
Green-Sky
force-pushed
the
toxav_deadline
branch
from
865261a to
6f16b5f
Compare
Technically all this does is choose a quality based on frame duration, which we always set to 1, and as such is always realtime. (In same timebase as pts, which we use as a frame counter...) Also no deadline for decoder. (documentation tells us its ignored)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically all this does is choose a quality based on frame duration, which we always set to 1, and as such is always realtime. (In same timebase as pts, which we use as a frame counter...)
Also no deadline for decoder. (documentation tells us it's ignored)
fixes #2770
This change is