-
-
Notifications
You must be signed in to change notification settings - Fork 91
Fix RSS Headers #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSS Headers #1268
Conversation
Better to have it in the configuration file as default for those who need it than hardcoded in the code. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
Add client user headers to RSS client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is breaking ToS. Sorry, we cannot use this feed if they do not allow it to be called by bot (without pretending to not be a bot). |
Have we tested to see if it works with this user agent and the bot can successfully get a response without a 403? |
Yeah, this one works (and is conform with RFC on how a User-Agent for bots has to look like) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For some reason oracle decides to block "bots" from automatically reading RSS feeds unless certain headers and user agents are provided. 🙄
We are now sending
TJ-Bot/1.0 (+https://github.com/Together-Java/TJ-Bot)
as user-agent (conform with RFC for bots) and that works. Also checked theirrobots.txt
and seems we are good to go.