Skip to content

Fix RSS Headers #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2025
Merged

Fix RSS Headers #1268

merged 6 commits into from
Jun 30, 2025

Conversation

pot
Copy link
Contributor

@pot pot commented Jun 30, 2025

For some reason oracle decides to block "bots" from automatically reading RSS feeds unless certain headers and user agents are provided. 🙄

We are now sending TJ-Bot/1.0 (+https://github.com/Together-Java/TJ-Bot) as user-agent (conform with RFC for bots) and that works. Also checked their robots.txt and seems we are good to go.

pot and others added 4 commits June 29, 2025 22:32
Better to have it in the configuration file as default for those who
need it than hardcoded in the code.

Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
Add client user headers to RSS client
@pot pot requested a review from a team as a code owner June 30, 2025 06:12
@christolis christolis added the config-changes if your PR contains any changes related to config file label Jun 30, 2025
christolis
christolis previously approved these changes Jun 30, 2025
Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zabuzard
Copy link
Member

This is breaking ToS. Sorry, we cannot use this feed if they do not allow it to be called by bot (without pretending to not be a bot).

@Zabuzard Zabuzard closed this Jun 30, 2025
@christolis
Copy link
Member

Have we tested to see if it works with this user agent and the bot can successfully get a response without a 403?

@Zabuzard Zabuzard added bug Something isn't working and removed config-changes if your PR contains any changes related to config file labels Jun 30, 2025
@Zabuzard
Copy link
Member

Have we tested to see if it works with this user agent and the bot can successfully get a response without a 403?

Yeah, this one works (and is conform with RFC on how a User-Agent for bots has to look like)

Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zabuzard Zabuzard merged commit 3bc3e7c into Together-Java:develop Jun 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants