refactor MarkHelpThreadCloseInDBRoutine and changes

* update constructor with HelpThreadLifecycleListener instance
* using HelpThreadLifecycleListener method to clean up left over threads
* increasing scope of handleArchiveStatus to package level
* adding logger to MarkHelpThreadCloseInDBRoutine class

Author: ankitsmt211

application/src/main/java/org/togetherjava/tjbot/features/Features.java

@@ -88,6 +88,8 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
                 new CodeMessageHandler(blacklistConfig.special(), jshellEval);
         ChatGptService chatGptService = new ChatGptService(config);
         HelpSystemHelper helpSystemHelper = new HelpSystemHelper(config, database, chatGptService);
+        HelpThreadLifecycleListener helpThreadLifecycleListener =
+                new HelpThreadLifecycleListener(helpSystemHelper, database);
 
         // NOTE The system can add special system relevant commands also by itself,
         // hence this list may not necessarily represent the full list of all commands actually
@@ -106,7 +108,7 @@ public static Collection<Feature> createFeatures(JDA jda, Database database, Con
             .add(new AutoPruneHelperRoutine(config, helpSystemHelper, modAuditLogWriter, database));
         features.add(new HelpThreadAutoArchiver(helpSystemHelper));
         features.add(new LeftoverBookmarksCleanupRoutine(bookmarksSystem));
-        features.add(new MarkHelpThreadCloseInDBRoutine(database));
+        features.add(new MarkHelpThreadCloseInDBRoutine(database, helpThreadLifecycleListener));
 
         // Message receivers
         features.add(new TopHelpersMessageListener(database, config));

application/src/main/java/org/togetherjava/tjbot/features/help/HelpThreadLifecycleListener.java

@@ -79,7 +79,7 @@ private void handleThreadStatus(ThreadChannel threadChannel) {
         changeStatusToActive(threadId);
     }
 
-    private void handleArchiveStatus(Instant closedAt, ThreadChannel threadChannel) {
+    void handleArchiveStatus(Instant closedAt, ThreadChannel threadChannel) {
         long threadId = threadChannel.getIdLong();
         int messageCount = threadChannel.getMessageCount();
         int participantsExceptAuthor = threadChannel.getMemberCount() - 1;

application/src/main/java/org/togetherjava/tjbot/features/help/MarkHelpThreadCloseInDBRoutine.java

@@ -1,12 +1,17 @@
 package org.togetherjava.tjbot.features.help;
 
 import net.dv8tion.jda.api.JDA;
+import net.dv8tion.jda.api.entities.channel.concrete.ThreadChannel;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import org.togetherjava.tjbot.db.Database;
+import org.togetherjava.tjbot.db.generated.tables.records.HelpThreadsRecord;
 import org.togetherjava.tjbot.features.Routine;
 
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
+import java.util.List;
 import java.util.concurrent.TimeUnit;
 
 import static org.togetherjava.tjbot.db.generated.tables.HelpThreads.HELP_THREADS;
@@ -16,36 +21,49 @@
  * closed.
  */
 public final class MarkHelpThreadCloseInDBRoutine implements Routine {
+    private final Logger logger = LoggerFactory.getLogger(MarkHelpThreadCloseInDBRoutine.class);
     private final Database database;
+    private final HelpThreadLifecycleListener helpThreadLifecycleListener;
 
     /**
      * Creates a new instance.
      *
      * @param database the database to store help thread metadata in
      */
-    public MarkHelpThreadCloseInDBRoutine(Database database) {
+    public MarkHelpThreadCloseInDBRoutine(Database database,
+            HelpThreadLifecycleListener helpThreadLifecycleListener) {
         this.database = database;
+        this.helpThreadLifecycleListener = helpThreadLifecycleListener;
     }
 
-
     @Override
     public Schedule createSchedule() {
         return new Schedule(ScheduleMode.FIXED_RATE, 0, 1, TimeUnit.HOURS);
     }
 
     @Override
     public void runRoutine(JDA jda) {
-        updateTicketStatus();
+        updateTicketStatus(jda);
     }
 
-    private void updateTicketStatus() {
+    private void updateTicketStatus(JDA jda) {
         Instant now = Instant.now();
         Instant threeDaysAgo = now.minus(3, ChronoUnit.DAYS);
+        List<Long> threadIdsToClose = database.read(context -> context.selectFrom(HELP_THREADS)
+            .where(HELP_THREADS.TICKET_STATUS.eq(HelpSystemHelper.TicketStatus.ACTIVE.val))
+            .and(HELP_THREADS.CREATED_AT.lessThan(threeDaysAgo))
+            .stream()
+            .map(HelpThreadsRecord::getChannelId)
+            .toList());
+
 
-        database.write(context -> context.update(HELP_THREADS)
-            .set(HELP_THREADS.TICKET_STATUS, HelpSystemHelper.TicketStatus.ARCHIVED.val)
-            .where(HELP_THREADS.CREATED_AT.lessOrEqual(threeDaysAgo)
-                .and(HELP_THREADS.TICKET_STATUS.eq(HelpSystemHelper.TicketStatus.ACTIVE.val)))
-            .execute());
+        threadIdsToClose.forEach(id -> {
+            try {
+                ThreadChannel threadChannel = jda.getThreadChannelById(id);
+                helpThreadLifecycleListener.handleArchiveStatus(now, threadChannel);
+            } catch (Exception exception) {
+                logger.warn("unable to mark thread as close with id :{}", id, exception);
+            }
+        });
     }
 }