Understanding the ACL functions

[Arlen22]

I'm having trouble understanding the ACL functions which @webplusai has contributed to MWS.

The main problem I'm running into is that there are some inconsistencies in the acl code which typescript catches, but they appear to be actual bugs and not just typing problems.

Is the bags table missing an owner_id column? Some of the code seems to indicate that.

The ACL concept that I'm seeing seems pretty good. I'm just going through and converting everything into consistent and repeatable patterns that are easier to maintain.

---

extra notes

Diff between the PR branch and MWS

Diff in the opposite direction

PRs by webplusai

Commits by webplusai

Turns out the VSCode source control graph appears to be the most useful.

The main commits starting with the first ACL commit appear to be:

• Attachments
• ACL & users
• documentation
• a bunch of "noise" caused by merging in from master, which the VS code source control graph separates out beautifully.

Based on that, it seems that the most important comparison is between the multiwikiserver plugin folder then and now.

handler files changed by acl (besides several adding useAcl and entityType)

• /plugins/server/modules/routes/handlers/get-recipe-tiddler.js
• /plugins/server/modules/routes/handlers/post-recipe.js

created files