Merge pull request Codeception#6027 from mwi-gofore/4.1

Prepend backslash on class constant default values

Author: Naktibalda

src/Codeception/Util/ReflectionHelper.php

@@ -115,6 +115,8 @@ public static function getDefaultValue(ReflectionParameter $param)
                     list($class, $const) = explode('::', $constName);
                     if (in_array($class, ['self', 'static'])) {
                         $constName = '\\' . $param->getDeclaringClass()->getName() . '::' . $const;
+                    } elseif (substr($class, 0, 1) !== '\\') {
+                        $constName = '\\' . $constName;
                     }
                 }
 

tests/unit/Codeception/Util/ReflectionHelperTest.php

@@ -112,6 +112,11 @@ public function testGetDefaultValue()
             ReflectionHelper::getDefaultValue(new ReflectionParameter(array($object, 'setDebug'), 'flavor'))
         );
 
+        $this->assertEquals(
+            '\Codeception\Codecept::VERSION',
+            ReflectionHelper::getDefaultValue(new ReflectionParameter(array($object, 'setFlavorImportedDefault'), 'flavor'))
+        );
+
         $this->assertEquals(
             PHP_VERSION_ID < 70100 ? 'null' : "''",
             ReflectionHelper::getDefaultValue(new ReflectionParameter(array($object, 'setValue'), 0))

tests/unit/Codeception/Util/ReflectionTestClass56.php

@@ -1,6 +1,8 @@
 <?php
 namespace Codeception\Util;
 
+use Codeception\Codecept;
+
 class ReflectionTestClass
 {
     const FOO = 'bar';
@@ -48,6 +50,11 @@ static public function setFlavor($flavor = self::FOO)
         self::$flavorOfTheWeek = $flavor;
     }
 
+    public function setFlavorImportedDefault($flavor = Codecept::VERSION)
+    {
+        self::$flavorOfTheWeek = $flavor;
+    }
+
     private function getSecret($s)
     {
         return sprintf("I'm a %s!", $s);

tests/unit/Codeception/Util/ReflectionTestClass70.php

@@ -1,6 +1,8 @@
 <?php
 namespace Codeception\Util;
 
+use Codeception\Codecept;
+
 class ReflectionTestClass
 {
     const FOO = 'bar';
@@ -43,7 +45,12 @@ public function setDebug(Debug $obj, $flavor = self::FOO): self
         return $this;
     }
 
-    static public function setFlavor(string $flavor = self::FOO)
+    static public function setFlavor(string $flavor = self::FOO): void
+    {
+        self::$flavorOfTheWeek = $flavor;
+    }
+
+    public function setFlavorImportedDefault(string $flavor = Codecept::VERSION): void
     {
         self::$flavorOfTheWeek = $flavor;
     }