Merge pull request Codeception#6138 from Codeception/4.1-remove-DataProviderTestSuite-conditions

4.1 Remove dead DataProviderTestSuite code

Author: Naktibalda

src/Codeception/Command/DryRun.php

@@ -85,13 +85,6 @@ public function execute(InputInterface $input, OutputInterface $output)
         $this->dispatch($dispatcher, Events::SUITE_INIT, new SuiteEvent($suiteManager->getSuite(), null, $settings));
         $this->dispatch($dispatcher, Events::SUITE_BEFORE, new SuiteEvent($suiteManager->getSuite(), null, $settings));
         foreach ($tests as $test) {
-            if ($test instanceof \PHPUnit\Framework\DataProviderTestSuite) {
-                foreach ($test as $t) {
-                    if ($t instanceof Test) {
-                        $this->dryRunTest($output, $dispatcher, $t);
-                    }
-                }
-            }
             if ($test instanceof Test and $test instanceof ScenarioDriven) {
                 $this->dryRunTest($output, $dispatcher, $test);
             }

src/Codeception/Lib/GroupManager.php

@@ -149,13 +149,6 @@ public function groupsForTest(\PHPUnit\Framework\Test $test)
         if ($test instanceof \PHPUnit\Framework\TestCase) {
             $groups = array_merge($groups, \PHPUnit\Util\Test::getGroups(get_class($test), $test->getName(false)));
         }
-        if ($test instanceof \PHPUnit\Framework\DataProviderTestSuite) {
-            $firstTest = $test->testAt(0);
-            if ($firstTest != false && $firstTest instanceof TestInterface) {
-                $groups = array_merge($groups, $firstTest->getMetadata()->getGroups());
-                $filename = Descriptor::getTestFileName($firstTest);
-            }
-        }
 
         foreach ($this->testsInGroups as $group => $tests) {
             foreach ($tests as $testPattern) {
@@ -169,14 +162,6 @@ public function groupsForTest(\PHPUnit\Framework\Test $test)
                     && mb_strtolower($filename . ':' . $test->getMetadata()->getFeature()) === mb_strtolower($testPattern)) {
                     $groups[] = $group;
                 }
-                if ($test instanceof \PHPUnit\Framework\DataProviderTestSuite) {
-                    $firstTest = $test->testAt(0);
-                    if ($firstTest != false && $firstTest instanceof TestInterface) {
-                        if (strpos($filename . ':' . $firstTest->getName(false), $testPattern) === 0) {
-                            $groups[] = $group;
-                        }
-                    }
-                }
             }
         }
         return array_unique($groups);

src/Codeception/Subscriber/BeforeAfterTest.php

@@ -22,11 +22,6 @@ public function beforeClass(SuiteEvent $e)
     {
         foreach ($e->getSuite()->tests() as $test) {
             /** @var $test \PHPUnit\Framework\Test  * */
-            if ($test instanceof \PHPUnit\Framework\DataProviderTestSuite) {
-                $potentialTestClass = strstr($test->getName(), '::', true);
-                $this->hooks[$potentialTestClass] = \PHPUnit\Util\Test::getHookMethods($potentialTestClass);
-            }
-
             $testClass = get_class($test);
             $this->hooks[$testClass] = \PHPUnit\Util\Test::getHookMethods($testClass);
         }

tests/cli/DryRunCest.php

@@ -10,6 +10,8 @@ public function runCestWithExamples(CliGuy $I)
     {
         $I->executeCommand('dry-run scenario ExamplesCest --no-ansi');
         $I->seeInShellOutput('ExamplesCest: Files exists annotation');
+        $I->seeInShellOutput('I see file found "scenario.suite.yml"');
+        $I->seeInShellOutput('I see file found "dummy.suite.yml"');
     }
 
     public function runFeature(CliGuy $I)