[GEN][ZH] Fix infinite loop in ParticleSystemManager::update (#877)

Author: Caball009

Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp

@@ -3036,21 +3036,19 @@ void ParticleSystemManager::update( void )
 	m_lastLogicFrameUpdate = TheGameLogic->getFrame();
 
 	//USE_PERF_TIMER(ParticleSystemManager)
-	ParticleSystem *sys;
-
-	for(ParticleSystemListIt it = m_allParticleSystemList.begin(); it != m_allParticleSystemList.end();) 
+	ParticleSystemListIt it = m_allParticleSystemList.begin(); 
+	while( it != m_allParticleSystemList.end() )  
 	{
-		sys = (*it);
+		// TheSuperHackers @info Must increment the list iterator before potential element erasure from the list.
+		ParticleSystem* sys = *it++;
+
 		if (!sys) {
 			continue;
 		}
 
 		if (sys->update(m_localPlayerIndex) == false)
 		{
-			++it;
 			deleteInstance(sys);
-		} else {
-			++it;
 		}
 	}
 }

GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp

@@ -2938,21 +2938,19 @@ void ParticleSystemManager::update( void )
 	m_lastLogicFrameUpdate = TheGameLogic->getFrame();
 
 	//USE_PERF_TIMER(ParticleSystemManager)
-	ParticleSystem *sys;
-
-	for(ParticleSystemListIt it = m_allParticleSystemList.begin(); it != m_allParticleSystemList.end();) 
+	ParticleSystemListIt it = m_allParticleSystemList.begin(); 
+	while( it != m_allParticleSystemList.end() )  
 	{
-		sys = (*it);
+		// TheSuperHackers @info Must increment the list iterator before potential element erasure from the list.
+		ParticleSystem* sys = *it++;
+
 		if (!sys) {
 			continue;
 		}
 
 		if (sys->update(m_localPlayerIndex) == false)
 		{
-			++it;
 			deleteInstance(sys);
-		} else {
-			++it;
 		}
 	}
 }