[GEN][ZH] Fix missing call to va_end in InGameUI::messageColor() (#872)

xezon · web-flow · commit f47115ff122c · 2025-05-17T12:24:58.000+02:00
diff --git a/Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp b/Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp
@@ -2025,6 +2025,7 @@ void InGameUI::messageColor( const RGBColor *rgbColor, UnicodeString format, ...
 	va_start( args, format );
 	WideChar buf[ UnicodeString::MAX_FORMAT_BUF_LEN ];
 	int result = _vsnwprintf(buf, sizeof( buf )/sizeof( WideChar ) - 1, format.str(), args );
+	va_end(args);
 
 	if( result >= 0 )
 	{
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp
@@ -2081,6 +2081,7 @@ void InGameUI::messageColor( const RGBColor *rgbColor, UnicodeString format, ...
 	va_start( args, format );
 	WideChar buf[ UnicodeString::MAX_FORMAT_BUF_LEN ];
 	int result = _vsnwprintf(buf, sizeof( buf )/sizeof( WideChar ) - 1, format.str(), args );
+	va_end(args);
 
 	if( result >= 0 )
 	{

Original file line number	Diff line number	Diff line change
`@@ -2025,6 +2025,7 @@ void InGameUI::messageColor( const RGBColor *rgbColor, UnicodeString format, ...`
`2025`	`2025`	`va_start( args, format );`
`2026`	`2026`	`WideChar buf[ UnicodeString::MAX_FORMAT_BUF_LEN ];`
`2027`	`2027`	`int result = _vsnwprintf(buf, sizeof( buf )/sizeof( WideChar ) - 1, format.str(), args );`
	`2028`	`+ va_end(args);`
`2028`	`2029`
`2029`	`2030`	`if( result >= 0 )`
`2030`	`2031`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2081,6 +2081,7 @@ void InGameUI::messageColor( const RGBColor *rgbColor, UnicodeString format, ...`
`2081`	`2081`	`va_start( args, format );`
`2082`	`2082`	`WideChar buf[ UnicodeString::MAX_FORMAT_BUF_LEN ];`
`2083`	`2083`	`int result = _vsnwprintf(buf, sizeof( buf )/sizeof( WideChar ) - 1, format.str(), args );`
	`2084`	`+ va_end(args);`
`2084`	`2085`
`2085`	`2086`	`if( result >= 0 )`
`2086`	`2087`	`{`