[GEN][ZH] Prevent using uninitialized memory 'delta' in Dict::ensureUnique() (#1131)

xezon · web-flow · commit da3346591cfd · 2025-06-22T08:44:33.000+02:00
diff --git a/Generals/Code/GameEngine/Source/Common/Dict.cpp b/Generals/Code/GameEngine/Source/Common/Dict.cpp
@@ -182,7 +182,7 @@ Dict::DictPair *Dict::ensureUnique(int numPairsNeeded, Bool preserveData, DictPa
 		}
 	}
 
-	Int delta;
+	Int delta = 0;
 	if (pairToTranslate && m_data)
 		delta = pairToTranslate - m_data->peek();
 
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/Dict.cpp b/GeneralsMD/Code/GameEngine/Source/Common/Dict.cpp
@@ -182,7 +182,7 @@ Dict::DictPair *Dict::ensureUnique(int numPairsNeeded, Bool preserveData, DictPa
 		}
 	}
 
-	Int delta;
+	Int delta = 0;
 	if (pairToTranslate && m_data)
 		delta = pairToTranslate - m_data->peek();
 

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ Dict::DictPair *Dict::ensureUnique(int numPairsNeeded, Bool preserveData, DictPa`
`182`	`182`	`}`
`183`	`183`	`}`
`184`	`184`
`185`		`- Int delta;`
	`185`	`+ Int delta = 0;`
`186`	`186`	`if (pairToTranslate && m_data)`
`187`	`187`	`delta = pairToTranslate - m_data->peek();`
`188`	`188`