Skip to content

Commit bbdfa50

Browse files
authored
[GEN][ZH] Prevent dereferencing NULL pointer 'font' in W3DFontLibrary::releaseFontData() (#1143)
1 parent 3e33df8 commit bbdfa50

File tree

2 files changed

+8
-6
lines changed
  • GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI
  • Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI

2 files changed

+8
-6
lines changed

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/W3DGameFont.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,11 @@ void W3DFontLibrary::releaseFontData( GameFont *font )
137137
if(((FontCharsClass *)(font->fontData))->AlternateUnicodeFont)
138138
((FontCharsClass *)(font->fontData))->AlternateUnicodeFont->Release_Ref();
139139
((FontCharsClass *)(font->fontData))->Release_Ref();
140+
141+
font->fontData = NULL;
140142
}
141-
font->fontData = NULL;
142-
143-
} // end releaseFont
143+
144+
} // end releaseFontData
144145

145146
// PUBLIC FUNCTIONS ///////////////////////////////////////////////////////////
146147

GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/W3DGameFont.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,11 @@ void W3DFontLibrary::releaseFontData( GameFont *font )
137137
if(((FontCharsClass *)(font->fontData))->AlternateUnicodeFont)
138138
((FontCharsClass *)(font->fontData))->AlternateUnicodeFont->Release_Ref();
139139
((FontCharsClass *)(font->fontData))->Release_Ref();
140+
141+
font->fontData = NULL;
140142
}
141-
font->fontData = NULL;
142-
143-
} // end releaseFont
143+
144+
} // end releaseFontData
144145

145146
// PUBLIC FUNCTIONS ///////////////////////////////////////////////////////////
146147

0 commit comments

Comments
 (0)