[GEN][ZH] Fix hollow BOX particles treated as LINE particles in ParticleSystem::computeParticlePosition() (#756)

OmniBlade · web-flow · commit b81f1b0b6c18 · 2025-06-08T08:23:38.000+02:00
A break statement was in the wrong scope leading to hollow boxes behaving as though they were line systems.
diff --git a/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp b/Generals/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp
@@ -1737,8 +1737,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void )
 				newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x );
 				newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y );
 				newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z );
-			break;
 			}
+			break;
 		}
 
 		case LINE:
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/System/ParticleSys.cpp
@@ -1637,8 +1637,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void )
 				newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x );
 				newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y );
 				newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z );
-			break;
 			}
+			break;
 		}
 
 		case LINE:

Original file line number	Diff line number	Diff line change
`@@ -1737,8 +1737,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void )`
`1737`	`1737`	`newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x );`
`1738`	`1738`	`newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y );`
`1739`	`1739`	`newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z );`
`1740`		`- break;`
`1741`	`1740`	`}`
	`1741`	`+ break;`
`1742`	`1742`	`}`
`1743`	`1743`
`1744`	`1744`	`case LINE:`
Original file line number	Diff line number	Diff line change
`@@ -1637,8 +1637,8 @@ const Coord3D *ParticleSystem::computeParticlePosition( void )`
`1637`	`1637`	`newPos.x = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.x, m_emissionVolume.box.halfSize.x );`
`1638`	`1638`	`newPos.y = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.y, m_emissionVolume.box.halfSize.y );`
`1639`	`1639`	`newPos.z = GameClientRandomValueReal( -m_emissionVolume.box.halfSize.z, m_emissionVolume.box.halfSize.z );`
`1640`		`- break;`
`1641`	`1640`	`}`
	`1641`	`+ break;`
`1642`	`1642`	`}`
`1643`	`1643`
`1644`	`1644`	`case LINE:`