[GEN][ZH] Fix Win32LocalFileSystem leaking file handlers when returning early on null filenames (#623)

Author: Mauller

Generals/Code/GameEngineDevice/Source/Win32Device/Common/Win32LocalFileSystem.cpp

@@ -45,7 +45,6 @@ Win32LocalFileSystem::~Win32LocalFileSystem() {
 File * Win32LocalFileSystem::openFile(const Char *filename, Int access /* = 0 */) 
 {
 	//USE_PERF_TIMER(Win32LocalFileSystem_openFile)
-	Win32LocalFile *file = newInstance( Win32LocalFile );	
 
 	// sanity check
 	if (strlen(filename) <= 0) {
@@ -69,6 +68,9 @@ File * Win32LocalFileSystem::openFile(const Char *filename, Int access /* = 0 */
 		}
 	}
 
+	// TheSuperHackers Mauller 21/04/2025 Only create the new file instance when it is necassary or we leak file handles!
+	Win32LocalFile *file = newInstance( Win32LocalFile );	
+
 	if (file->open(filename, access) == FALSE) {
 		file->close();
 		file->deleteInstance();

GeneralsMD/Code/GameEngineDevice/Source/Win32Device/Common/Win32LocalFileSystem.cpp

@@ -45,7 +45,6 @@ Win32LocalFileSystem::~Win32LocalFileSystem() {
 File * Win32LocalFileSystem::openFile(const Char *filename, Int access /* = 0 */) 
 {
 	//USE_PERF_TIMER(Win32LocalFileSystem_openFile)
-	Win32LocalFile *file = newInstance( Win32LocalFile );	
 
 	// sanity check
 	if (strlen(filename) <= 0) {
@@ -69,6 +68,9 @@ File * Win32LocalFileSystem::openFile(const Char *filename, Int access /* = 0 */
 		}
 	}
 
+	// TheSuperHackers Mauller 21/04/2025 Only create the new file instance when it is necassary or we leak file handles!
+	Win32LocalFile *file = newInstance( Win32LocalFile );	
+
 	if (file->open(filename, access) == FALSE) {
 		file->close();
 		file->deleteInstance();