Skip to content

Commit 1e9d67c

Browse files
committed
Update comments
1 parent 0d5825f commit 1e9d67c

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

Core/Libraries/Source/WWVegas/WWLib/DbgHelpGuard.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// This class temporarily loads and unloads dbghelp.dll from the desired location to prevent
2525
// other code from potentially loading it from an undesired location.
2626
// This helps avoid crashing on boot using recent AMD/ATI drivers, which attempt to load and use
27-
// dbghelp.dll from the game install directory but are unable to do so correctly because
27+
// dbghelp.dll from the game install directory but are unable to do so without crashing because
2828
// the dbghelp.dll that ships with the game is very old and the AMD/ATI code does not handle
2929
// that correctly.
3030

Generals/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ bool DX8Wrapper::Init(void * hwnd, bool lite)
314314
*/
315315
WWDEBUG_SAY(("Create Direct3D8\n"));
316316
{
317-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
317+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
318+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
318319
DbgHelpGuard dbgHelpGuard;
319320

320321
D3DInterface = Direct3DCreate8Ptr(D3D_SDK_VERSION); // TODO: handle failure cases...
@@ -568,7 +569,8 @@ bool DX8Wrapper::Create_Device(void)
568569

569570
HRESULT hr;
570571
{
571-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
572+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
573+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
572574
DbgHelpGuard dbgHelpGuard;
573575

574576
hr=D3DInterface->CreateDevice

GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,8 @@ bool DX8Wrapper::Init(void * hwnd, bool lite)
333333
*/
334334
WWDEBUG_SAY(("Create Direct3D8\n"));
335335
{
336-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
336+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
337+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
337338
DbgHelpGuard dbgHelpGuard;
338339

339340
D3DInterface = Direct3DCreate8Ptr(D3D_SDK_VERSION); // TODO: handle failure cases...
@@ -600,7 +601,8 @@ bool DX8Wrapper::Create_Device(void)
600601

601602
HRESULT hr;
602603
{
603-
// TheSuperHackers @bugfix xezon 13/06/2025 Temporarily unload dbghelp.dll and prevent it from loading.
604+
// TheSuperHackers @bugfix xezon 13/06/2025 Front load the system dbghelp.dll
605+
// to prevent the graphics driver from potentially loading the old game dbghelp.dll.
604606
DbgHelpGuard dbgHelpGuard;
605607

606608
hr=D3DInterface->CreateDevice

0 commit comments

Comments
 (0)