[GEN][ZH] Fix using uninitialized memory 'buff' in INI::getNextQuotedAsciiString() (#1097)

xezon · web-flow · commit 0279a8cbfaba · 2025-06-21T23:14:01.000+02:00
diff --git a/Generals/Code/GameEngine/Source/Common/INI/INI.cpp b/Generals/Code/GameEngine/Source/Common/INI/INI.cpp
@@ -725,6 +725,7 @@ AsciiString INI::getNextQuotedAsciiString()
 {
 	AsciiString result;
 	char buff[INI_MAX_CHARS_PER_LINE];
+	buff[0] = '\0';
 
 	const char *token = getNextTokenOrNull();	// if null, just leave an empty string
 	if (token != NULL)
diff --git a/GeneralsMD/Code/GameEngine/Source/Common/INI/INI.cpp b/GeneralsMD/Code/GameEngine/Source/Common/INI/INI.cpp
@@ -717,6 +717,7 @@ AsciiString INI::getNextQuotedAsciiString()
 {
 	AsciiString result;
 	char buff[INI_MAX_CHARS_PER_LINE];
+	buff[0] = '\0';
 
 	const char *token = getNextTokenOrNull();	// if null, just leave an empty string
 	if (token != NULL)

Original file line number	Diff line number	Diff line change
`@@ -725,6 +725,7 @@ AsciiString INI::getNextQuotedAsciiString()`
`725`	`725`	`{`
`726`	`726`	`AsciiString result;`
`727`	`727`	`char buff[INI_MAX_CHARS_PER_LINE];`
	`728`	`+ buff[0] = '\0';`
`728`	`729`
`729`	`730`	`const char *token = getNextTokenOrNull(); // if null, just leave an empty string`
`730`	`731`	`if (token != NULL)`
Original file line number	Diff line number	Diff line change
`@@ -717,6 +717,7 @@ AsciiString INI::getNextQuotedAsciiString()`
`717`	`717`	`{`
`718`	`718`	`AsciiString result;`
`719`	`719`	`char buff[INI_MAX_CHARS_PER_LINE];`
	`720`	`+ buff[0] = '\0';`
`720`	`721`
`721`	`722`	`const char *token = getNextTokenOrNull(); // if null, just leave an empty string`
`722`	`723`	`if (token != NULL)`