-
-
Notifications
You must be signed in to change notification settings - Fork 44
Description
Is your feature request related to a problem? Please describe.
Partially, the plugin makes use of Janus and provides its own configuration including a stun server which is google in that case (https://github.com/TheSpaghettiDetective/OctoPrint-Obico/blob/1d5fa5c32dff11988f15249b8ea77e5e614a2c42/octoprint_obico/bin/janus/run.sh). Now, a pre-chosen stun server might be a security concern. Additionally, for pure local self-hosted installations, a stun is not even needed at all, since no connection to a remote Obico instance is made.
Describe the solution you'd like
- Allow to disable the stun server from the UI. Since the self hosted instance might still run in a public network, the stun server should not be disabled automatically for self-hosted installations.
- If enabled, allow the stun server to be set through the UI.
- restart Janus after the changes
Describe alternatives you've considered
Currently, I either alter the file for remote self-hosted Obico installations or remove the parameter.
Additional context
Add any other context or screenshots about the feature request here.