Skip to content

Commit 9c730e9

Browse files
committed
Mark several types no-export which should be exported eventually
1 parent cda6adc commit 9c730e9

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lightning-types/src/features.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,6 +638,7 @@ pub struct Features<T: sealed::Context> {
638638
mark: PhantomData<T>,
639639
}
640640

641+
/// This is not exported to bindings users but probably should be.
641642
impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Features<T> {
642643
fn bitor_assign(&mut self, rhs: Rhs) {
643644
let total_feature_len = cmp::max(self.flags.len(), rhs.borrow().flags.len());
@@ -648,6 +649,7 @@ impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Feat
648649
}
649650
}
650651

652+
/// This is not exported to bindings users but probably should be.
651653
impl<T: sealed::Context> core::ops::BitOr for Features<T> {
652654
type Output = Self;
653655

lightning/src/events/bump_transaction.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,8 @@ impl Utxo {
275275
}
276276

277277
/// Returns a `Utxo` with the `satisfaction_weight` estimate for a P2WPKH nested in P2SH output.
278+
///
279+
/// This is not exported to bindings users as WPubkeyHash is not yet exported
278280
pub fn new_nested_p2wpkh(outpoint: OutPoint, value: Amount, pubkey_hash: &WPubkeyHash) -> Self {
279281
let script_sig_size = 1 /* script_sig length */ +
280282
1 /* OP_0 */ +
@@ -291,6 +293,8 @@ impl Utxo {
291293
}
292294

293295
/// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v0 P2WPKH output.
296+
///
297+
/// This is not exported to bindings users as WPubkeyHash is not yet exported
294298
pub fn new_v0_p2wpkh(outpoint: OutPoint, value: Amount, pubkey_hash: &WPubkeyHash) -> Self {
295299
Self {
296300
outpoint,

0 commit comments

Comments
 (0)