Skip to content

Commit f154577

Browse files
QuimMoyaQuimMoya
committed
Improved arc support and regression tests
1 parent 6a21ede commit f154577

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

‎src/cpp/geometry/IfcGeometryLoader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1897,7 +1897,7 @@ namespace webifc::geometry
18971897
double angle = 0;
18981898
angle = startRad + ratio * lengthRad;
18991899

1900-
if(byParam)
1900+
if(sameSense == 0)
19011901
{
19021902
angle = startRad + (1 - ratio) * lengthRad;; // not sure why we need this, but we apparently do
19031903
}

‎src/cpp/web-ifc-test.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,10 @@ int main()
283283
// Benchmark();
284284

285285
// return 0;
286-
287-
std::string content = ReadFile("C:/Users/qmoya/Desktop/File2.ifc");
286+
287+
// std::string content = ReadFile("C:/Users/qmoya/Desktop/rac_advanced_sample_project.ifc");
288+
// std::string content = ReadFile("C:/Users/qmoya/Desktop/Element3D 1_modif.ifc");
289+
std::string content = ReadFile("C:/Users/qmoya/Desktop/ISSUE_126_model.ifc");
288290

289291
struct LoaderSettings
290292
{
@@ -322,8 +324,10 @@ int main()
322324
webifc::geometry::IfcGeometryProcessor geometryLoader(loader, schemaManager, set.CIRCLE_SEGMENTS, set.COORDINATE_TO_ORIGIN);
323325

324326
start = ms();
325-
326-
SpecificLoadTest(loader, geometryLoader, 17);
327+
328+
// SpecificLoadTest(loader, geometryLoader, 1179353);
329+
// SpecificLoadTest(loader, geometryLoader, 17);
330+
SpecificLoadTest(loader, geometryLoader, 1221);
327331

328332
// auto meshes = LoadAllTest(loader, geometryLoader, 5557);
329333
auto alignments = GetAlignments(loader, geometryLoader);

‎tests/regression/results.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"tests/ifcfiles/public/AC20-FZK-Haus.ifc":"a0790f61bd5a9a6f1da5fce9ab98de51d6650a0f0aa759e09ec98ae15dd2ab3d","tests/ifcfiles/public/C20-Institute-Var-2.ifc":"ce8768d3a2926d789deb3748d01024b4cd9a6e49d7d58c8756aa8f40ababcaaf","tests/ifcfiles/public/FM_ARC_DigitalHub.ifc":"74bc298319b291e7f97fce66235a6233fda65b3ff5e65d90876d2492b8a95067","tests/ifcfiles/public/ISSUE_005_haus.ifc":"a0790f61bd5a9a6f1da5fce9ab98de51d6650a0f0aa759e09ec98ae15dd2ab3d","tests/ifcfiles/public/ISSUE_021_Mini Project.ifc":"07421e58a8e8caa1899666467c5ce43d6b971dd1802e8c63d539a0019d59b614","tests/ifcfiles/public/ISSUE_034_HouseZ.ifc":"8942e00ec3325abe208f3f9be5c4a1be3f592925a23eef1799d65c347191739e","tests/ifcfiles/public/ISSUE_044_test_IFCCOMPOSITEPROFILEDEF.ifc":"d79fa8f5fc268fa0e8e290cfdcd37742918ea6986759fad3fd0f566c2f72122a","tests/ifcfiles/public/ISSUE_053_20181220Holter_Tower_10.ifczip":"6941ecdeec2b012869e4b4160a78bbb094ddc497b4d42e68e65bc3e3b78e932e","tests/ifcfiles/public/ISSUE_068_ARK_NUS_skolebygg.ifc":"a46e1f7fe834079893387d42d0abba4798eb6403311a25eca5da5475baa205a7","tests/ifcfiles/public/ISSUE_102_M3D-CON-CD.ifc":"a11937a0bd586a54b4de82c6ee407e62624313af9f4561a91419f32294458778","tests/ifcfiles/public/ISSUE_102_M3D-CON.ifc":"2ed47fbc0a5612d7c74a38737711e7fde75a68eb6560dedfd7ac25b99b341570","tests/ifcfiles/public/ISSUE_126_model.ifc":"dbdd42a7ba95f9abf8494c1b5c85244276780f0452778f717ac6ca4062788099","tests/ifcfiles/public/ISSUE_129_N1540_17_EXE_MOD_448200_02_09_11SMC_IGC_V17.ifc":"a729f875b898f302809dc262b229b38b235970f711ac2b7a007d5188af34345f","tests/ifcfiles/public/ISSUE_159_kleine_Wohnung_R22.ifc":"5e385546e4e73c9ccfe0befa9a75683ab9872ea4c5d780be5686bd6d8ee10fc9","tests/ifcfiles/public/ISSUE_171_IfcSurfaceCurveSweptAreaSolid.ifc":"d4b0494345530df29fc9b677965db1da0b1dcac9b7511b52f51d774cae7195cc","tests/ifcfiles/public/IfcOpenHouse_IFC4.ifc":"d3e0dac658a767b9a945542ef3fa5bfc2af9438e4174830a2ef0f0493ef2889d","tests/ifcfiles/public/KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc":"049ce9f394707a79ba60eb2328631a015d34e0f861cf803b39d22c6a74e040ec","tests/ifcfiles/public/Office_A_20110811.ifc":"8a3d9b2635eb26236ba74e75849af8c409bd200d130be941cd1eb8803608bb50","tests/ifcfiles/public/S_Office_Integrated Design Archi.ifc":"e24a1bc57459b43033f62d7c060f7b73359b1c11d04217eed5e7c194d19f145e","tests/ifcfiles/public/Sample_entities.ifc":"80097ba29ac873d079227ec27a44cc62e96c29a608bb5b16ef77ffe97c5435e8","tests/ifcfiles/public/advanced_model.ifc":"e330905eadc4e585a51d517d979596ab15ada77d210bfcb3490f3564ccab41e4","tests/ifcfiles/public/dental_clinic.ifc":"195e2fcd7bc5bec40e1ce7ef4c3dd0ecf75c5947755b112ea55cb3dd73edd6b2","tests/ifcfiles/public/duplex.ifc":"7edbb261beb79c99146dfc1555dfdbafae94228553c764725cd5f94fbaba31a8","tests/ifcfiles/public/example.ifc":"b036a30887c2f9e5676641b499ffe40b0f4cd94fef6ced9ceb2c45841b1cf533","tests/ifcfiles/public/ifcbridge-model01.ifc":"cba4405811a56cedaad53c3ab0ee8c7f45a3cdd151e352cde54d8df5069db1f6","tests/ifcfiles/public/schependomlaan.ifc":"218ac2c148931cb9920cff6e59d7dac3863548d108085241d4fe5d095bd46fb7","tests/ifcfiles/public/tested_sample_project.ifc":"570c5df41625f0b19ea5cd8cce86fdd4b946ac5845531e37b3b03ae0ca78d8e1"}
1+
{"tests/ifcfiles/public/AC20-FZK-Haus.ifc":"a0790f61bd5a9a6f1da5fce9ab98de51d6650a0f0aa759e09ec98ae15dd2ab3d","tests/ifcfiles/public/advanced_model.ifc":"4f180d089d3759124aeae04793fc88c3dfa56275f117aa2843bed2189e8e649f","tests/ifcfiles/public/C20-Institute-Var-2.ifc":"ce8768d3a2926d789deb3748d01024b4cd9a6e49d7d58c8756aa8f40ababcaaf","tests/ifcfiles/public/dental_clinic.ifc":"289ba7f6d509a03e5ce998ed151129e43f6ae9bb47c0afd2ab8e8ee450eba729","tests/ifcfiles/public/duplex.ifc":"1667977d789b900f8fa4006ea771a2f85502498c3ec4bc60e8ac950911fe0d99","tests/ifcfiles/public/example.ifc":"a7ea8762e50dec88bbfcf7e4f92b273456a0e6bbdd6e908a8b9d51c0907444c3","tests/ifcfiles/public/FM_ARC_DigitalHub.ifc":"fdd1f0e1371c7d6f583a17cf82909f05e77e2702a08cc26ba6c6231d2febb5c5","tests/ifcfiles/public/ifcbridge-model01.ifc":"cba4405811a56cedaad53c3ab0ee8c7f45a3cdd151e352cde54d8df5069db1f6","tests/ifcfiles/public/IfcOpenHouse_IFC4.ifc":"d3e0dac658a767b9a945542ef3fa5bfc2af9438e4174830a2ef0f0493ef2889d","tests/ifcfiles/public/ISSUE_005_haus.ifc":"a0790f61bd5a9a6f1da5fce9ab98de51d6650a0f0aa759e09ec98ae15dd2ab3d","tests/ifcfiles/public/ISSUE_021_Mini Project.ifc":"07421e58a8e8caa1899666467c5ce43d6b971dd1802e8c63d539a0019d59b614","tests/ifcfiles/public/ISSUE_034_HouseZ.ifc":"8942e00ec3325abe208f3f9be5c4a1be3f592925a23eef1799d65c347191739e","tests/ifcfiles/public/ISSUE_044_test_IFCCOMPOSITEPROFILEDEF.ifc":"d79fa8f5fc268fa0e8e290cfdcd37742918ea6986759fad3fd0f566c2f72122a","tests/ifcfiles/public/ISSUE_053_20181220Holter_Tower_10.ifczip":"6941ecdeec2b012869e4b4160a78bbb094ddc497b4d42e68e65bc3e3b78e932e","tests/ifcfiles/public/ISSUE_068_ARK_NUS_skolebygg.ifc":"4fcc9b1affcd6b955f664d3ccea523d6ba80ceed1def3f8051e3e35d49d0a1a2","tests/ifcfiles/public/ISSUE_102_M3D-CON-CD.ifc":"a11937a0bd586a54b4de82c6ee407e62624313af9f4561a91419f32294458778","tests/ifcfiles/public/ISSUE_102_M3D-CON.ifc":"2ed47fbc0a5612d7c74a38737711e7fde75a68eb6560dedfd7ac25b99b341570","tests/ifcfiles/public/ISSUE_126_model.ifc":"dbdd42a7ba95f9abf8494c1b5c85244276780f0452778f717ac6ca4062788099","tests/ifcfiles/public/ISSUE_129_N1540_17_EXE_MOD_448200_02_09_11SMC_IGC_V17.ifc":"4e9fe93ad37e998e83adbb6c4d077938ccf39ccca95f5019dbb40f6d0eafa98f","tests/ifcfiles/public/ISSUE_159_kleine_Wohnung_R22.ifc":"5e385546e4e73c9ccfe0befa9a75683ab9872ea4c5d780be5686bd6d8ee10fc9","tests/ifcfiles/public/ISSUE_171_IfcSurfaceCurveSweptAreaSolid.ifc":"d4b0494345530df29fc9b677965db1da0b1dcac9b7511b52f51d774cae7195cc","tests/ifcfiles/public/KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc":"049ce9f394707a79ba60eb2328631a015d34e0f861cf803b39d22c6a74e040ec","tests/ifcfiles/public/Office_A_20110811.ifc":"8a3d9b2635eb26236ba74e75849af8c409bd200d130be941cd1eb8803608bb50","tests/ifcfiles/public/Sample_entities.ifc":"80097ba29ac873d079227ec27a44cc62e96c29a608bb5b16ef77ffe97c5435e8","tests/ifcfiles/public/schependomlaan.ifc":"218ac2c148931cb9920cff6e59d7dac3863548d108085241d4fe5d095bd46fb7","tests/ifcfiles/public/S_Office_Integrated Design Archi.ifc":"e24a1bc57459b43033f62d7c060f7b73359b1c11d04217eed5e7c194d19f145e","tests/ifcfiles/public/tested_sample_project.ifc":"570c5df41625f0b19ea5cd8cce86fdd4b946ac5845531e37b3b03ae0ca78d8e1"}

0 commit comments

Comments
 (0)