changelog

Author: willmcgugan

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 
 - Fixed markup escaping edge cases https://github.com/Textualize/textual/pull/5697
+- Fixed incorrect auto height in Collapsible https://github.com/Textualize/textual/pull/5703
 
 ### Changed
 

src/textual/css/styles.py

@@ -1347,7 +1347,7 @@ def rich_style(self) -> Style:
 
     @property
     def gutter(self) -> Spacing:
-        """Get space around widget.
+        """Get space around widget (padding + border)
 
         Returns:
             Space around widget content.

src/textual/widget.py

@@ -1519,7 +1519,7 @@ def _get_box_model(
         content_width = Fraction(_content_width)
         content_height = Fraction(_content_height)
         is_border_box = styles.box_sizing == "border-box"
-        gutter = styles.gutter
+        gutter = styles.gutter  # Padding plus border
         margin = styles.margin
 
         is_auto_width = styles.width and styles.width.is_auto
@@ -1633,12 +1633,12 @@ def _get_box_model(
             max_height = styles.max_height.resolve(
                 container - margin.totals, viewport, height_fraction
             )
+
             if is_border_box:
                 max_height -= gutter.height
             content_height = min(content_height, max_height)
 
         content_height = max(Fraction(0), content_height)
-
         model = BoxModel(
             content_width + gutter.width, content_height + gutter.height, margin
         )

src/textual/widgets/_collapsible.py

@@ -22,7 +22,7 @@ class CollapsibleTitle(Static, can_focus=True):
     CollapsibleTitle {
         width: auto;
         height: auto;
-        padding: 0 1 0 1;
+        padding: 0 1;
         text-style: $block-cursor-blurred-text-style;
         color: $block-cursor-blurred-foreground;
 
@@ -227,7 +227,8 @@ def _on_mount(self, event: events.Mount) -> None:
 
     def compose(self) -> ComposeResult:
         yield self._title
-        yield self.Contents(*self._contents_list)
+        with self.Contents():
+            yield from self._contents_list
 
     def compose_add_child(self, widget: Widget) -> None:
         """When using the context manager compose syntax, we want to attach nodes to the contents.